@seydx/tr064 - npm Package Compare versions

Comparing version 0.4.1-7 to 0.4.1-8

package.json

 {
   "name": "@seydx/tr064",
-  "version": "0.4.1-7",
+  "version": "0.4.1-8",
   "author": "Nicolai Schmid <[e-mail]>",
@@ -5,0 +5,0 @@ "description": "TR-064 - UPnP/IGD for node.js",

src/Service.js

@@ -346,31 +346,41 @@ var parseString = require('xml2js').parseString;
         } else {
-          parseString(response.body,{explicitArray: false,}, function (err, result) {
-            if(!err){
-	          let env = result['s:Envelope'];  
-	          if(env['s:Body']){
-		          let newBody = env['s:Body'];
-		          if(newBody['s:Fault']){
-			          let fault = newBody['s:Fault'];
-	                  error = {
-	                    error: error ? error.errno : 'No message',
-	                    errorCode: error ? error.errno : 'No code',
-	                    tr064: fault ? fault.detail.UPnPError.errorDescription : 'No message',
-	                    tr064code: fault ? fault.detail.UPnPError.errorCode : 'No code',
-	                    fault: fault ? fault.faultstring : 'No message',
-	                    faultcode: fault ? fault.faultcode : 'No code',
-	                    serviceType: serviceType,
-	                    action: action
-	                  };
-			      }
-		      }  
-            } else {
-              error = {
-                error: error ? error.errno : 'No message',
-                errorCode: error ? error.errno : 'No code',
-                serviceType: serviceType,
-                action: action
-              };
-            }
-          });
-          callback(error, null);
+          if(response){
+            parseString(response.body,{explicitArray: false,}, function (err, result) {
+              if(!err){
+                let env = result['s:Envelope'];  
+                if(env['s:Body']){
+                  let newBody = env['s:Body'];
+                  if(newBody['s:Fault']){
+                    let fault = newBody['s:Fault'];
+                    error = {
+                      error: error ? error.errno : 'No message',
+                      errorCode: error ? error.errno : 'No code',
+                      tr064: fault ? fault.detail.UPnPError.errorDescription : 'No message',
+                      tr064code: fault ? fault.detail.UPnPError.errorCode : 'No code',
+                      fault: fault ? fault.faultstring : 'No message',
+                      faultcode: fault ? fault.faultcode : 'No code',
+                      serviceType: serviceType,
+                      action: action
+                    };
+                  }
+                }  
+              } else {
+                error = {
+                  error: error ? error.errno : 'No message',
+                  errorCode: error ? error.errno : 'No code',
+                  serviceType: serviceType,
+                  action: action
+                };
+              }
+            });
+            callback(error, null);
+          } else {
+            error = {
+              error: error ? error.errno : 'No message',
+              errorCode: error ? error.errno : 'No code',
+              serviceType: serviceType,
+              action: action
+            };
+            callback(error, null);
+          }
         }
@@ -377,0 +387,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

222775

increased by0.18%

Lines of code

722

increased by1.4%

No dependency changes