@shapediver/viewer.rendering-engine.light-engine - npm Package Compare versions

Comparing version 2.6.2 to 2.6.3

dist/implementation/LightEngine.js

@@ -193,8 +193,9 @@ "use strict";
         }
-        if (this._lightScene && this._lightScene.id === id)
+        if (this._lightScene && this._lightScene.id === id) {
             this._lightScene = undefined;
+            while (this._lightNode.children.length > 0)
+                this._lightNode.removeChild(this._lightNode.children[0]);
+            this._lightNode.updateVersion();
+        }
         delete this._lightScenes[id];
-        while (this._lightNode.children.length > 0)
-            this._lightNode.removeChild(this._lightNode.children[0]);
-        this._lightNode.updateVersion();
         if (this._update)
@@ -201,0 +202,0 @@ this._update();

package.json

 {
   "name": "@shapediver/viewer.rendering-engine.light-engine",
-  "version": "2.6.2",
+  "version": "2.6.3",
   "description": "",
@@ -42,11 +42,11 @@ "keywords": [],
   "dependencies": {
-    "@shapediver/viewer.rendering-engine.rendering-engine": "2.6.2",
+    "@shapediver/viewer.rendering-engine.rendering-engine": "2.6.3",
     "@shapediver/viewer.settings": "0.1.39",
-    "@shapediver/viewer.shared.node-tree": "2.6.2",
-    "@shapediver/viewer.shared.services": "2.6.2",
-    "@shapediver/viewer.shared.types": "2.6.2",
+    "@shapediver/viewer.shared.node-tree": "2.6.3",
+    "@shapediver/viewer.shared.services": "2.6.3",
+    "@shapediver/viewer.shared.types": "2.6.3",
     "gl-matrix": "3.3.0",
     "tsyringe": "^4.5.0"
   },
-  "gitHead": "a397e56a13ddf7fd619c780a68e68e2667b1842f"
+  "gitHead": "439d43d5219976059b89ab173d54cdafdd1f5c20"
 }

src/implementation/LightEngine.ts

@@ -222,11 +222,12 @@ import { container, singleton } from 'tsyringe'
 
-        if(this._lightScene && this._lightScene.id === id)
+        if(this._lightScene && this._lightScene.id === id) {
             (<any>this._lightScene) = undefined;
+
+            while (this._lightNode.children.length > 0)
+                this._lightNode.removeChild(this._lightNode.children[0]);
+            this._lightNode.updateVersion();
+        }
         delete this._lightScenes[id];
 
-        while(this._lightNode.children.length > 0)
-            this._lightNode.removeChild(this._lightNode.children[0]);
-        this._lightNode.updateVersion();
-
-        if(this._update) this._update();
+        if (this._update) this._update();
         return true;
@@ -233,0 +234,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No bug tracker

Maintenance

Package does not have a linked bug tracker in package.json.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No bug tracker

Maintenance

Package does not have a linked bug tracker in package.json.

Found 1 instance in 1 package

Improved metrics

Lines of code

2224

increased by0.09%

Worsened metrics

Total package byte prevSize

142666

decreased by-2.99%

Number of package files

88

decreased by-1.12%

Dependency changes

• + Added@shapediver/viewer.rendering-engine.rendering-engine@2.6.3(transitive)

• + Added@shapediver/viewer.shared.build-data@2.6.3(transitive)

• + Added@shapediver/viewer.shared.math@2.6.3(transitive)

• + Added@shapediver/viewer.shared.node-tree@2.6.3(transitive)

• + Added@shapediver/viewer.shared.services@2.6.3(transitive)

• + Added@shapediver/viewer.shared.types@2.6.3(transitive)

• - Removed@shapediver/viewer.rendering-engine.rendering-engine@2.6.2(transitive)

• - Removed@shapediver/viewer.shared.build-data@2.6.2(transitive)

• - Removed@shapediver/viewer.shared.math@2.6.2(transitive)

• - Removed@shapediver/viewer.shared.node-tree@2.6.2(transitive)

• - Removed@shapediver/viewer.shared.services@2.6.2(transitive)

• - Removed@shapediver/viewer.shared.types@2.6.2(transitive)

• Updated@shapediver/viewer.rendering-engine.rendering-engine@2.6.3

• Updated@shapediver/viewer.shared.node-tree@2.6.3

• Updated@shapediver/viewer.shared.services@2.6.3

• Updated@shapediver/viewer.shared.types@2.6.3