@shapediver/viewer.rendering-engine.light-engine - npm Package Compare versions

Comparing version 2.12.8 to 3.0.0

dist/implementation/AbstractLight.d.ts

@@ -1,5 +0,5 @@
-import { UuidGenerator } from '@shapediver/viewer.shared.services';
 import { AbstractTreeNodeData, ITreeNode } from '@shapediver/viewer.shared.node-tree';
+import { Color } from '@shapediver/viewer.shared.types';
 import { ILight, LIGHT_TYPE } from '../interface/ILight';
-import { Color } from '@shapediver/viewer.shared.types';
+import { UuidGenerator } from '@shapediver/viewer.shared.services';
 export declare abstract class AbstractLight extends AbstractTreeNodeData implements ILight {
@@ -25,8 +25,8 @@ #private;
     set order(value: number | undefined);
+    get parentNode(): ITreeNode | undefined;
     set parentNode(value: ITreeNode | undefined);
-    get parentNode(): ITreeNode | undefined;
     get type(): LIGHT_TYPE;
+    get useNodeData(): boolean;
     set useNodeData(value: boolean);
-    get useNodeData(): boolean;
 }
 //# sourceMappingURL=AbstractLight.d.ts.map

dist/implementation/AbstractLight.js

@@ -13,13 +13,13 @@ "use strict";
 };
-var _AbstractLight_type, _AbstractLight_color, _AbstractLight_intensity, _AbstractLight_name, _AbstractLight_order, _AbstractLight_useNodeData, _AbstractLight_parentNode;
+var _AbstractLight_type, _AbstractLight_color, _AbstractLight_intensity, _AbstractLight_name, _AbstractLight_order, _AbstractLight_parentNode, _AbstractLight_useNodeData;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.AbstractLight = void 0;
+const viewer_shared_node_tree_1 = require("@shapediver/viewer.shared.node-tree");
 const viewer_shared_services_1 = require("@shapediver/viewer.shared.services");
-const viewer_shared_node_tree_1 = require("@shapediver/viewer.shared.node-tree");
 class AbstractLight extends viewer_shared_node_tree_1.AbstractTreeNodeData {
-    // #endregion Properties (6)
+    // #endregion Properties (8)
     // #region Constructors (1)
     constructor(properties) {
         super(properties.id, properties.version);
-        // #region Properties (6)
+        // #region Properties (8)
         _AbstractLight_type.set(this, void 0);
@@ -30,4 +30,4 @@ _AbstractLight_color.set(this, void 0);
         _AbstractLight_order.set(this, void 0);
+        _AbstractLight_parentNode.set(this, void 0);
         _AbstractLight_useNodeData.set(this, false);
-        _AbstractLight_parentNode.set(this, void 0);
         this._uuidGenerator = viewer_shared_services_1.UuidGenerator.instance;
@@ -41,3 +41,3 @@ __classPrivateFieldSet(this, _AbstractLight_color, properties.color, "f");
     // #endregion Constructors (1)
-    // #region Public Accessors (9)
+    // #region Public Getters And Setters (13)
     get color() {
@@ -79,20 +79,20 @@ return __classPrivateFieldGet(this, _AbstractLight_color, "f");
     }
+    get parentNode() {
+        return __classPrivateFieldGet(this, _AbstractLight_parentNode, "f");
+    }
     set parentNode(value) {
         __classPrivateFieldSet(this, _AbstractLight_parentNode, value, "f");
     }
-    get parentNode() {
-        return __classPrivateFieldGet(this, _AbstractLight_parentNode, "f");
-    }
     get type() {
         return __classPrivateFieldGet(this, _AbstractLight_type, "f");
     }
+    get useNodeData() {
+        return __classPrivateFieldGet(this, _AbstractLight_useNodeData, "f");
+    }
     set useNodeData(value) {
         __classPrivateFieldSet(this, _AbstractLight_useNodeData, value, "f");
     }
-    get useNodeData() {
-        return __classPrivateFieldGet(this, _AbstractLight_useNodeData, "f");
-    }
 }
 exports.AbstractLight = AbstractLight;
-_AbstractLight_type = new WeakMap(), _AbstractLight_color = new WeakMap(), _AbstractLight_intensity = new WeakMap(), _AbstractLight_name = new WeakMap(), _AbstractLight_order = new WeakMap(), _AbstractLight_useNodeData = new WeakMap(), _AbstractLight_parentNode = new WeakMap();
+_AbstractLight_type = new WeakMap(), _AbstractLight_color = new WeakMap(), _AbstractLight_intensity = new WeakMap(), _AbstractLight_name = new WeakMap(), _AbstractLight_order = new WeakMap(), _AbstractLight_parentNode = new WeakMap(), _AbstractLight_useNodeData = new WeakMap();
 //# sourceMappingURL=AbstractLight.js.map

dist/implementation/LightEngine.d.ts

 import { SettingsEngine } from '@shapediver/viewer.shared.services';
-import { LightScene } from './LightScene';
 import { ILightEngine } from '../interface/ILightEngine';
 import { ILightScene } from '../interface/ILightScene';
 import { IRenderingEngine } from '@shapediver/viewer.rendering-engine.rendering-engine';
+import { LightScene } from './LightScene';
 export declare class LightEngine implements ILightEngine {
@@ -7,0 +7,0 @@ private readonly _renderingEngine;

dist/implementation/LightEngine.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.LightEngine = void 0;
-const gl_matrix_1 = require("gl-matrix");
+const AmbientLight_1 = require("./types/AmbientLight");
 const viewer_shared_services_1 = require("@shapediver/viewer.shared.services");
-const AmbientLight_1 = require("./types/AmbientLight");
 const DirectionalLight_1 = require("./types/DirectionalLight");
 const HemisphereLight_1 = require("./types/HemisphereLight");
+const ILight_1 = require("../interface/ILight");
+const viewer_shared_node_tree_1 = require("@shapediver/viewer.shared.node-tree");
+const LightScene_1 = require("./LightScene");
 const PointLight_1 = require("./types/PointLight");
 const SpotLight_1 = require("./types/SpotLight");
-const LightScene_1 = require("./LightScene");
-const ILight_1 = require("../interface/ILight");
-const viewer_shared_node_tree_1 = require("@shapediver/viewer.shared.node-tree");
+const gl_matrix_1 = require("gl-matrix");
 class LightEngine {
-    // #endregion Properties (6)
+    // #endregion Properties (7)
     // #region Constructors (1)
     constructor(_renderingEngine) {
         this._renderingEngine = _renderingEngine;
-        // #region Properties (6)
+        // #region Properties (7)
         this._converter = viewer_shared_services_1.Converter.instance;
@@ -29,3 +29,3 @@ this._lightNode = new viewer_shared_node_tree_1.TreeNode('lights');
     // #endregion Constructors (1)
-    // #region Public Accessors (2)
+    // #region Public Getters And Setters (4)
     get lightScene() {
@@ -43,11 +43,11 @@ return this._lightScene;
     }
-    // #endregion Public Accessors (2)
+    // #endregion Public Getters And Setters (4)
     // #region Public Methods (6)
     applySettings(settingsEngine) {
         this._lightScenes = {};
-        for (let lightSceneId in settingsEngine.light.lightScenes) {
+        for (const lightSceneId in settingsEngine.light.lightScenes) {
             const lightSceneUUID = this._uuidGenerator.validate(lightSceneId) ? lightSceneId : this._uuidGenerator.create();
             const lightSceneName = settingsEngine.light.lightScenes[lightSceneId].name ? settingsEngine.light.lightScenes[lightSceneId].name : lightSceneId;
             const ls = new LightScene_1.LightScene(this._renderingEngine, { id: lightSceneUUID, name: lightSceneName });
-            for (let lightId in settingsEngine.light.lightScenes[lightSceneId].lights) {
+            for (const lightId in settingsEngine.light.lightScenes[lightSceneId].lights) {
                 const lightUUID = this._uuidGenerator.validate(lightId) ? lightId : this._uuidGenerator.create();
@@ -150,3 +150,3 @@ const light = settingsEngine.light.lightScenes[lightSceneId].lights[lightId];
         if (!this._lightScenes[id]) {
-            for (let lightSceneId in this._lightScenes) {
+            for (const lightSceneId in this._lightScenes) {
                 const lightScene = this._lightScenes[lightSceneId];
@@ -190,3 +190,3 @@ const lightSceneName = lightScene.name || lightSceneId;
         if (!this._lightScenes[id]) {
-            for (let lightSceneId in this._lightScenes) {
+            for (const lightSceneId in this._lightScenes) {
                 const lightScene = this._lightScenes[lightSceneId];
@@ -215,3 +215,3 @@ const lightSceneName = lightScene.name || lightSceneId;
         const converted = {};
-        for (let lightSceneId in this._lightScenes) {
+        for (const lightSceneId in this._lightScenes) {
             const lightScene = this._lightScenes[lightSceneId];
@@ -223,3 +223,3 @@ const lightSceneName = lightScene.name || lightSceneId;
             };
-            for (let lightId in lightScene.lights) {
+            for (const lightId in lightScene.lights) {
                 const light = lightScene.lights[lightId];
@@ -226,0 +226,0 @@ let properties;

dist/implementation/types/AmbientLight.d.ts

@@ -0,6 +1,5 @@
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
 import { IAmbientLight } from '../../interface/types/IAmbientLight';
-import { AbstractLight } from '../AbstractLight';
 export declare class AmbientLight extends AbstractLight implements IAmbientLight {
-    #private;
     constructor(properties: {
@@ -14,7 +13,4 @@ color?: Color;
     });
-    get threeJsObject(): {
-        [key: string]: THREE.AmbientLight;
-    };
     clone(): IAmbientLight;
 }
 //# sourceMappingURL=AmbientLight.d.ts.map

dist/implementation/types/AmbientLight.js

 "use strict";
-var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (receiver, state, kind, f) {
-    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter");
-    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
-    return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
-};
-var _AmbientLight_threeJsObject;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.AmbientLight = void 0;
+const AbstractLight_1 = require("../AbstractLight");
 const ILight_1 = require("../../interface/ILight");
-const AbstractLight_1 = require("../AbstractLight");
 class AmbientLight extends AbstractLight_1.AbstractLight {
-    // #endregion Properties (1)
     // #region Constructors (1)
@@ -25,11 +18,4 @@ constructor(properties) {
         });
-        // #region Properties (1)
-        _AmbientLight_threeJsObject.set(this, {});
     }
     // #endregion Constructors (1)
-    // #region Public Accessors (1)
-    get threeJsObject() {
-        return __classPrivateFieldGet(this, _AmbientLight_threeJsObject, "f");
-    }
-    // #endregion Public Accessors (1)
     // #region Public Methods (1)
@@ -48,3 +34,2 @@ clone() {
 exports.AmbientLight = AmbientLight;
-_AmbientLight_threeJsObject = new WeakMap();
 //# sourceMappingURL=AmbientLight.js.map

dist/implementation/types/DirectionalLight.d.ts

@@ -1,5 +0,5 @@
-import { vec3 } from 'gl-matrix';
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
 import { IDirectionalLight } from '../../interface/types/IDirectionalLight';
-import { AbstractLight } from '../AbstractLight';
+import { vec3 } from 'gl-matrix';
 export declare class DirectionalLight extends AbstractLight implements IDirectionalLight {
@@ -27,7 +27,4 @@ #private;
     set shadowMapResolution(value: number);
-    get threeJsObject(): {
-        [key: string]: THREE.DirectionalLight;
-    };
     clone(): IDirectionalLight;
 }
 //# sourceMappingURL=DirectionalLight.d.ts.map

dist/implementation/types/DirectionalLight.js

@@ -13,8 +13,8 @@ "use strict";
 };
-var _DirectionalLight_castShadow, _DirectionalLight_direction, _DirectionalLight_shadowMapBias, _DirectionalLight_shadowMapResolution, _DirectionalLight_threeJsObject;
+var _DirectionalLight_castShadow, _DirectionalLight_direction, _DirectionalLight_shadowMapBias, _DirectionalLight_shadowMapResolution;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DirectionalLight = void 0;
+const AbstractLight_1 = require("../AbstractLight");
+const ILight_1 = require("../../interface/ILight");
 const gl_matrix_1 = require("gl-matrix");
-const ILight_1 = require("../../interface/ILight");
-const AbstractLight_1 = require("../AbstractLight");
 class DirectionalLight extends AbstractLight_1.AbstractLight {
@@ -38,3 +38,2 @@ // #endregion Properties (4)
         _DirectionalLight_shadowMapResolution.set(this, 1024);
-        _DirectionalLight_threeJsObject.set(this, {});
         if (properties.direction)
@@ -50,3 +49,3 @@ __classPrivateFieldSet(this, _DirectionalLight_direction, properties.direction, "f");
     // #endregion Constructors (1)
-    // #region Public Accessors (8)
+    // #region Public Getters And Setters (8)
     get castShadow() {
@@ -88,6 +87,3 @@ return __classPrivateFieldGet(this, _DirectionalLight_castShadow, "f");
     }
-    get threeJsObject() {
-        return __classPrivateFieldGet(this, _DirectionalLight_threeJsObject, "f");
-    }
-    // #endregion Public Accessors (8)
+    // #endregion Public Getters And Setters (8)
     // #region Public Methods (1)
@@ -110,3 +106,3 @@ clone() {
 exports.DirectionalLight = DirectionalLight;
-_DirectionalLight_castShadow = new WeakMap(), _DirectionalLight_direction = new WeakMap(), _DirectionalLight_shadowMapBias = new WeakMap(), _DirectionalLight_shadowMapResolution = new WeakMap(), _DirectionalLight_threeJsObject = new WeakMap();
+_DirectionalLight_castShadow = new WeakMap(), _DirectionalLight_direction = new WeakMap(), _DirectionalLight_shadowMapBias = new WeakMap(), _DirectionalLight_shadowMapResolution = new WeakMap();
 //# sourceMappingURL=DirectionalLight.js.map

dist/implementation/types/HemisphereLight.d.ts

@@ -0,4 +1,4 @@
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
 import { IHemisphereLight } from '../../interface/types/IHemisphereLight';
-import { AbstractLight } from '../AbstractLight';
 export declare class HemisphereLight extends AbstractLight implements IHemisphereLight {
@@ -17,7 +17,4 @@ #private;
     set groundColor(value: Color);
-    get threeJsObject(): {
-        [key: string]: THREE.HemisphereLight;
-    };
     clone(): IHemisphereLight;
 }
 //# sourceMappingURL=HemisphereLight.d.ts.map

dist/implementation/types/HemisphereLight.js

@@ -13,7 +13,7 @@ "use strict";
 };
-var _HemisphereLight_groundColor, _HemisphereLight_threeJsObject;
+var _HemisphereLight_groundColor;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.HemisphereLight = void 0;
+const AbstractLight_1 = require("../AbstractLight");
 const ILight_1 = require("../../interface/ILight");
-const AbstractLight_1 = require("../AbstractLight");
 class HemisphereLight extends AbstractLight_1.AbstractLight {
@@ -34,3 +34,2 @@ // #endregion Properties (1)
         _HemisphereLight_groundColor.set(this, '#000000');
-        _HemisphereLight_threeJsObject.set(this, {});
         if (properties.groundColor)
@@ -40,3 +39,3 @@ __classPrivateFieldSet(this, _HemisphereLight_groundColor, properties.groundColor, "f");
     // #endregion Constructors (1)
-    // #region Public Accessors (2)
+    // #region Public Getters And Setters (2)
     get groundColor() {
@@ -51,6 +50,3 @@ return __classPrivateFieldGet(this, _HemisphereLight_groundColor, "f");
     }
-    get threeJsObject() {
-        return __classPrivateFieldGet(this, _HemisphereLight_threeJsObject, "f");
-    }
-    // #endregion Public Accessors (2)
+    // #endregion Public Getters And Setters (2)
     // #region Public Methods (1)
@@ -70,3 +66,3 @@ clone() {
 exports.HemisphereLight = HemisphereLight;
-_HemisphereLight_groundColor = new WeakMap(), _HemisphereLight_threeJsObject = new WeakMap();
+_HemisphereLight_groundColor = new WeakMap();
 //# sourceMappingURL=HemisphereLight.js.map

dist/implementation/types/PointLight.d.ts

@@ -1,5 +0,5 @@
-import { vec3 } from 'gl-matrix';
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
 import { IPointLight } from '../../interface/types/IPointLight';
-import { AbstractLight } from '../AbstractLight';
+import { vec3 } from 'gl-matrix';
 export declare class PointLight extends AbstractLight implements IPointLight {
@@ -24,7 +24,4 @@ #private;
     set position(value: vec3);
-    get threeJsObject(): {
-        [key: string]: THREE.PointLight;
-    };
     clone(): IPointLight;
 }
 //# sourceMappingURL=PointLight.d.ts.map

dist/implementation/types/PointLight.js

@@ -13,8 +13,8 @@ "use strict";
 };
-var _PointLight_decay, _PointLight_distance, _PointLight_position, _PointLight_threeJsObject;
+var _PointLight_decay, _PointLight_distance, _PointLight_position;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PointLight = void 0;
+const AbstractLight_1 = require("../AbstractLight");
+const ILight_1 = require("../../interface/ILight");
 const gl_matrix_1 = require("gl-matrix");
-const ILight_1 = require("../../interface/ILight");
-const AbstractLight_1 = require("../AbstractLight");
 class PointLight extends AbstractLight_1.AbstractLight {
@@ -37,3 +37,2 @@ // #endregion Properties (3)
         _PointLight_position.set(this, gl_matrix_1.vec3.fromValues(0, 0, 0));
-        _PointLight_threeJsObject.set(this, {});
         if (properties.position)
@@ -47,3 +46,3 @@ __classPrivateFieldSet(this, _PointLight_position, properties.position, "f");
     // #endregion Constructors (1)
-    // #region Public Accessors (6)
+    // #region Public Getters And Setters (6)
     get decay() {
@@ -76,6 +75,3 @@ return __classPrivateFieldGet(this, _PointLight_decay, "f");
     }
-    get threeJsObject() {
-        return __classPrivateFieldGet(this, _PointLight_threeJsObject, "f");
-    }
-    // #endregion Public Accessors (6)
+    // #endregion Public Getters And Setters (6)
     // #region Public Methods (1)
@@ -97,3 +93,3 @@ clone() {
 exports.PointLight = PointLight;
-_PointLight_decay = new WeakMap(), _PointLight_distance = new WeakMap(), _PointLight_position = new WeakMap(), _PointLight_threeJsObject = new WeakMap();
+_PointLight_decay = new WeakMap(), _PointLight_distance = new WeakMap(), _PointLight_position = new WeakMap();
 //# sourceMappingURL=PointLight.js.map

dist/implementation/types/SpotLight.d.ts

@@ -1,5 +0,5 @@
-import { vec3 } from 'gl-matrix';
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
 import { ISpotLight } from '../../interface/types/ISpotLight';
-import { AbstractLight } from '../AbstractLight';
+import { vec3 } from 'gl-matrix';
 export declare class SpotLight extends AbstractLight implements ISpotLight {
@@ -33,7 +33,4 @@ #private;
     set target(value: vec3);
-    get threeJsObject(): {
-        [key: string]: THREE.SpotLight;
-    };
     clone(): ISpotLight;
 }
 //# sourceMappingURL=SpotLight.d.ts.map

dist/implementation/types/SpotLight.js

@@ -13,8 +13,8 @@ "use strict";
 };
-var _SpotLight_angle, _SpotLight_decay, _SpotLight_distance, _SpotLight_penumbra, _SpotLight_position, _SpotLight_target, _SpotLight_threeJsObject;
+var _SpotLight_angle, _SpotLight_decay, _SpotLight_distance, _SpotLight_penumbra, _SpotLight_position, _SpotLight_target;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SpotLight = void 0;
+const AbstractLight_1 = require("../AbstractLight");
+const ILight_1 = require("../../interface/ILight");
 const gl_matrix_1 = require("gl-matrix");
-const ILight_1 = require("../../interface/ILight");
-const AbstractLight_1 = require("../AbstractLight");
 class SpotLight extends AbstractLight_1.AbstractLight {
@@ -40,3 +40,2 @@ // #endregion Properties (6)
         _SpotLight_target.set(this, gl_matrix_1.vec3.fromValues(0, 0, 0));
-        _SpotLight_threeJsObject.set(this, {});
         if (properties.position)
@@ -56,3 +55,3 @@ __classPrivateFieldSet(this, _SpotLight_position, properties.position, "f");
     // #endregion Constructors (1)
-    // #region Public Accessors (12)
+    // #region Public Getters And Setters (12)
     get angle() {
@@ -112,6 +111,3 @@ return __classPrivateFieldGet(this, _SpotLight_angle, "f");
     }
-    get threeJsObject() {
-        return __classPrivateFieldGet(this, _SpotLight_threeJsObject, "f");
-    }
-    // #endregion Public Accessors (12)
+    // #endregion Public Getters And Setters (12)
     // #region Public Methods (1)
@@ -136,3 +132,3 @@ clone() {
 exports.SpotLight = SpotLight;
-_SpotLight_angle = new WeakMap(), _SpotLight_decay = new WeakMap(), _SpotLight_distance = new WeakMap(), _SpotLight_penumbra = new WeakMap(), _SpotLight_position = new WeakMap(), _SpotLight_target = new WeakMap(), _SpotLight_threeJsObject = new WeakMap();
+_SpotLight_angle = new WeakMap(), _SpotLight_decay = new WeakMap(), _SpotLight_distance = new WeakMap(), _SpotLight_penumbra = new WeakMap(), _SpotLight_position = new WeakMap(), _SpotLight_target = new WeakMap();
 //# sourceMappingURL=SpotLight.js.map

package.json

 {
   "name": "@shapediver/viewer.rendering-engine.light-engine",
-  "version": "2.12.8",
+  "version": "3.0.0",
   "description": "",
@@ -42,10 +42,10 @@ "keywords": [],
   "dependencies": {
-    "@shapediver/viewer.rendering-engine.rendering-engine": "2.12.8",
-    "@shapediver/viewer.settings": "0.5.7",
-    "@shapediver/viewer.shared.node-tree": "2.12.8",
-    "@shapediver/viewer.shared.services": "2.12.8",
-    "@shapediver/viewer.shared.types": "2.12.8",
+    "@shapediver/viewer.rendering-engine.rendering-engine": "3.0.0",
+    "@shapediver/viewer.settings": "1.0.1",
+    "@shapediver/viewer.shared.node-tree": "3.0.0",
+    "@shapediver/viewer.shared.services": "3.0.0",
+    "@shapediver/viewer.shared.types": "3.0.0",
     "gl-matrix": "3.3.0"
   },
-  "gitHead": "615c459595cdea9ceeca8a307d469c617ce36684"
+  "gitHead": "b6b0010bf5d5652aa338df8016405d97f33fcabb"
 }

src/implementation/AbstractLight.ts

@@ -1,10 +0,8 @@
-import { vec3 } from 'gl-matrix'
-import { UuidGenerator } from '@shapediver/viewer.shared.services'
-import { AbstractTreeNodeData, ITreeNode } from '@shapediver/viewer.shared.node-tree'
+import { AbstractTreeNodeData, ITreeNode } from '@shapediver/viewer.shared.node-tree';
+import { Color } from '@shapediver/viewer.shared.types';
+import { ILight, LIGHT_TYPE } from '../interface/ILight';
+import { UuidGenerator } from '@shapediver/viewer.shared.services';
 
-import { ILight, LIGHT_TYPE } from '../interface/ILight'
-import { Color } from '@shapediver/viewer.shared.types'
-
 export abstract class AbstractLight extends AbstractTreeNodeData implements ILight {
-    // #region Properties (6)
+    // #region Properties (8)
 
@@ -17,8 +15,8 @@ readonly #type: LIGHT_TYPE;
     #order?: number;
+    #parentNode?: ITreeNode;
     #useNodeData: boolean = false;
-    #parentNode?: ITreeNode;
 
     protected readonly _uuidGenerator: UuidGenerator = UuidGenerator.instance;
 
-    // #endregion Properties (6)
+    // #endregion Properties (8)
 
@@ -46,3 +44,3 @@ // #region Constructors (1)
 
-    // #region Public Accessors (9)
+    // #region Public Getters And Setters (13)
 
@@ -56,3 +54,3 @@ public get color(): Color {
         this.updateVersion();
-        if(this.parentNode) this.parentNode.updateVersion();
+        if (this.parentNode) this.parentNode.updateVersion();
     }
@@ -67,3 +65,3 @@
         this.updateVersion();
-        if(this.parentNode) this.parentNode.updateVersion();
+        if (this.parentNode) this.parentNode.updateVersion();
     }
@@ -78,3 +76,3 @@
         this.updateVersion();
-        if(this.parentNode) this.parentNode.updateVersion();
+        if (this.parentNode) this.parentNode.updateVersion();
     }
@@ -89,5 +87,9 @@
         this.updateVersion();
-        if(this.parentNode) this.parentNode.updateVersion();
+        if (this.parentNode) this.parentNode.updateVersion();
     }
 
+    public get parentNode(): ITreeNode | undefined {
+        return this.#parentNode;
+    }
+
     public set parentNode(value: ITreeNode | undefined) {
@@ -97,6 +99,2 @@ this.#parentNode = value;
 
-    public get parentNode(): ITreeNode | undefined {
-        return this.#parentNode;
-    }
-
     public get type(): LIGHT_TYPE {
@@ -106,2 +104,6 @@ return this.#type;
 
+    public get useNodeData(): boolean {
+        return this.#useNodeData;
+    }
+
     public set useNodeData(value: boolean) {
@@ -111,7 +113,3 @@ this.#useNodeData = value;
 
-    public get useNodeData(): boolean {
-        return this.#useNodeData;
-    }
-
-    // #endregion Public Accessors (9)
+    // #endregion Public Getters And Setters (13)
 }

src/implementation/LightEngine.ts

@@ -1,20 +0,35 @@
-import { vec3 } from 'gl-matrix'
-import { Converter, UuidGenerator, SettingsEngine, StateEngine } from '@shapediver/viewer.shared.services'
+import { AbstractLight } from './AbstractLight';
+import { AmbientLight } from './types/AmbientLight';
+import {
+    Converter,
+    SettingsEngine,
+    UuidGenerator
+} from '@shapediver/viewer.shared.services';
+import { DirectionalLight } from './types/DirectionalLight';
+import { HemisphereLight } from './types/HemisphereLight';
+import {
+    IAmbientLightProperties,
+    IDirectionalLightProperties,
+    IHemisphereLightProperties,
+    ILightSceneSettings,
+    IPointLightProperties,
+    ISpotLightProperties
+} from '@shapediver/viewer.settings';
+import { LIGHT_TYPE } from '../interface/ILight';
+import { ILightEngine } from '../interface/ILightEngine';
+import { ILightScene } from '../interface/ILightScene';
+import { IRenderingEngine } from '@shapediver/viewer.rendering-engine.rendering-engine';
+import {
+    ITree,
+    ITreeNode,
+    Tree,
+    TreeNode
+} from '@shapediver/viewer.shared.node-tree';
+import { LightScene } from './LightScene';
+import { PointLight } from './types/PointLight';
+import { SpotLight } from './types/SpotLight';
+import { vec3 } from 'gl-matrix';
 
-import { AmbientLight } from './types/AmbientLight'
-import { DirectionalLight } from './types/DirectionalLight'
-import { HemisphereLight } from './types/HemisphereLight'
-import { PointLight } from './types/PointLight'
-import { SpotLight } from './types/SpotLight'
-import { LightScene } from './LightScene'
-import { AbstractLight } from './AbstractLight'
-import { ILightEngine } from '../interface/ILightEngine'
-import { ILight, LIGHT_TYPE } from '../interface/ILight'
-import { ILightScene } from '../interface/ILightScene'
-import { IAmbientLightPropertiesV3, IDirectionalLightPropertiesV3, IHemisphereLightPropertiesV3, ILightSceneSettingsV3, IPointLightPropertiesV3, ISpotLightPropertiesV3 } from '@shapediver/viewer.settings'
-import { ITree, ITreeNode, Tree, TreeNode } from '@shapediver/viewer.shared.node-tree'
-import { IRenderingEngine } from '@shapediver/viewer.rendering-engine.rendering-engine'
-
 export class LightEngine implements ILightEngine {
-    // #region Properties (6)
+    // #region Properties (7)
 
@@ -30,3 +45,3 @@ private readonly _converter: Converter = Converter.instance;
 
-    // #endregion Properties (6)
+    // #endregion Properties (7)
 
@@ -42,3 +57,3 @@ // #region Constructors (1)
 
-    // #region Public Accessors (2)
+    // #region Public Getters And Setters (4)
 
@@ -63,3 +78,3 @@ public get lightScene(): LightScene | null {
 
-    // #endregion Public Accessors (2)
+    // #endregion Public Getters And Setters (4)
 
@@ -71,7 +86,7 @@ // #region Public Methods (6)
 
-        for (let lightSceneId in settingsEngine.light.lightScenes) {
+        for (const lightSceneId in settingsEngine.light.lightScenes) {
             const lightSceneUUID = this._uuidGenerator.validate(lightSceneId) ? lightSceneId : this._uuidGenerator.create();
             const lightSceneName = settingsEngine.light.lightScenes[lightSceneId].name ? settingsEngine.light.lightScenes[lightSceneId].name : lightSceneId;
-            const ls = new LightScene(this._renderingEngine, {id: lightSceneUUID, name: lightSceneName});
-            for (let lightId in settingsEngine.light.lightScenes[lightSceneId].lights) {
+            const ls = new LightScene(this._renderingEngine, { id: lightSceneUUID, name: lightSceneName });
+            for (const lightId in settingsEngine.light.lightScenes[lightSceneId].lights) {
                 const lightUUID = this._uuidGenerator.validate(lightId) ? lightId : this._uuidGenerator.create();
@@ -83,6 +98,6 @@ const light = settingsEngine.light.lightScenes[lightSceneId].lights[lightId];
                         l = new DirectionalLight({
-                            color: this._converter.toHexColor((<IDirectionalLightPropertiesV3>light.properties).color), 
-                            intensity: (<IDirectionalLightPropertiesV3>light.properties).intensity, 
-                            direction: this._converter.toVec3((<IDirectionalLightPropertiesV3>light.properties).direction), 
-                            castShadow: (<IDirectionalLightPropertiesV3>light.properties).castShadow, 
+                            color: this._converter.toHexColor((<IDirectionalLightProperties>light.properties).color),
+                            intensity: (<IDirectionalLightProperties>light.properties).intensity,
+                            direction: this._converter.toVec3((<IDirectionalLightProperties>light.properties).direction),
+                            castShadow: (<IDirectionalLightProperties>light.properties).castShadow,
                             name: light.name ? light.name : lightId,
@@ -95,5 +110,5 @@ order: light.order,
                         l = new HemisphereLight({
-                            color: this._converter.toHexColor((<IHemisphereLightPropertiesV3>light.properties).skyColor), 
-                            intensity: (<IHemisphereLightPropertiesV3>light.properties).intensity, 
-                            groundColor: this._converter.toHexColor((<IHemisphereLightPropertiesV3>light.properties).groundColor), 
+                            color: this._converter.toHexColor((<IHemisphereLightProperties>light.properties).skyColor),
+                            intensity: (<IHemisphereLightProperties>light.properties).intensity,
+                            groundColor: this._converter.toHexColor((<IHemisphereLightProperties>light.properties).groundColor),
                             name: light.name ? light.name : lightId,
@@ -106,7 +121,7 @@ order: light.order,
                         l = new PointLight({
-                            color: this._converter.toHexColor((<IPointLightPropertiesV3>light.properties).color), 
-                            intensity: (<IPointLightPropertiesV3>light.properties).intensity, 
-                            position: this._converter.toVec3((<IPointLightPropertiesV3>light.properties).position), 
-                            distance: (<IPointLightPropertiesV3>light.properties).distance, 
-                            decay: (<IPointLightPropertiesV3>light.properties).decay, 
+                            color: this._converter.toHexColor((<IPointLightProperties>light.properties).color),
+                            intensity: (<IPointLightProperties>light.properties).intensity,
+                            position: this._converter.toVec3((<IPointLightProperties>light.properties).position),
+                            distance: (<IPointLightProperties>light.properties).distance,
+                            decay: (<IPointLightProperties>light.properties).decay,
                             name: light.name ? light.name : lightId,
@@ -119,10 +134,10 @@ order: light.order,
                         l = new SpotLight({
-                            color: this._converter.toHexColor((<ISpotLightPropertiesV3>light.properties).color), 
-                            intensity: (<ISpotLightPropertiesV3>light.properties).intensity, 
-                            position: this._converter.toVec3((<ISpotLightPropertiesV3>light.properties).position), 
-                            target: this._converter.toVec3((<ISpotLightPropertiesV3>light.properties).target), 
-                            distance: (<ISpotLightPropertiesV3>light.properties).distance, 
-                            decay: (<ISpotLightPropertiesV3>light.properties).decay, 
-                            angle: (<ISpotLightPropertiesV3>light.properties).angle, 
-                            penumbra: (<ISpotLightPropertiesV3>light.properties).penumbra, 
+                            color: this._converter.toHexColor((<ISpotLightProperties>light.properties).color),
+                            intensity: (<ISpotLightProperties>light.properties).intensity,
+                            position: this._converter.toVec3((<ISpotLightProperties>light.properties).position),
+                            target: this._converter.toVec3((<ISpotLightProperties>light.properties).target),
+                            distance: (<ISpotLightProperties>light.properties).distance,
+                            decay: (<ISpotLightProperties>light.properties).decay,
+                            angle: (<ISpotLightProperties>light.properties).angle,
+                            penumbra: (<ISpotLightProperties>light.properties).penumbra,
                             name: light.name ? light.name : lightId,
@@ -136,4 +151,4 @@ order: light.order,
                         l = new AmbientLight({
-                            color: this._converter.toHexColor((<IAmbientLightPropertiesV3>light.properties).color), 
-                            intensity: (<IAmbientLightPropertiesV3>light.properties).intensity, 
+                            color: this._converter.toHexColor((<IAmbientLightProperties>light.properties).color),
+                            intensity: (<IAmbientLightProperties>light.properties).intensity,
                             name: light.name ? light.name : lightId,
@@ -150,9 +165,9 @@ order: light.order,
         // there is a light scene but no id is saved (old viewer)
-        if(settingsEngine.light.lightSceneId === undefined && Object.values(settingsEngine.light.lightScenes).length > 0) {
+        if (settingsEngine.light.lightSceneId === undefined && Object.values(settingsEngine.light.lightScenes).length > 0) {
             const res = this.assignLightScene(Object.keys(settingsEngine.light.lightScenes)[0]);
-            if(res === false){
+            if (res === false) {
                 const ls = <LightScene>this.createLightScene({ name: settingsEngine.light.lightSceneId === 'default' ? 'default' : 'standard' });
-                ls.addLight(new AmbientLight({color: '#ffffff', intensity: 0.5, name: 'ambient0'}));
-                ls.addLight(new DirectionalLight({color: '#ffffff', intensity: 0.75, direction: vec3.fromValues(.5774, -.5774, .5774), castShadow: true, name: 'directional0'}));
-                ls.addLight(new DirectionalLight({color: '#ffffff', intensity: 0.35, direction: vec3.fromValues(.25, -1, 1), castShadow: false, name: 'directional1'}));
+                ls.addLight(new AmbientLight({ color: '#ffffff', intensity: 0.5, name: 'ambient0' }));
+                ls.addLight(new DirectionalLight({ color: '#ffffff', intensity: 0.75, direction: vec3.fromValues(.5774, -.5774, .5774), castShadow: true, name: 'directional0' }));
+                ls.addLight(new DirectionalLight({ color: '#ffffff', intensity: 0.35, direction: vec3.fromValues(.25, -1, 1), castShadow: false, name: 'directional1' }));
                 this._lightScenes[ls.id] = ls;
@@ -163,12 +178,12 @@ }
             const res = this.assignLightScene(settingsEngine.light.lightSceneId);
-            if(res === false){
+            if (res === false) {
                 const ls = <LightScene>this.createLightScene({ name: settingsEngine.light.lightSceneId === 'default' ? 'default' : 'standard' });
-                ls.addLight(new AmbientLight({color: '#ffffff', intensity: 0.5, name: 'ambient0'}));
-                ls.addLight(new DirectionalLight({color: '#ffffff', intensity: 0.75, direction: vec3.fromValues(.5774, -.5774, .5774), castShadow: true, name: 'directional0'}));
-                ls.addLight(new DirectionalLight({color: '#ffffff', intensity: 0.35, direction: vec3.fromValues(.25, -1, 1), castShadow: false, name: 'directional1'}));
+                ls.addLight(new AmbientLight({ color: '#ffffff', intensity: 0.5, name: 'ambient0' }));
+                ls.addLight(new DirectionalLight({ color: '#ffffff', intensity: 0.75, direction: vec3.fromValues(.5774, -.5774, .5774), castShadow: true, name: 'directional0' }));
+                ls.addLight(new DirectionalLight({ color: '#ffffff', intensity: 0.35, direction: vec3.fromValues(.25, -1, 1), castShadow: false, name: 'directional1' }));
                 this._lightScenes[ls.id] = ls;
             }
-        }  
+        }
         // this can only be the case if the settings were completely empty, therefore we assign the new light scene
-        else if(JSON.stringify(settingsEngine.settingsJson) == JSON.stringify({})) {    
+        else if (JSON.stringify(settingsEngine.settingsJson) == JSON.stringify({})) {
             const ls = <LightScene>this.createLightScene({ name: 'standard', standard: true });
@@ -178,3 +193,3 @@ this._lightScenes[ls.id] = ls;
 
-        if(this._update) this._update();
+        if (this._update) this._update();
     }
@@ -184,6 +199,6 @@
         if (!this._lightScenes[id]) {
-            for(let lightSceneId in this._lightScenes) {
+            for (const lightSceneId in this._lightScenes) {
                 const lightScene = this._lightScenes[lightSceneId];
                 const lightSceneName = lightScene.name || lightSceneId;
-                if(lightSceneName === id) {
+                if (lightSceneName === id) {
                     const res = this.assignLightScene(lightSceneId);
@@ -196,7 +211,7 @@ return res;
         this._lightScene = this._lightScenes[id];
-        while(this._lightNode.children.length > 0)
+        while (this._lightNode.children.length > 0)
             this._lightNode.removeChild(this._lightNode.children[0]);
         this._lightNode.addChild(this._lightScene!.node);
         this._lightNode.updateVersion();
-        
+
         return true;
@@ -209,17 +224,17 @@ }
 
-    public createLightScene(properties: {name?: string, standard?: boolean}): ILightScene {
+    public createLightScene(properties: { name?: string, standard?: boolean }): ILightScene {
         const lightSceneId = this._uuidGenerator.create();
-        const lightScene = new LightScene(this._renderingEngine, {id: lightSceneId, name: properties.name});
+        const lightScene = new LightScene(this._renderingEngine, { id: lightSceneId, name: properties.name });
         if (properties.standard === true) {
-            lightScene.addLight(new DirectionalLight({color: '#ffffff', intensity: 2.5, direction: vec3.fromValues(.5774, -.5774, .5774), castShadow: true, name: 'directional0'}));
-            lightScene.addLight(new AmbientLight({color: '#ffffff', intensity: 0.3, name: 'ambient0'}));
+            lightScene.addLight(new DirectionalLight({ color: '#ffffff', intensity: 2.5, direction: vec3.fromValues(.5774, -.5774, .5774), castShadow: true, name: 'directional0' }));
+            lightScene.addLight(new AmbientLight({ color: '#ffffff', intensity: 0.3, name: 'ambient0' }));
         }
         this._lightScenes[lightSceneId] = lightScene;
         this._lightScene = lightScene;
-        while(this._lightNode.children.length > 0)
+        while (this._lightNode.children.length > 0)
             this._lightNode.removeChild(this._lightNode.children[0]);
-        this._lightNode.addChild(this._lightScene!.node)
+        this._lightNode.addChild(this._lightScene!.node);
         this._lightNode.updateVersion();
 
-        if(this._update) this._update();
+        if (this._update) this._update();
         return lightScene;
@@ -230,6 +245,6 @@ }
         if (!this._lightScenes[id]) {
-            for(let lightSceneId in this._lightScenes) {
+            for (const lightSceneId in this._lightScenes) {
                 const lightScene = this._lightScenes[lightSceneId];
                 const lightSceneName = lightScene.name || lightSceneId;
-                if(lightSceneName === id) {
+                if (lightSceneName === id) {
                     const res = this.removeLightScene(lightSceneId);
@@ -242,3 +257,3 @@ return res;
 
-        if(this._lightScene && this._lightScene.id === id) {
+        if (this._lightScene && this._lightScene.id === id) {
             (<any>this._lightScene) = undefined;
@@ -258,5 +273,5 @@
         settingsEngine.light.lightSceneId = this.lightScene ? this.lightScene.id : undefined;
-        
-        const converted: ILightSceneSettingsV3 = {};
-        for(let lightSceneId in this._lightScenes) {
+
+        const converted: ILightSceneSettings = {};
+        for (const lightSceneId in this._lightScenes) {
             const lightScene = this._lightScenes[lightSceneId];
@@ -268,5 +283,5 @@ const lightSceneName = lightScene.name || lightSceneId;
             };
-            for(let lightId in lightScene.lights) {
+            for (const lightId in lightScene.lights) {
                 const light = lightScene.lights[lightId];
-                
+
                 let properties;
@@ -282,3 +297,3 @@ switch (light.type) {
                             shadowMapBias: (<DirectionalLight>light).shadowMapBias
-                        }
+                        };
                         break;
@@ -290,3 +305,3 @@ case LIGHT_TYPE.HEMISPHERE:
                             groundColor: this._converter.toHexColor((<HemisphereLight>light).groundColor)
-                        }
+                        };
                         break;
@@ -300,3 +315,3 @@ case LIGHT_TYPE.POINT:
                             decay: (<PointLight>light).decay
-                        }
+                        };
                         break;
@@ -313,3 +328,3 @@ case LIGHT_TYPE.SPOT:
                             penumbra: (<SpotLight>light).penumbra
-                        }
+                        };
                         break;
@@ -321,3 +336,3 @@ case LIGHT_TYPE.AMBIENT:
                             intensity: light.intensity
-                        }
+                        };
                 }
@@ -328,4 +343,4 @@ converted[lightSceneId].lights[lightId] = {
                     properties
-                }
-                if(light.order !== undefined)
+                };
+                if (light.order !== undefined)
                     converted[lightSceneId].lights[lightId].order = light.order;
@@ -332,0 +347,0 @@ }

src/implementation/types/AmbientLight.ts

@@ -1,15 +0,7 @@
-import { ITreeNodeData } from '@shapediver/viewer.shared.node-tree'
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
-
-import { LIGHT_TYPE } from '../../interface/ILight'
 import { IAmbientLight } from '../../interface/types/IAmbientLight';
-import { AbstractLight } from '../AbstractLight'
+import { LIGHT_TYPE } from '../../interface/ILight';
 
 export class AmbientLight extends AbstractLight implements IAmbientLight {
-    // #region Properties (1)
-
-    #threeJsObject: { [key: string]: THREE.AmbientLight } = {};
-
-    // #endregion Properties (1)
-
     // #region Constructors (1)
@@ -26,4 +18,4 @@
         super({
-            color: properties.color || '#ffffff', 
-            intensity: properties.intensity !== undefined ? properties.intensity : 1, 
+            color: properties.color || '#ffffff',
+            intensity: properties.intensity !== undefined ? properties.intensity : 1,
             type: LIGHT_TYPE.AMBIENT,
@@ -39,10 +31,2 @@ name: properties.name,
 
-    // #region Public Accessors (1)
-
-    public get threeJsObject(): { [key: string]: THREE.AmbientLight } {
-        return this.#threeJsObject;
-    }
-
-    // #endregion Public Accessors (1)
-
     // #region Public Methods (1)
@@ -52,4 +36,4 @@
         return new AmbientLight({
-            color: this.color || '#ffffff', 
-            intensity: this.intensity || 0.5, 
+            color: this.color || '#ffffff',
+            intensity: this.intensity || 0.5,
             name: this.name,
@@ -56,0 +40,0 @@ order: this.order,

src/implementation/types/DirectionalLight.ts

@@ -1,8 +0,6 @@
-import { ITreeNodeData } from '@shapediver/viewer.shared.node-tree'
-import { vec3 } from 'gl-matrix'
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
-
-import { LIGHT_TYPE } from '../../interface/ILight'
 import { IDirectionalLight } from '../../interface/types/IDirectionalLight';
-import { AbstractLight } from '../AbstractLight'
+import { LIGHT_TYPE } from '../../interface/ILight';
+import { vec3 } from 'gl-matrix';
 
@@ -16,3 +14,2 @@ export class DirectionalLight extends AbstractLight implements IDirectionalLight {
     #shadowMapResolution: number = 1024;
-    #threeJsObject: { [key: string]: THREE.DirectionalLight } = {};
 
@@ -36,4 +33,4 @@ // #endregion Properties (4)
         super({
-            color: properties.color || '#ffffff', 
-            intensity: properties.intensity !== undefined ? properties.intensity : 1, 
+            color: properties.color || '#ffffff',
+            intensity: properties.intensity !== undefined ? properties.intensity : 1,
             type: LIGHT_TYPE.DIRECTIONAL,
@@ -46,6 +43,6 @@ name: properties.name,
 
-        if(properties.direction) this.#direction = properties.direction;
-        if(properties.castShadow !== undefined) this.#castShadow = properties.castShadow;
-        if(properties.shadowMapResolution) this.#shadowMapResolution = properties.shadowMapResolution;
-        if(properties.shadowMapBias) this.#shadowMapBias = properties.shadowMapBias;
+        if (properties.direction) this.#direction = properties.direction;
+        if (properties.castShadow !== undefined) this.#castShadow = properties.castShadow;
+        if (properties.shadowMapResolution) this.#shadowMapResolution = properties.shadowMapResolution;
+        if (properties.shadowMapBias) this.#shadowMapBias = properties.shadowMapBias;
     }
@@ -55,3 +52,3 @@
 
-    // #region Public Accessors (8)
+    // #region Public Getters And Setters (8)
 
@@ -65,3 +62,3 @@ public get castShadow(): boolean {
         this.updateVersion();
-        if(this.parentNode) this.parentNode.updateVersion();
+        if (this.parentNode) this.parentNode.updateVersion();
     }
@@ -76,3 +73,3 @@
         this.updateVersion();
-        if(this.parentNode) this.parentNode.updateVersion();
+        if (this.parentNode) this.parentNode.updateVersion();
     }
@@ -87,3 +84,3 @@
         this.updateVersion();
-        if(this.parentNode) this.parentNode.updateVersion();
+        if (this.parentNode) this.parentNode.updateVersion();
     }
@@ -98,11 +95,7 @@
         this.updateVersion();
-        if(this.parentNode) this.parentNode.updateVersion();
+        if (this.parentNode) this.parentNode.updateVersion();
     }
 
-    public get threeJsObject(): { [key: string]: THREE.DirectionalLight } {
-        return this.#threeJsObject;
-    }
+    // #endregion Public Getters And Setters (8)
 
-    // #endregion Public Accessors (8)
-
     // #region Public Methods (1)
@@ -109,0 +102,0 @@

src/implementation/types/HemisphereLight.ts

@@ -1,8 +0,5 @@
-import { ITreeNodeData } from '@shapediver/viewer.shared.node-tree'
-import { vec3 } from 'gl-matrix'
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
-
-import { LIGHT_TYPE } from '../../interface/ILight'
 import { IHemisphereLight } from '../../interface/types/IHemisphereLight';
-import { AbstractLight } from '../AbstractLight'
+import { LIGHT_TYPE } from '../../interface/ILight';
 
@@ -13,3 +10,2 @@ export class HemisphereLight extends AbstractLight implements IHemisphereLight {
     #groundColor: Color = '#000000';
-    #threeJsObject: { [key: string]: THREE.HemisphereLight } = {};
 
@@ -44,3 +40,3 @@ // #endregion Properties (1)
 
-    // #region Public Accessors (2)
+    // #region Public Getters And Setters (2)
 
@@ -54,11 +50,7 @@ public get groundColor(): Color {
         this.updateVersion();
-        if(this.parentNode) this.parentNode.updateVersion();
+        if (this.parentNode) this.parentNode.updateVersion();
     }
 
-    public get threeJsObject(): { [key: string]: THREE.HemisphereLight } {
-        return this.#threeJsObject;
-    }
+    // #endregion Public Getters And Setters (2)
 
-    // #endregion Public Accessors (2)
-
     // #region Public Methods (1)
@@ -65,0 +57,0 @@

src/implementation/types/PointLight.ts

@@ -1,8 +0,6 @@
-import { ITreeNodeData } from '@shapediver/viewer.shared.node-tree'
-import { vec3 } from 'gl-matrix'
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
-
-import { LIGHT_TYPE } from '../../interface/ILight'
 import { IPointLight } from '../../interface/types/IPointLight';
-import { AbstractLight } from '../AbstractLight'
+import { LIGHT_TYPE } from '../../interface/ILight';
+import { vec3 } from 'gl-matrix';
 
@@ -15,3 +13,2 @@ export class PointLight extends AbstractLight implements IPointLight {
   #position: vec3 = vec3.fromValues(0, 0, 0);
-  #threeJsObject: { [key: string]: THREE.PointLight } = {};
 
@@ -49,3 +46,3 @@ // #endregion Properties (3)
 
-  // #region Public Accessors (6)
+  // #region Public Getters And Setters (6)
 
@@ -59,3 +56,3 @@ public get decay(): number {
     this.updateVersion();
-    if(this.parentNode) this.parentNode.updateVersion();
+    if (this.parentNode) this.parentNode.updateVersion();
   }
@@ -70,3 +67,3 @@
     this.updateVersion();
-    if(this.parentNode) this.parentNode.updateVersion();
+    if (this.parentNode) this.parentNode.updateVersion();
   }
@@ -81,11 +78,7 @@
     this.updateVersion();
-    if(this.parentNode) this.parentNode.updateVersion();
+    if (this.parentNode) this.parentNode.updateVersion();
   }
 
-  public get threeJsObject(): { [key: string]: THREE.PointLight } {
-      return this.#threeJsObject;
-  }
+  // #endregion Public Getters And Setters (6)
 
-  // #endregion Public Accessors (6)
-
   // #region Public Methods (1)
@@ -92,0 +85,0 @@

src/implementation/types/SpotLight.ts

@@ -1,8 +0,6 @@
-import { ITreeNodeData } from '@shapediver/viewer.shared.node-tree'
-import { vec3 } from 'gl-matrix'
+import { AbstractLight } from '../AbstractLight';
 import { Color } from '@shapediver/viewer.shared.types';
-
-import { LIGHT_TYPE } from '../../interface/ILight'
 import { ISpotLight } from '../../interface/types/ISpotLight';
-import { AbstractLight } from '../AbstractLight'
+import { LIGHT_TYPE } from '../../interface/ILight';
+import { vec3 } from 'gl-matrix';
 
@@ -18,3 +16,2 @@ export class SpotLight extends AbstractLight implements ISpotLight {
   #target: vec3 = vec3.fromValues(0, 0, 0);
-  #threeJsObject: { [key: string]: THREE.SpotLight } = {};
 
@@ -58,3 +55,3 @@ // #endregion Properties (6)
 
-  // #region Public Accessors (12)
+  // #region Public Getters And Setters (12)
 
@@ -68,3 +65,3 @@ public get angle(): number {
     this.updateVersion();
-    if(this.parentNode) this.parentNode.updateVersion();
+    if (this.parentNode) this.parentNode.updateVersion();
   }
@@ -79,3 +76,3 @@
     this.updateVersion();
-    if(this.parentNode) this.parentNode.updateVersion();
+    if (this.parentNode) this.parentNode.updateVersion();
   }
@@ -90,3 +87,3 @@
     this.updateVersion();
-    if(this.parentNode) this.parentNode.updateVersion();
+    if (this.parentNode) this.parentNode.updateVersion();
   }
@@ -101,3 +98,3 @@
     this.updateVersion();
-    if(this.parentNode) this.parentNode.updateVersion();
+    if (this.parentNode) this.parentNode.updateVersion();
   }
@@ -112,3 +109,3 @@
     this.updateVersion();
-    if(this.parentNode) this.parentNode.updateVersion();
+    if (this.parentNode) this.parentNode.updateVersion();
   }
@@ -123,11 +120,7 @@
     this.updateVersion();
-    if(this.parentNode) this.parentNode.updateVersion();
+    if (this.parentNode) this.parentNode.updateVersion();
   }
 
-  public get threeJsObject(): { [key: string]: THREE.SpotLight } {
-      return this.#threeJsObject;
-  }
+  // #endregion Public Getters And Setters (12)
 
-  // #endregion Public Accessors (12)
-
   // #region Public Methods (1)
@@ -134,0 +127,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

151208

decreased by-2.8%

Lines of code

2298

decreased by-2.63%

Dependency changes

• + Added@shapediver/viewer.rendering-engine.rendering-engine@3.0.0(transitive)

• + Added@shapediver/viewer.settings@1.0.1(transitive)

• + Added@shapediver/viewer.shared.build-data@3.0.0(transitive)

• + Added@shapediver/viewer.shared.math@3.0.0(transitive)

• + Added@shapediver/viewer.shared.node-tree@3.0.0(transitive)

• + Added@shapediver/viewer.shared.services@3.0.0(transitive)

• + Added@shapediver/viewer.shared.types@3.0.0(transitive)

• + Addedzod@3.23.8(transitive)

• - Removed@hapi/hoek@9.3.0(transitive)

• - Removed@hapi/topo@5.1.0(transitive)

• - Removed@shapediver/viewer.rendering-engine.rendering-engine@2.12.8(transitive)

• - Removed@shapediver/viewer.settings@0.5.7(transitive)

• - Removed@shapediver/viewer.shared.build-data@2.12.8(transitive)

• - Removed@shapediver/viewer.shared.math@2.12.8(transitive)

• - Removed@shapediver/viewer.shared.node-tree@2.12.8(transitive)

• - Removed@shapediver/viewer.shared.services@2.12.8(transitive)

• - Removed@shapediver/viewer.shared.types@2.12.8(transitive)

• - Removed@sideway/address@4.1.5(transitive)

• - Removed@sideway/formula@3.0.1(transitive)

• - Removed@sideway/pinpoint@2.0.0(transitive)

• - Removed@tweenjs/tween.js@18.6.4(transitive)

• - Removed@types/stats.js@0.17.3(transitive)

• - Removed@types/three@0.152.0(transitive)

• - Removed@types/webxr@0.5.20(transitive)

• - Removedfflate@0.6.10(transitive)

• - Removedjoi@17.13.3(transitive)

• - Removedlil-gui@0.17.0(transitive)

• - Removedthree@0.152.2(transitive)

• Updated@shapediver/viewer.rendering-engine.rendering-engine@3.0.0

• Updated@shapediver/viewer.settings@1.0.1

• Updated@shapediver/viewer.shared.node-tree@3.0.0

• Updated@shapediver/viewer.shared.services@3.0.0

• Updated@shapediver/viewer.shared.types@3.0.0