@skyway-sdk/room - npm Package Compare versions

Comparing version 0.2.0-alpha.24 to 0.2.0-alpha.25

dist/member/local/base.js

@@ -14,3 +14,2 @@ "use strict";
 const common_1 = require("@skyway-sdk/common");
-const core_1 = require("@skyway-sdk/core");
 const __1 = require("..");
@@ -31,12 +30,3 @@ /**@internal */
         this._local.onStreamSubscribed.add((e) => __awaiter(this, void 0, void 0, function* () {
-            var _a;
-            const roomSubscription = (_a = this.room._getSubscription(e.subscription.id)) !== null && _a !== void 0 ? _a : (yield this.room.onStreamSubscribed
-                .watch(({ subscription }) => subscription.id === e.subscription.id, core_1.SkyWayConfig.get.rtcApi.timeout)
-                .catch((error) => {
-                throw new common_1.SkyWayError({
-                    type: 'timeout',
-                    message: 'LocalRoomMemberImpl onStreamSubscribed',
-                    payload: { error },
-                });
-            })).subscription;
+            const roomSubscription = room._addSubscription(e.subscription);
             this.onStreamSubscribed.emit({
@@ -43,0 +33,0 @@ subscription: roomSubscription,

dist/room/base.d.ts

 import { Event } from '@skyway-sdk/common';
-import { ChannelStatus, SkyWayChannel } from '@skyway-sdk/core';
+import { ChannelStatus, SkyWayChannel, Subscription } from '@skyway-sdk/core';
 import { RemoteRoomMember, RemoteRoomMemberImpl, RoomMember, RoomPublication, RoomPublicationImpl, RoomSubscription, RoomSubscriptionImpl } from '..';
@@ -93,2 +93,4 @@ import { LocalRoomMember } from '../member/local/base';
     _getSubscription(id: string): RoomSubscriptionImpl<import("@skyway-sdk/core").RemoteStream>;
+    /**@private */
+    _addSubscription(s: Subscription): RoomSubscriptionImpl<import("@skyway-sdk/core").RemoteStream>;
     private readonly _events;
@@ -95,0 +97,0 @@ readonly onClosed: Event<event.RoomClosedEvent>;

dist/room/base.js

@@ -16,2 +16,3 @@ "use strict";
 const uuid_1 = require("uuid");
+const __1 = require("..");
 /**@internal */
@@ -57,2 +58,12 @@ class RoomImpl {
     }
+    /**@private */
+    _addSubscription(s) {
+        const exist = this._subscriptions[s.id];
+        if (exist) {
+            return exist;
+        }
+        const subscription = new __1.RoomSubscriptionImpl(s, this);
+        this._subscriptions[s.id] = subscription;
+        return subscription;
+    }
     get id() {
@@ -59,0 +70,0 @@ return this._channel.id;

dist/room/p2p.js

@@ -37,4 +37,3 @@ "use strict";
         this._channel.subscriptions.forEach((s) => {
-            const subscription = new __1.RoomSubscriptionImpl(s, this);
-            this._subscriptions[s.id] = subscription;
+            this._addSubscription(s);
         });
@@ -100,4 +99,3 @@ }
         }
-        const subscription = new __1.RoomSubscriptionImpl(s, this);
-        this._subscriptions[s.id] = subscription;
+        const subscription = this._addSubscription(s);
         this.onStreamSubscribed.emit({ subscription });
@@ -104,0 +102,0 @@ this.onSubscriptionChangedEvent.emit({});

dist/room/sfu.js

@@ -58,4 +58,3 @@ "use strict";
             }
-            const subscription = new __1.RoomSubscriptionImpl(s, this);
-            this._subscriptions[s.id] = subscription;
+            this._addSubscription(s);
         });
@@ -128,4 +127,3 @@ }
         }
-        const subscription = new __1.RoomSubscriptionImpl(s, this);
-        this._subscriptions[s.id] = subscription;
+        const subscription = this._addSubscription(s);
         this.onStreamSubscribed.emit({ subscription });
@@ -132,0 +130,0 @@ this.onSubscriptionChangedEvent.emit({});

package.json

 {
   "name": "@skyway-sdk/room",
-  "version": "0.2.0-alpha.24",
+  "version": "0.2.0-alpha.25",
   "description": "The official Next Generation JavaScript SDK for SkyWay",
@@ -5,0 +5,0 @@ "homepage": "https://beta.skyway.ntt.com/",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

2845804

decreased by-0.4%

Lines of code

70399

decreased by-0.48%

No dependency changes