@slack/client - npm Package Compare versions

Comparing version 3.14.1 to 3.14.2

index.js

@@ -10,2 +10,3 @@ var events = require('./lib/clients/events');
   MemoryDataStore: require('./lib/data-store/memory-data-store'),
+  requestOptionsTransport: require('./lib/clients/transports/request').requestOptionsTransport,
   CLIENT_EVENTS: {
@@ -12,0 +13,0 @@ WEB: events.CLIENT_EVENTS.WEB,

lib/clients/transports/request.js

@@ -8,5 +8,5 @@ /**
 var partial = require('lodash').partial;
+var defaults = require('lodash').defaults;
 var request = require('request');
 
-
 var handleRequestTranportRes = function handleRequestTranportRes(cb, err, response, body) {
@@ -54,2 +54,8 @@ var headers;
 
+var requestOptionsTransport = function requestOptionsTransport(options) {
+  return function _requestOptionsTransport(args, cb) {
+    var requestArgs = defaults(options, getRequestTransportArgs(args));
+    request.post(requestArgs, partial(handleRequestTranportRes, cb));
+  };
+};
 
@@ -61,4 +67,4 @@ var requestTransport = function requestTransport(args, cb) {
 
-
 module.exports.proxiedRequestTransport = proxiedRequestTransport;
+module.exports.requestOptionsTransport = requestOptionsTransport;
 module.exports.requestTransport = requestTransport;

package.json

 {
   "name": "@slack/client",
-  "version": "3.14.1",
+  "version": "3.14.2",
   "description": "A library for creating a Slack client",
@@ -5,0 +5,0 @@ "main": "./index",

test/clients/web/client.js

@@ -14,2 +14,3 @@ var expect = require('chai').expect;
 
+var requestTransport = require('../../../lib/clients/transports/request');
 
@@ -113,2 +114,33 @@ var mockTransport = function (args, cb) {
 
+  it('should accept overriding of request options', function () {
+
+    // Add Basic Auth
+
+    var options = {
+      auth: {
+        user: 'slack',
+        pass: 'slack'
+      }
+    };
+
+    var requestOptionsTransport = requestTransport.requestOptionsTransport(options);
+
+    var client = new WebAPIClient('test-token', { transport: requestOptionsTransport });
+
+    // Mock a result where Basic Auth was passed
+
+    nock('https://slack.com/api', {
+      reqheaders: {
+        authorization: /Basic [0-9A-Za-z]+/i
+      }
+    })
+      .post('/test')
+      .reply(200, '{"test":"test"}');
+
+    client._makeAPICall('test', {}, null, function (e, results) {
+      expect(results.test).to.equal('test');
+    });
+
+  });
+
   describe('it should retry failed or rate-limited requests', function () {
@@ -115,0 +147,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

406919

increased by0.33%

Lines of code

8151

increased by0.39%

Worsened metrics

Number of package files

187

decreased by-0.53%

No dependency changes