@soundworks/core - npm Package Compare versions

Comparing version 3.3.0 to 3.3.1

package.json

 {
   "name": "@soundworks/core",
-  "version": "3.3.0",
+  "version": "3.3.1",
   "description": "full-stack javascript framework for distributed audio visual experiences on the web",
@@ -5,0 +5,0 @@ "authors": [

server/Server.js

@@ -406,8 +406,19 @@ "use strict";
       }).then(() => {
-        if (this.templateEngine === null) {
-          throw new Error('Undefined "server.templateEngine": please provide a valid template engine');
+        let nodeOnly = true; // do not throw if no browser clients are defined, very usefull for
+        // cleaning tests in particular
+
+        for (let clientType in this.config.app.clients) {
+          if (this.config.app.clients[clientType].target === 'browser') {
+            nodeOnly = false;
+          }
         }
 
-        if (this.templateDirectory === null) {
-          throw new Error('Undefined "server.templateDirectory": please provide a valid template directory');
+        if (!nodeOnly) {
+          if (this.templateEngine === null) {
+            throw new Error('Undefined "server.templateEngine": please provide a valid template engine');
+          }
+
+          if (this.templateDirectory === null) {
+            throw new Error('Undefined "server.templateDirectory": please provide a valid template directory');
+          }
         } // ------------------------------------------------------------
@@ -431,2 +442,7 @@ // INIT ROUTING
         for (let clientType in this._clientTypeActivitiesMap) {
+          // do nothing if client type is not registered in config
+          if (!(clientType in this.config.app.clients)) {
+            continue;
+          }
+
           if (clientType !== defaultClientType) {
@@ -446,2 +462,7 @@ const clientTarget = this.config.app.clients[clientType].target;
         for (let clientType in this._clientTypeActivitiesMap) {
+          // do nothing if client type is not registered in config
+          if (!(clientType in this.config.app.clients)) {
+            continue;
+          }
+
           if (clientType === defaultClientType) {
@@ -448,0 +469,0 @@ const clientTarget = this.config.app.clients[clientType].target;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

170196

increased by0.41%

Lines of code

4196

increased by0.41%

No dependency changes