@spectrum-web-components/help-text - npm Package Compare versions

Comparing version 0.42.0 to 0.42.1

custom-elements.json

@@ -171,3 +171,3 @@ {
               "privacy": "public",
-              "default": "`sp-help-text-${this.instanceCount}`"
+              "default": "`sp-help-text-${randomID()}`"
             },
@@ -209,18 +209,2 @@ {
             {
-              "kind": "field",
-              "name": "instanceCount",
-              "type": {
-                "text": "number"
-              },
-              "static": true,
-              "default": "HelpTextManager.instanceCount++"
-            },
-            {
-              "kind": "field",
-              "name": "instanceCount",
-              "type": {
-                "text": "number"
-              }
-            },
-            {
               "kind": "method",
@@ -227,0 +211,0 @@ "name": "addId",

package.json

 {
     "name": "@spectrum-web-components/help-text",
-    "version": "0.42.0",
+    "version": "0.42.1",
     "publishConfig": {
@@ -80,7 +80,8 @@ "access": "public"
     "dependencies": {
-        "@spectrum-web-components/base": "^0.42.0",
-        "@spectrum-web-components/icons-workflow": "^0.42.0"
+        "@spectrum-web-components/base": "^0.42.1",
+        "@spectrum-web-components/icons-workflow": "^0.42.1",
+        "@spectrum-web-components/shared": "^0.42.1"
     },
     "devDependencies": {
-        "@spectrum-css/helptext": "^4.1.4"
+        "@spectrum-css/helptext": "^4.1.5"
     },
@@ -93,3 +94,3 @@ "types": "./src/index.d.ts",
     ],
-    "gitHead": "9b3bd55ff8e8f9438817255976e77fd456b19d72"
+    "gitHead": "c7ab5516e86d20194e92114afd04affa490b7248"
 }

src/HelpTextManager.d.ts

@@ -10,4 +10,2 @@ import { TemplateResult } from '@spectrum-web-components/base';
     private get isInternal();
-    static instanceCount: number;
-    instanceCount: number;
     constructor(host: HTMLElement, { mode }?: {
@@ -14,0 +12,0 @@ mode: 'internal' | 'external';

src/HelpTextManager.dev.js

@@ -5,3 +5,4 @@ "use strict";
 import { conditionAttributeWithId } from "@spectrum-web-components/base/src/condition-attribute-with-id.js";
-const _HelpTextManager = class _HelpTextManager {
+import { randomID } from "@spectrum-web-components/shared/src/random-id.js";
+export class HelpTextManager {
   constructor(host, { mode } = { mode: "internal" }) {
@@ -16,4 +17,3 @@ this.mode = "internal";
     this.host = host;
-    this.instanceCount = _HelpTextManager.instanceCount++;
-    this.id = `sp-help-text-${this.instanceCount}`;
+    this.id = `sp-help-text-${randomID()}`;
     this.mode = mode;
@@ -28,3 +28,3 @@ }
                 <slot
-                    name=${negative ? "negative-help-text" : `pass-through-help-text-${this.instanceCount}`}
+                    name=${negative ? "negative-help-text" : `pass-through-help-text-${randomID()}`}
                     @slotchange=${this.handleSlotchange}
@@ -89,5 +89,3 @@ >
   }
-};
-_HelpTextManager.instanceCount = 0;
-export let HelpTextManager = _HelpTextManager;
+}
 //# sourceMappingURL=HelpTextManager.dev.js.map

src/HelpTextManager.js

@@ -1,5 +0,5 @@
-"use strict";import{html as s}from"@spectrum-web-components/base";import{ifDefined as l}from"@spectrum-web-components/base/src/directives.js";import{conditionAttributeWithId as o}from"@spectrum-web-components/base/src/condition-attribute-with-id.js";const i=class i{constructor(e,{mode:n}={mode:"internal"}){this.mode="internal";this.handleSlotchange=({target:e})=>{this.handleHelpText(e),this.handleNegativeHelpText(e)};this.host=e,this.instanceCount=i.instanceCount++,this.id=`sp-help-text-${this.instanceCount}`,this.mode=n}get isInternal(){return this.mode==="internal"}render(e){return s`
+"use strict";import{html as s}from"@spectrum-web-components/base";import{ifDefined as l}from"@spectrum-web-components/base/src/directives.js";import{conditionAttributeWithId as d}from"@spectrum-web-components/base/src/condition-attribute-with-id.js";import{randomID as n}from"@spectrum-web-components/shared/src/random-id.js";export class HelpTextManager{constructor(e,{mode:i}={mode:"internal"}){this.mode="internal";this.handleSlotchange=({target:e})=>{this.handleHelpText(e),this.handleNegativeHelpText(e)};this.host=e,this.id=`sp-help-text-${n()}`,this.mode=i}get isInternal(){return this.mode==="internal"}render(e){return s`
             <div id=${l(this.isInternal?this.id:void 0)}>
                 <slot
-                    name=${e?"negative-help-text":`pass-through-help-text-${this.instanceCount}`}
+                    name=${e?"negative-help-text":`pass-through-help-text-${n()}`}
                     @slotchange=${this.handleSlotchange}
@@ -10,3 +10,3 @@ >
             </div>
-        `}addId(){const e=this.helpTextElement?this.helpTextElement.id:this.id;this.conditionId=o(this.host,"aria-describedby",e),this.host.hasAttribute("tabindex")&&(this.previousTabindex=parseFloat(this.host.getAttribute("tabindex"))),this.host.tabIndex=0}removeId(){this.conditionId&&(this.conditionId(),delete this.conditionId),!this.helpTextElement&&(this.previousTabindex?this.host.tabIndex=this.previousTabindex:this.host.removeAttribute("tabindex"))}handleHelpText(e){if(this.isInternal)return;this.helpTextElement&&this.helpTextElement.id===this.id&&this.helpTextElement.removeAttribute("id"),this.removeId();const t=e.assignedElements()[0];this.helpTextElement=t,t&&(t.id||(t.id=this.id),this.addId())}handleNegativeHelpText(e){if(e.name!=="negative-help-text")return;e.assignedElements().forEach(t=>t.variant="negative")}};i.instanceCount=0;export let HelpTextManager=i;
+        `}addId(){const e=this.helpTextElement?this.helpTextElement.id:this.id;this.conditionId=d(this.host,"aria-describedby",e),this.host.hasAttribute("tabindex")&&(this.previousTabindex=parseFloat(this.host.getAttribute("tabindex"))),this.host.tabIndex=0}removeId(){this.conditionId&&(this.conditionId(),delete this.conditionId),!this.helpTextElement&&(this.previousTabindex?this.host.tabIndex=this.previousTabindex:this.host.removeAttribute("tabindex"))}handleHelpText(e){if(this.isInternal)return;this.helpTextElement&&this.helpTextElement.id===this.id&&this.helpTextElement.removeAttribute("id"),this.removeId();const t=e.assignedElements()[0];this.helpTextElement=t,t&&(t.id||(t.id=this.id),this.addId())}handleNegativeHelpText(e){if(e.name!=="negative-help-text")return;e.assignedElements().forEach(t=>t.variant="negative")}}
 //# sourceMappingURL=HelpTextManager.js.map

No alert changes

Worsened metrics

Total package byte prevSize

136509

decreased by-0.59%

Dependency count

3

increased by50%

Lines of code

923

decreased by-2.12%

Dependency changes

• + Added@spectrum-web-components/shared@^0.42.1

• + Added@lit-labs/observers@2.0.2(transitive)

• + Added@spectrum-web-components/shared@0.42.5(transitive)

• + Addedfocus-visible@5.2.0(transitive)

• Updated@spectrum-web-components/base@^0.42.1

• Updated@spectrum-web-components/icons-workflow@^0.42.1