@spectrum-web-components/iconset - npm Package Compare versions

Comparing version 0.1.4 to 0.1.5

CHANGELOG.md

@@ -6,2 +6,8 @@ # Change Log
 
+## [0.1.5](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/iconset@0.1.4...@spectrum-web-components/iconset@0.1.5) (2019-11-01)
+
+### Bug Fixes
+
+-   remove ":" based namespacing of events ([d77a843](https://github.com/adobe/spectrum-web-components/commit/d77a843))
+
 ## [0.1.4](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/iconset@0.1.3...@spectrum-web-components/iconset@0.1.4) (2019-10-14)
@@ -8,0 +14,0 @@

lib/iconset-registry.d.ts

@@ -19,5 +19,5 @@ import { Iconset } from './iconset.js';
     interface GlobalEventHandlersEventMap {
-        'sp-iconset:added': CustomEvent<IconsetAddedDetail>;
-        'sp-iconset:removed': CustomEvent<IconsetRemovedDetail>;
+        'sp-iconset-added': CustomEvent<IconsetAddedDetail>;
+        'sp-iconset-removed': CustomEvent<IconsetRemovedDetail>;
     }
 }

lib/iconset-registry.js

@@ -17,3 +17,3 @@ export class IconsetRegistry {
         // will know where to look for this event
-        const event = new CustomEvent('sp-iconset:added', {
+        const event = new CustomEvent('sp-iconset-added', {
             bubbles: true,
@@ -33,3 +33,3 @@ composed: true,
         // will know where to look for this event
-        const event = new CustomEvent('sp-iconset:removed', {
+        const event = new CustomEvent('sp-iconset-removed', {
             bubbles: true,
@@ -36,0 +36,0 @@ composed: true,

lib/iconset.js

@@ -58,3 +58,3 @@ import { __decorate } from "tslib";
         this.addIconset();
-        window.addEventListener('sp-iconset:removed', this.handleRemoved);
+        window.addEventListener('sp-iconset-removed', this.handleRemoved);
     }
@@ -66,3 +66,3 @@ /**
         super.disconnectedCallback();
-        window.removeEventListener('sp-iconset:removed', this.handleRemoved);
+        window.removeEventListener('sp-iconset-removed', this.handleRemoved);
         this.removeIconset();
@@ -69,0 +69,0 @@ }

package.json

@@ -21,3 +21,3 @@ {
     ],
-    "version": "0.1.4",
+    "version": "0.1.5",
     "description": "",
@@ -40,3 +40,3 @@ "main": "lib/index.js",
     },
-    "gitHead": "7c3e131bc2bc3b1195e736ff65d3c4e044590ace"
+    "gitHead": "2157014e1c3f8cf184663261e4095eef59011b37"
 }

src/iconset-registry.ts

@@ -39,3 +39,3 @@ /*
         // will know where to look for this event
-        const event = new CustomEvent('sp-iconset:added', {
+        const event = new CustomEvent('sp-iconset-added', {
             bubbles: true,
@@ -55,3 +55,3 @@ composed: true,
         // will know where to look for this event
-        const event = new CustomEvent('sp-iconset:removed', {
+        const event = new CustomEvent('sp-iconset-removed', {
             bubbles: true,
@@ -71,5 +71,5 @@ composed: true,
     interface GlobalEventHandlersEventMap {
-        'sp-iconset:added': CustomEvent<IconsetAddedDetail>;
-        'sp-iconset:removed': CustomEvent<IconsetRemovedDetail>;
+        'sp-iconset-added': CustomEvent<IconsetAddedDetail>;
+        'sp-iconset-removed': CustomEvent<IconsetRemovedDetail>;
     }
 }

src/iconset.ts

@@ -83,3 +83,3 @@ /*
         this.addIconset();
-        window.addEventListener('sp-iconset:removed', this.handleRemoved);
+        window.addEventListener('sp-iconset-removed', this.handleRemoved);
     }
@@ -91,3 +91,3 @@ /**
         super.disconnectedCallback();
-        window.removeEventListener('sp-iconset:removed', this.handleRemoved);
+        window.removeEventListener('sp-iconset-removed', this.handleRemoved);
         this.removeIconset();
@@ -94,0 +94,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

67487

increased by15.88%

Number of package files

24

increased by20%

Lines of code

815

increased by23.48%

Worsened metrics

Number of low license alerts

3

increased by50%

No dependency changes