@spectrum-web-components/slider - npm Package Compare versions

Comparing version 0.2.0 to 0.2.1

CHANGELOG.md

@@ -6,2 +6,8 @@ # Change Log
 
+## [0.2.1](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/slider@0.2.0...@spectrum-web-components/slider@0.2.1) (2019-10-23)
+
+### Bug Fixes
+
+-   **slider:** ensure "sp-slider:input" is dispatched appropriately ([ded5440](https://github.com/adobe/spectrum-web-components/commit/ded5440))
+
 # [0.2.0](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/slider@0.1.3...@spectrum-web-components/slider@0.2.0) (2019-10-14)
@@ -8,0 +14,0 @@

lib/slider.js

@@ -49,3 +49,2 @@ /*
             this.currentMouseEvent = ev;
-            this.dispatchInputEvent();
         };
@@ -99,2 +98,5 @@ }
             this.value = this.clampValue(this.value);
+            if (this.dragging) {
+                this.dispatchInputEvent();
+            }
         }
@@ -267,3 +269,2 @@ }
         this.value = this.calculateHandlePosition(this.currentMouseEvent);
-        this.dispatchInputEvent();
         requestAnimationFrame(() => this._trackMouseEvent());
@@ -300,3 +301,2 @@ }
         this.value = this.calculateHandlePosition(ev);
-        this.dispatchInputEvent();
     }
@@ -323,3 +323,2 @@ onTrackMouseDown(ev) {
         this.input.value = this.value.toString();
-        this.dispatchInputEvent();
         this.dispatchChangeEvent();
@@ -326,0 +325,0 @@ }

package.json

@@ -21,3 +21,3 @@ {
     ],
-    "version": "0.2.0",
+    "version": "0.2.1",
     "description": "",
@@ -43,3 +43,3 @@ "main": "lib/index.js",
     },
-    "gitHead": "7c3e131bc2bc3b1195e736ff65d3c4e044590ace"
+    "gitHead": "5a687cabb4a3a33c9ab10f7c1545560d9c0f92fd"
 }

src/slider.ts

@@ -134,2 +134,5 @@ /*
             this.value = this.clampValue(this.value);
+            if (this.dragging) {
+                this.dispatchInputEvent();
+            }
         }
@@ -315,3 +318,2 @@ }
         this.value = this.calculateHandlePosition(this.currentMouseEvent);
-        this.dispatchInputEvent();
         requestAnimationFrame(() => this._trackMouseEvent());
@@ -351,3 +353,2 @@ }
         this.currentMouseEvent = ev;
-        this.dispatchInputEvent();
     };
@@ -372,3 +373,2 @@
         this.value = this.calculateHandlePosition(ev);
-        this.dispatchInputEvent();
     }
@@ -398,3 +398,2 @@
 
-        this.dispatchInputEvent();
         this.dispatchChangeEvent();
@@ -401,0 +400,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

154178

increased by0.07%

Worsened metrics

Lines of code

2190

decreased by-0.09%

No dependency changes