@spectrum-web-components/textfield - npm Package Compare versions

Comparing version 0.3.7-alpha.1 to 0.3.7

CHANGELOG.md

@@ -6,2 +6,12 @@ # Change Log
 
+## [0.3.7](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/textfield@0.3.6...@spectrum-web-components/textfield@0.3.7) (2020-04-16)
+
+### Bug Fixes
+
+-   **textfield:** remove use of sp-icons-\* ([9a5c213](https://github.com/adobe/spectrum-web-components/commit/9a5c213a886146709601a2878484529c315d9f51))
+
+### Performance Improvements
+
+-   use "sideEffects" listing in package.json ([7271614](https://github.com/adobe/spectrum-web-components/commit/7271614c0ca3ccf3566583bb59467eb15a6199cd))
+
 ## [0.3.6](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/textfield@0.3.5...@spectrum-web-components/textfield@0.3.6) (2020-04-10)
@@ -8,0 +18,0 @@

lib/textfield.d.ts

 import { CSSResultArray, TemplateResult, PropertyValues } from 'lit-element';
 import { Focusable } from '@spectrum-web-components/shared/lib/focusable.js';
 import '@spectrum-web-components/icon';
-import '@spectrum-web-components/icons';
 import { nothing } from 'lit-html';
@@ -6,0 +5,0 @@ export declare class Textfield extends Focusable {

lib/textfield.js

@@ -16,3 +16,3 @@ /*
 import '@spectrum-web-components/icon';
-import '@spectrum-web-components/icons';
+import { AlertSmallIcon, CheckmarkSmallIcon, } from '@spectrum-web-components/icons-ui';
 import textfieldStyles from './textfield.css.js';
@@ -71,8 +71,5 @@ import checkmarkSmallStyles from '@spectrum-web-components/icon/lib/spectrum-icon-checkmark-small.css.js';
             return html `
-                <sp-icons-large></sp-icons-large>
-                <sp-icon
-                    id="invalid"
-                    name="ui:AlertSmall"
-                    class="alert-small"
-                ></sp-icon>
+                <sp-icon id="invalid" class="alert-small">
+                    ${AlertSmallIcon({ hidden: true })}
+                </sp-icon>
             `;
@@ -82,8 +79,5 @@ }
             return html `
-                <sp-icons-large></sp-icons-large>
-                <sp-icon
-                    id="valid"
-                    name="ui:CheckmarkSmall"
-                    class="checkmark-small"
-                ></sp-icon>
+                <sp-icon id="valid" class="checkmark-small">
+                    ${CheckmarkSmallIcon({ hidden: true })}
+                </sp-icon>
             `;
@@ -90,0 +84,0 @@ }

package.json

@@ -21,3 +21,3 @@ {
     ],
-    "version": "0.3.7-alpha.1+e39e02a1",
+    "version": "0.3.7",
     "description": "",
@@ -49,8 +49,8 @@ "main": "lib/index.js",
     "dependencies": {
-        "@spectrum-web-components/icon": "^0.4.6-alpha.11+e39e02a1",
-        "@spectrum-web-components/icons": "^0.3.1-alpha.11+e39e02a1",
-        "@spectrum-web-components/shared": "^0.4.6-alpha.1+e39e02a1",
+        "@spectrum-web-components/icon": "^0.4.6",
+        "@spectrum-web-components/icons-ui": "^0.1.0",
+        "@spectrum-web-components/shared": "^0.4.6",
         "tslib": "^1.10.0"
     },
-    "gitHead": "e39e02a1cbe36c4512a18fa8622a8861f2509629"
+    "gitHead": "c8a769e3b24974f722054bc121f9a896d66e0bf1"
 }

src/textfield.ts

@@ -24,3 +24,6 @@ /*
 import '@spectrum-web-components/icon';
-import '@spectrum-web-components/icons';
+import {
+    AlertSmallIcon,
+    CheckmarkSmallIcon,
+} from '@spectrum-web-components/icons-ui';
 
@@ -118,17 +121,11 @@ import textfieldStyles from './textfield.css.js';
             return html`
-                <sp-icons-large></sp-icons-large>
-                <sp-icon
-                    id="invalid"
-                    name="ui:AlertSmall"
-                    class="alert-small"
-                ></sp-icon>
+                <sp-icon id="invalid" class="alert-small">
+                    ${AlertSmallIcon({ hidden: true })}
+                </sp-icon>
             `;
         } else if (this.valid) {
             return html`
-                <sp-icons-large></sp-icons-large>
-                <sp-icon
-                    id="valid"
-                    name="ui:CheckmarkSmall"
-                    class="checkmark-small"
-                ></sp-icon>
+                <sp-icon id="valid" class="checkmark-small">
+                    ${CheckmarkSmallIcon({ hidden: true })}
+                </sp-icon>
             `;
@@ -135,0 +132,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

171703

increased by16.73%

Number of package files

26

increased by8.33%

Lines of code

1737

increased by9.18%

Number of medium supply chain risk alerts

0

decreased by-100%

Dependency changes

• + Added@spectrum-web-components/icons-ui@^0.1.0

• + Added@spectrum-web-components/icons-ui@0.1.2(transitive)

• - Removed@spectrum-web-components/icons@^0.3.1-alpha.11+e39e02a1

• - Removed@spectrum-web-components/icons@0.3.3(transitive)

• Updated@spectrum-web-components/icon@^0.4.6

• Updated@spectrum-web-components/shared@^0.4.6