@squiz/component-logger-lib - npm Package Compare versions

Comparing version 1.71.0 to 1.71.1

CHANGELOG.md

 # @squiz/component-logger-lib
 
+## 1.71.1
+
+### Patch Changes
+
+- 1187eec: manual bump of dx-common-lib version
+
 ## 1.71.0
@@ -4,0 +10,0 @@

lib/component-logger.js

@@ -105,3 +105,10 @@ "use strict";
                 this.batch.push(...logs);
-                console.error(err);
+                if (!(err instanceof Error)) {
+                    throw err;
+                }
+                if ('response' in err && typeof err.response === 'object' && 'error' in err.response) {
+                    console.warn('Failed to post logs: %s', err.response.error);
+                    return;
+                }
+                console.warn('Failed to post logs: %s', err);
             }
@@ -108,0 +115,0 @@ finally {

lib/component-logger.spec.js

@@ -357,5 +357,4 @@ "use strict";
         const logger = new component_logger_1.ComponentLogger(loggerConfig);
-        await logger.error('some error message', '123');
-        await logger.flush();
-        expect(consoleErrorSpy).toBeCalledWith(new Error('logging failed'));
+        await expect(logger.error('some error message', '123')).resolves.toBeUndefined();
+        await expect(logger.flush()).resolves.toBeUndefined();
     });
@@ -362,0 +361,0 @@ it.each([

package.json

 {
   "name": "@squiz/component-logger-lib",
-  "version": "1.71.0",
+  "version": "1.71.1",
   "description": "",
@@ -22,3 +22,3 @@ "main": "lib/index.js",
   "devDependencies": {
-    "@squiz/dx-common-lib": "^1.64.0",
+    "@squiz/dx-common-lib": "^1.68.3",
     "@types/node": "20.12.12",
@@ -25,0 +25,0 @@ "dotenv": "^16.0.3",

src/component-logger.spec.ts

@@ -415,6 +415,4 @@ import { ComponentLogger, MAX_MESSAGE_LENGTH, MAX_TAG_LENGTH } from './component-logger';
 
-    await logger.error('some error message', '123');
-    await logger.flush();
-
-    expect(consoleErrorSpy).toBeCalledWith(new Error('logging failed'));
+    await expect(logger.error('some error message', '123')).resolves.toBeUndefined();
+    await expect(logger.flush()).resolves.toBeUndefined();
   });
@@ -421,0 +419,0 @@

src/component-logger.ts

@@ -122,3 +122,12 @@ import superagent from 'superagent';
           this.batch.push(...logs);
-          console.error(err);
+          if (!(err instanceof Error)) {
+            throw err;
+          }
+
+          if ('response' in err && typeof err.response === 'object' && 'error' in err.response!) {
+            console.warn('Failed to post logs: %s', err.response.error);
+            return;
+          }
+
+          console.warn('Failed to post logs: %s', err);
         } finally {
@@ -125,0 +134,0 @@ span.end();

tsconfig.json

@@ -12,5 +12,5 @@ {
 
-  "references": [],
+  "references": [{ "path": "../dx-common-lib" }],
   "include": ["src"],
   "exclude": ["jest.config.ts"]
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

162446

increased by2.82%

Lines of code

1376

increased by0.88%

No dependency changes