@ssense/tslint-config - npm Package Compare versions

Comparing version 1.1.0 to 1.1.1

package.json

 {
   "name": "@ssense/tslint-config",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "SSENSE's base TSLint configuration",
@@ -32,11 +32,5 @@ "main": "index.js",
   "devDependencies": {
-    "ghooks": "1.*",
     "tslint": "3.14.*",
     "typescript": "1.8.10"
-  },
-  "config": {
-    "ghooks": {
-      "pre-commit": "npm test"
-    }
   }
 }

README.md

 ## tslint-config
 
+[![npm version](https://badge.fury.io/js/%40ssense%2Ftslint-config.svg)](https://badge.fury.io/js/%40ssense%2Ftslint-config) [![Build Status](https://travis-ci.org/SSENSE/tslint-config.svg?branch=test_integration)](https://travis-ci.org/SSENSE/tslint-config)
+
 The [tslint](http://palantir.github.io/tslint/) config we use at **SSENSE** for all TypeScript projects. It's a combination of base rules provided by tslint as well as rules from [tslint-microsoft-contrib](https://github.com/Microsoft/tslint-microsoft-contrib).
@@ -4,0 +6,0 @@

test/test_app.ts

@@ -8,3 +8,3 @@ //my amazing app
 
-        public baz(): void {
+        public baz(): any {
             return undefined;
@@ -11,0 +11,0 @@ }

test/test.js

@@ -8,3 +8,2 @@ const Linter = require('tslint');
 const options = {
-    formatter: 'json',
     configuration: {
@@ -20,5 +19,5 @@ rules: linterConfig.rules,
 
-const expectedOutput = '[{"endPosition":{"character":16,"line":0,"position":16},"failure":"comment must start with a space","name":"test_app.ts","ruleName":"comment-format","startPosition":{"character":2,"line":0,"position":2}},{"endPosition":{"character":5,"line":10,"position":204},"failure":"The exported module or identifier name must match the file name. Found: test_app.ts and Foo","name":"test_app.ts","ruleName":"export-name","startPosition":{"character":4,"line":2,"position":38}},{"endPosition":{"character":18,"line":3,"position":83},"failure":"Method name does not match /^[a-z][\\\\w\\\\d]+$/: Bar","name":"test_app.ts","ruleName":"function-name","startPosition":{"character":15,"line":3,"position":80}},{"endPosition":{"character":18,"line":2,"position":52},"failure":"Use of default exports is forbidden","name":"test_app.ts","ruleName":"no-default-export","startPosition":{"character":11,"line":2,"position":45}},{"endPosition":{"character":1,"line":11,"position":206},"failure":"\'namespace\' and \'module\' are disallowed","name":"test_app.ts","ruleName":"no-namespace","startPosition":{"character":0,"line":1,"position":17}}]';
+const expectedOutput = fs.readFileSync(__dirname + '/expected-output.txt').toString();
 
-if (result.output !== expectedOutput) {
+if (result.output.trim() !== expectedOutput.trim()) {
     throw new Error(`Linter output did not match expected output. \nActual: ${result.output}\nExpected: ${expectedOutput}`);
@@ -25,0 +24,0 @@ } else {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Improved metrics

Dev dependency count

2

decreased by-33.33%

Number of package files

11

increased by22.22%

Number of lines in readme file

24

increased by9.09%

Number of low supply chain risk alerts

1

decreased by-50%

Worsened metrics

Total package byte prevSize

14887

decreased by-2.97%

Lines of code

177

decreased by-2.75%

No dependency changes