@syncfusion/ej2-navigations - npm Package Compare versions

Comparing version 20.3.48 to 20.3.49

CHANGELOG.md

@@ -5,2 +5,24 @@ # Changelog
 
+### Accordion
+
+#### Bug Fixes
+
+- `SF-397894` - An issue with incorrect aria attributes in accordion has been fixed.
+
+## 20.3.47 (2022-10-11)
+
+### Sidebar
+
+#### Bug Fixes
+
+- `#I397894` - The issue with "using tab index as `0`​ on the container of Sidebar component" has been resolved.
+
+### ContextMenu
+
+#### Bug Fixes
+
+- `#I408315` - Script error thrown in `insertBefore` method While items not available in menu items has been fixed.
+
+## 20.3.48 (2022-10-05)
+
 ### TreeView
@@ -7,0 +29,0 @@

dist/global/index.d.ts

 /*!
 *  filename: index.d.ts
-*  version : 20.3.48
+*  version : 20.3.49
 *  Copyright Syncfusion Inc. 2001 - 2020. All rights reserved.
@@ -5,0 +5,0 @@ *  Use of this code is subject to the terms of our license.

package.json

 {
   "_from": "@syncfusion/ej2-navigations@*",
-  "_id": "@syncfusion/ej2-navigations@20.3.47",
+  "_id": "@syncfusion/ej2-navigations@20.3.48",
   "_inBundle": false,
-  "_integrity": "sha512-8Q1yGMls6TjoqLWvfFtEsRBk8kQmG5kGv4lWgmaWGSpNnWyBs3R8Oll2M8fCR4CuAYQ3MwYjjwVUQCNyhnobdw==",
+  "_integrity": "sha512-Q2g0BP2zJb+C4pecEmgaBUuEYq3B3ITJefvx+s7bg0G8tB4OAHpr74x/AxghpQABAmLccQ5ie6zoVtO4QYR2mw==",
   "_location": "/@syncfusion/ej2-navigations",
@@ -41,4 +41,4 @@ "_phantomChildren": {},
   ],
-  "_resolved": "http://nexus.syncfusion.com/repository/ej2-hotfix-new/@syncfusion/ej2-navigations/-/ej2-navigations-20.3.47.tgz",
-  "_shasum": "b72e95c3f21e9dfcc8a4699887a09cccf791a457",
+  "_resolved": "http://nexus.syncfusion.com/repository/ej2-hotfix-new/@syncfusion/ej2-navigations/-/ej2-navigations-20.3.48.tgz",
+  "_shasum": "874054b33a192fabfd69aba5edfaf2b724d2adce",
   "_spec": "@syncfusion/ej2-navigations@*",
@@ -54,8 +54,8 @@ "_where": "/jenkins/workspace/automation_release_19.1.0.1-ZPMUBNQ6AUYH6YGEFBPVYMEQLRRW2SLD4XCZ6GATNZJFYJ3RIAOA/packages/included",
   "dependencies": {
-    "@syncfusion/ej2-base": "~20.3.48",
-    "@syncfusion/ej2-buttons": "~20.3.48",
+    "@syncfusion/ej2-base": "~20.3.49",
+    "@syncfusion/ej2-buttons": "~20.3.49",
     "@syncfusion/ej2-data": "~20.3.47",
-    "@syncfusion/ej2-inputs": "~20.3.47",
+    "@syncfusion/ej2-inputs": "~20.3.49",
     "@syncfusion/ej2-lists": "~20.3.47",
-    "@syncfusion/ej2-popups": "~20.3.48"
+    "@syncfusion/ej2-popups": "~20.3.49"
   },
@@ -165,4 +165,4 @@ "deprecated": false,
   "typings": "index.d.ts",
-  "version": "20.3.48",
+  "version": "20.3.49",
   "sideEffects": false
 }

src/accordion/accordion.d.ts

@@ -371,3 +371,2 @@ import { Component, EmitType } from '@syncfusion/ej2-base';
     protected getModuleName(): string;
-    private itemAttribUpdate;
     private getItems;
@@ -374,0 +373,0 @@ /**

src/accordion/accordion.js

@@ -162,3 +162,2 @@ var __extends = (this && this.__extends) || (function () {
     Accordion.prototype.destroy = function () {
-        var _this = this;
         if (this.isReact || this.isAngular || this.isVue) {
@@ -184,5 +183,3 @@ this.clearTemplate();
         ele.removeAttribute('style');
-        ['aria-disabled', 'aria-multiselectable', 'role', 'data-ripple'].forEach(function (attrb) {
-            _this.element.removeAttribute(attrb);
-        });
+        this.element.removeAttribute('data-ripple');
         if (!this.isNested && isRippleEnabled) {
@@ -236,5 +233,2 @@ this.removeRippleEffect();
         setStyle(this.element, { 'width': width, 'height': height });
-        var ariaAttr = {
-            'aria-disabled': 'false', 'role': 'presentation', 'aria-multiselectable': 'true'
-        };
         if (isNOU(this.initExpand)) {
@@ -246,6 +240,2 @@ this.initExpand = [];
         }
-        attributes(this.element, ariaAttr);
-        if (this.expandMode === 'Single') {
-            this.element.setAttribute('aria-multiselectable', 'false');
-        }
     };
@@ -561,6 +551,4 @@ Accordion.prototype.renderControl = function () {
         var header = this.createElement('div', { className: CLS_HEADER, id: getUniqueID('acrdn_header') });
-        var items = this.getItems();
         var ariaAttr = {
-            'tabindex': '0', 'role': 'heading', 'aria-label': 'collapsed',
-            'aria-disabled': 'false', 'aria-level': items.length.toString()
+            'tabindex': '0', 'role': 'button', 'aria-disabled': 'false', 'aria-expanded': 'false'
         };
@@ -572,4 +560,3 @@ attributes(header, ariaAttr);
         var innerEle = this.createElement('div', {
-            className: CLS_ITEM, id: item.id || getUniqueID('acrdn_item'),
-            attrs: { 'aria-expanded': 'false', 'role': 'row' }
+            className: CLS_ITEM, id: item.id || getUniqueID('acrdn_item')
         });
@@ -722,3 +709,3 @@ if (this.headerTemplate) {
         content.setAttribute('aria-labelledby', header.id);
-        content.setAttribute('role', 'definition');
+        content.setAttribute('role', 'region');
     };
@@ -822,4 +809,3 @@ Accordion.prototype.contentRendering = function (index) {
             trgt.setAttribute('aria-hidden', 'false');
-            attributes(trgtItemEle, { 'aria-expanded': 'true' });
-            attributes(trgt.previousElementSibling, { 'aria-label': 'expanded' });
+            attributes(trgt.previousElementSibling, { 'aria-expanded': 'true' });
             icon.classList.remove(CLS_TOGANIMATE);
@@ -940,4 +926,3 @@ this.trigger('expanded', eventArgs);
             trgt.setAttribute('aria-hidden', 'true');
-            attributes(trgtItemEle, { 'aria-expanded': 'false' });
-            attributes(trgt.previousElementSibling, { 'aria-label': 'collapsed' });
+            attributes(trgt.previousElementSibling, { 'aria-expanded': 'false' });
             this.trigger('expanded', eventArgs);
@@ -955,10 +940,2 @@ }
     };
-    Accordion.prototype.itemAttribUpdate = function () {
-        var items = this.getItems();
-        var itemEle = this.getItemElements();
-        var itemLen = items.length;
-        itemEle.forEach(function (ele) {
-            select('.' + CLS_HEADER, ele).setAttribute('aria-level', '' + itemLen);
-        });
-    };
     Accordion.prototype.getItems = function () {
@@ -1004,3 +981,2 @@ var items;
                 EventHandler.add(innerItemEle.querySelector('.' + CLS_HEADER), 'blur', _this.focusOut, _this);
-                _this.itemAttribUpdate();
                 _this.expandedIndices = [];
@@ -1046,3 +1022,2 @@ _this.expandedItemRefresh(ele);
         items.splice(index, 1);
-        this.itemAttribUpdate();
         this.expandedIndices = [];
@@ -1334,11 +1309,5 @@ this.expandedItemRefresh(this.element);
                 case 'expandMode':
-                    if (newProp.expandMode === 'Single') {
-                        this.element.setAttribute('aria-multiselectable', 'false');
-                        if (this.expandedIndices.length > 1) {
-                            this.expandItem(false);
-                        }
+                    if (newProp.expandMode === 'Single' && this.expandedIndices.length > 1) {
+                        this.expandItem(false);
                     }
-                    else {
-                        this.element.setAttribute('aria-multiselectable', 'true');
-                    }
                     break;
@@ -1345,0 +1314,0 @@ }

src/sidebar/sidebar.js

@@ -161,3 +161,3 @@ var __extends = (this && this.__extends) || (function () {
         }
-        this.tabIndex = this.element.hasAttribute('tabindex') ? this.element.getAttribute('tabindex') : '0';
+        this.tabIndex = this.element.hasAttribute('tabindex') ? this.element.getAttribute('tabindex') : null;
         if (!this.enableDock && this.type !== 'Auto') {
@@ -172,3 +172,5 @@ addClass([this.element], [VISIBILITY]);
         }
-        this.element.setAttribute('tabindex', this.tabIndex);
+        if (!isNullOrUndefined(this.tabIndex)) {
+            this.element.setAttribute('tabindex', this.tabIndex);
+        }
         if (this.type === 'Auto' && !Browser.isDevice) {
@@ -175,0 +177,0 @@ this.show();

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

19894931

decreased by-0.07%

Lines of code

347743

decreased by-0.03%

Dependency changes

• Updated@syncfusion/ej2-base@~20.3.49

• Updated@syncfusion/ej2-buttons@~20.3.49

• Updated@syncfusion/ej2-inputs@~20.3.49

• Updated@syncfusion/ej2-popups@~20.3.49