@temporalio/common - npm Package Compare versions

Comparing version 0.15.0 to 0.16.0

lib/failure.js

@@ -175,3 +175,3 @@ "use strict";
     /** Activity execution */
-    /\s+at Activity\.execute \(.*\/worker\/(?:src|lib)\/activity\.[jt]s:\d+:\d+\)/,
+    /\s+at Activity\.execute \(.*[\\/]worker[\\/](?:src|lib)[\\/]activity\.[jt]s:\d+:\d+\)/,
     /** Workflow activation */
@@ -178,0 +178,0 @@ /\s+at Activator\.\S+NextHandler \(webpack-internal:\/\/\/.*\/internals\.[jt]s:\d+:\d+\)/,

lib/workflow-options.d.ts

@@ -8,8 +8,2 @@ import { coresdk, google } from '@temporalio/proto/lib/coresdk';
     /**
-     * Workflow id to use when starting. If not specified a UUID is generated. Note that it is
-     * dangerous as in case of client side retries no deduplication will happen based on the
-     * generated id. So prefer assigning business meaningful ids if possible.
-     */
-    workflowId?: string;
-    /**
      * Specifies server behavior if a completed workflow with the same id exists. Note that under no
@@ -24,7 +18,2 @@ * conditions Temporal allows two workflows with the same namespace and workflow id run
     workflowIdReusePolicy?: WorkflowIdReusePolicy;
-    /**
-     * Task queue to use for Workflow tasks. It should match a task queue specified when creating a
-     * `Worker` that hosts the Workflow code.
-     */
-    taskQueue?: string;
     retryPolicy?: coresdk.common.IRetryPolicy;
@@ -88,8 +77,4 @@ /**
 }
-export declare type WorkflowOptions = BaseWorkflowOptions & WorkflowDurationOptions;
-export declare type RequiredWorkflowOptions<T extends Workflow = Workflow> = Required<Pick<BaseWorkflowOptions, 'workflowId' | 'taskQueue'>> & {
-    args: Parameters<T>[];
-};
-export declare type WorkflowOptionsWithDefaults<T extends Workflow = Workflow> = WorkflowOptions & RequiredWorkflowOptions<T>;
-export declare type CompiledWorkflowOptions<T extends Workflow = Workflow> = BaseWorkflowOptions & RequiredWorkflowOptions<T> & {
+export declare type CommonWorkflowOptions = BaseWorkflowOptions & WorkflowDurationOptions;
+export declare type WithCompiledWorkflowDurationOptions<T extends WorkflowDurationOptions> = Omit<T, 'workflowExecutionTimeout' | 'workflowRunTimeout' | 'workflowTaskTimeout'> & {
     workflowExecutionTimeout?: google.protobuf.IDuration;
@@ -99,2 +84,2 @@ workflowRunTimeout?: google.protobuf.IDuration;
 };
-export declare function compileWorkflowOptions<T extends Workflow>({ workflowExecutionTimeout, workflowRunTimeout, workflowTaskTimeout, ...rest }: WorkflowOptionsWithDefaults<T>): CompiledWorkflowOptions<T>;
+export declare function compileWorkflowOptions<T extends WorkflowDurationOptions>({ workflowExecutionTimeout, workflowRunTimeout, workflowTaskTimeout, ...rest }: T): WithCompiledWorkflowDurationOptions<T>;

package.json

 {
   "name": "@temporalio/common",
-  "version": "0.15.0",
+  "version": "0.16.0",
   "description": "Temporal.io SDK common library for use in Workflow and normal code",
@@ -16,3 +16,3 @@ "main": "lib/index.js",
   "dependencies": {
-    "@temporalio/proto": "^0.15.0",
+    "@temporalio/proto": "^0.16.0",
     "ms": "^2.1.3"
@@ -27,3 +27,3 @@ },
   },
-  "gitHead": "81960030b31d52200129d6ea9ebfaa12771dcc45"
+  "gitHead": "42638434f033db2b55c43c2a9a7751d883ba17ec"
 }

src/failure.ts

@@ -201,3 +201,3 @@ import { temporal } from '@temporalio/proto/lib/coresdk';
   /** Activity execution */
-  /\s+at Activity\.execute \(.*\/worker\/(?:src|lib)\/activity\.[jt]s:\d+:\d+\)/,
+  /\s+at Activity\.execute \(.*[\\/]worker[\\/](?:src|lib)[\\/]activity\.[jt]s:\d+:\d+\)/,
   /** Workflow activation */
@@ -204,0 +204,0 @@ /\s+at Activator\.\S+NextHandler \(webpack-internal:\/\/\/.*\/internals\.[jt]s:\d+:\d+\)/,

src/workflow-options.ts

@@ -11,9 +11,2 @@ import { coresdk, google } from '@temporalio/proto/lib/coresdk';
   /**
-   * Workflow id to use when starting. If not specified a UUID is generated. Note that it is
-   * dangerous as in case of client side retries no deduplication will happen based on the
-   * generated id. So prefer assigning business meaningful ids if possible.
-   */
-  workflowId?: string;
-
-  /**
    * Specifies server behavior if a completed workflow with the same id exists. Note that under no
@@ -29,8 +22,2 @@ * conditions Temporal allows two workflows with the same namespace and workflow id run
 
-  /**
-   * Task queue to use for Workflow tasks. It should match a task queue specified when creating a
-   * `Worker` that hosts the Workflow code.
-   */
-  taskQueue?: string;
-
   retryPolicy?: coresdk.common.IRetryPolicy;
@@ -105,20 +92,14 @@
 
-export type WorkflowOptions = BaseWorkflowOptions & WorkflowDurationOptions;
+export type CommonWorkflowOptions = BaseWorkflowOptions & WorkflowDurationOptions;
 
-export type RequiredWorkflowOptions<T extends Workflow = Workflow> = Required<
-  Pick<BaseWorkflowOptions, 'workflowId' | 'taskQueue'>
+export type WithCompiledWorkflowDurationOptions<T extends WorkflowDurationOptions> = Omit<
+  T,
+  'workflowExecutionTimeout' | 'workflowRunTimeout' | 'workflowTaskTimeout'
 > & {
-  args: Parameters<T>[];
+  workflowExecutionTimeout?: google.protobuf.IDuration;
+  workflowRunTimeout?: google.protobuf.IDuration;
+  workflowTaskTimeout?: google.protobuf.IDuration;
 };
 
-export type WorkflowOptionsWithDefaults<T extends Workflow = Workflow> = WorkflowOptions & RequiredWorkflowOptions<T>;
-
-export type CompiledWorkflowOptions<T extends Workflow = Workflow> = BaseWorkflowOptions &
-  RequiredWorkflowOptions<T> & {
-    workflowExecutionTimeout?: google.protobuf.IDuration;
-    workflowRunTimeout?: google.protobuf.IDuration;
-    workflowTaskTimeout?: google.protobuf.IDuration;
-  };
-
-export function compileWorkflowOptions<T extends Workflow>({
+export function compileWorkflowOptions<T extends WorkflowDurationOptions>({
   workflowExecutionTimeout,
@@ -128,3 +109,3 @@ workflowRunTimeout,
   ...rest
-}: WorkflowOptionsWithDefaults<T>): CompiledWorkflowOptions<T> {
+}: T): WithCompiledWorkflowDurationOptions<T> {
   return {
@@ -131,0 +112,0 @@ ...rest,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

207639

decreased by-0.84%

Number of package files

69

decreased by-1.43%

Lines of code

3442

decreased by-0.86%

Dependency changes

• + Added@temporalio/proto@0.16.0(transitive)

• - Removed@temporalio/proto@0.15.0(transitive)

• Updated@temporalio/proto@^0.16.0