@ui5/webcomponents-base - npm Package Compare versions

Comparing version 0.14.0 to 0.15.0

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+# [0.15.0](https://github.com/SAP/ui5-webcomponents/compare/v0.14.0...v0.15.0) (2019-07-04)
+
+
+### Bug Fixes
+
+* **framework:** fix redundant event dispatch ([#599](https://github.com/SAP/ui5-webcomponents/issues/599)) ([dc0cda2](https://github.com/SAP/ui5-webcomponents/commit/dc0cda2))
+
+
+
+
+
 ## [0.14.0](https://github.com/SAP/ui5-webcomponents/compare/v0.13.1...v0.14.0) (2019-06-28)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@ui5/webcomponents-base",
-  "version": "0.14.0",
+  "version": "0.15.0",
   "description": "UI5 Web Components: webcomponents.base",
@@ -24,3 +24,3 @@ "author": "SAP SE (https://www.sap.com)",
   "dependencies": {
-    "@ui5/webcomponents-core": "0.14.0",
+    "@ui5/webcomponents-core": "0.15.0",
     "lit-html": "^1.0.0",
@@ -27,0 +27,0 @@ "regenerator-runtime": "0.12.1",

src/DOMEventHandler.js

@@ -52,3 +52,10 @@ import ManagedEvents from "./events/ManagedEvents.js";
 
+const isOtherInstanceRegistered = () => {
+	return window["@ui5/webcomponents-base/DOMEventHandler"];
+};
 
+const registerInstance = () => {
+	window["@ui5/webcomponents-base/DOMEventHandler"] = true;
+};
+
 class DOMEventHandler {
@@ -60,3 +67,7 @@ constructor() {
 	static start() {
-		ManagedEvents.bindAllEvents(handleEvent);
+		// register the handlers just once in case other bundles include and call this method multiple times
+		if (!isOtherInstanceRegistered()) {
+			ManagedEvents.bindAllEvents(handleEvent);
+			registerInstance();
+		}
 	}
@@ -63,0 +74,0 @@

src/UI5Element.js

@@ -45,3 +45,3 @@ import boot from "./boot.js";
 	onThemeChanged() {
-		if (window.ShadyDOM || this.constructor.getMetadata().getNoShadowDOM()) {
+		if (window.ShadyDOM || !this.constructor.needsShadowDOM()) {
 			// polyfill theme handling is in head styles directly
@@ -64,3 +64,3 @@ return;
 	async _initializeShadowRoot() {
-		if (this.constructor.getMetadata().getNoShadowDOM()) {
+		if (!this.constructor.needsShadowDOM()) {
 			return Promise.resolve();
@@ -89,3 +89,3 @@ }
 
-		if (this.constructor.getMetadata().getNoShadowDOM()) {
+		if (!this.constructor.needsShadowDOM()) {
 			return;
@@ -105,3 +105,3 @@ }
 	disconnectedCallback() {
-		if (this.constructor.getMetadata().getNoShadowDOM()) {
+		if (!this.constructor.needsShadowDOM()) {
 			return;
@@ -595,2 +595,6 @@ }
 
+	static needsShadowDOM() {
+		return !!this.template;
+	}
+
 	static _getDefaultState() {
@@ -597,0 +601,0 @@ if (this._defaultState) {

src/UI5ElementMetadata.js

@@ -13,6 +13,2 @@ import DataType from "./types/DataType.js";
 
-	getNoShadowDOM() {
-		return this.metadata.noShadowDOM;
-	}
-
 	getPropsList() {
@@ -19,0 +15,0 @@ return Object.keys(this.getProperties());

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

681758

increased by0.12%

Number of package files

98

increased by3.16%

Lines of code

12250

increased by0.1%

Dependency changes

• + Added@ui5/webcomponents-core@0.15.0(transitive)

• - Removed@ui5/webcomponents-core@0.14.0(transitive)

• Updated@ui5/webcomponents-core@0.15.0