@vaadin/field-base - npm Package Compare versions

Comparing version 22.0.1 to 22.0.2

package.json

 {
   "name": "@vaadin/field-base",
-  "version": "22.0.1",
+  "version": "22.0.2",
   "publishConfig": {
@@ -34,3 +34,3 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "^22.0.1",
+    "@vaadin/component-base": "^22.0.2",
     "lit": "^2.0.0"
@@ -43,3 +43,3 @@ },
   },
-  "gitHead": "2b0a2bff0369d6020f7cc33ad35506aa2d1f6f68"
+  "gitHead": "df21370c4a655a38eac11f79686021ab3b0887ad"
 }

src/field-mixin.js

@@ -372,10 +372,16 @@ /**
     _invalidChanged(invalid) {
-      // Error message ID needs to be dynamically added / removed based on the validity
-      // Otherwise assistive technologies would announce the error, even if we hide it.
-      if (invalid) {
-        this._fieldAriaController.setErrorId(this._errorId);
-      } else {
-        this._fieldAriaController.setErrorId(null);
-      }
+      // This timeout is needed to prevent NVDA from announcing the error message twice:
+      // 1. Once adding the `[role=alert]` attribute by the `_updateErrorMessage` method (OK).
+      // 2. Once linking the error ID with the ARIA target here (unwanted).
+      // Related issue: https://github.com/vaadin/web-components/issues/3061.
+      setTimeout(() => {
+        // Error message ID needs to be dynamically added / removed based on the validity
+        // Otherwise assistive technologies would announce the error, even if we hide it.
+        if (invalid) {
+          this._fieldAriaController.setErrorId(this._errorId);
+        } else {
+          this._fieldAriaController.setErrorId(null);
+        }
+      });
     }
   };

src/input-controller.d.ts

@@ -6,3 +6,3 @@ /**
  */
-import { SlotController } from './slot-controller.js';
+import { SlotController } from '@vaadin/component-base/src/slot-controller.js';
 
@@ -12,2 +12,2 @@ /**
  */
-export class InputController implements SlotController {}
+export class InputController extends SlotController {}

src/input-controller.js

@@ -6,3 +6,3 @@ /**
  */
-import { SlotController } from './slot-controller.js';
+import { SlotController } from '@vaadin/component-base/src/slot-controller.js';
 
@@ -14,3 +14,4 @@ /**
   constructor(host, callback) {
-    super(host, [
+    super(
+      host,
       'input',
@@ -35,4 +36,4 @@ () => document.createElement('input'),
       }
-    ]);
+    );
   }
 }

src/text-area-controller.d.ts

@@ -6,3 +6,3 @@ /**
  */
-import { SlotController } from './slot-controller.js';
+import { SlotController } from '@vaadin/component-base/src/slot-controller.js';
 
@@ -12,2 +12,2 @@ /**
  */
-export class TextAreaController implements SlotController {}
+export class TextAreaController extends SlotController {}

src/text-area-controller.js

@@ -6,3 +6,3 @@ /**
  */
-import { SlotController } from './slot-controller.js';
+import { SlotController } from '@vaadin/component-base/src/slot-controller.js';
 
@@ -14,3 +14,4 @@ /**
   constructor(host, callback) {
-    super(host, [
+    super(
+      host,
       'textarea',
@@ -38,4 +39,4 @@ () => document.createElement('textarea'),
       }
-    ]);
+    );
   }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

101535

decreased by-0.74%

Number of package files

51

decreased by-3.77%

Lines of code

2701

decreased by-1.1%

Dependency changes

• Updated@vaadin/component-base@^22.0.2