@vaadin/icon - npm Package Compare versions

Comparing version 23.1.0 to 23.1.1

package.json

 {
   "name": "@vaadin/icon",
-  "version": "23.1.0",
+  "version": "23.1.1",
   "publishConfig": {
@@ -36,5 +36,5 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "^23.1.0",
-    "@vaadin/vaadin-lumo-styles": "^23.1.0",
-    "@vaadin/vaadin-themable-mixin": "^23.1.0",
+    "@vaadin/component-base": "^23.1.1",
+    "@vaadin/vaadin-lumo-styles": "^23.1.1",
+    "@vaadin/vaadin-themable-mixin": "^23.1.1",
     "lit": "^2.0.0"
@@ -45,3 +45,3 @@ },
   },
-  "gitHead": "322bba42b83f908a78cd972b06acadc5da95a69d"
+  "gitHead": "390458d6519433a2dd502cef90da48e84573a275"
 }

src/vaadin-icon.js

@@ -86,3 +86,3 @@ /**
         xmlns:xlink="http://www.w3.org/1999/xlink"
-        viewBox="[[__computeViewBox(size)]]"
+        viewBox="[[__computeViewBox(size, __viewBox)]]"
         preserveAspectRatio="xMidYMid meet"
@@ -132,2 +132,5 @@ aria-hidden="true"
       __svgElement: Object,
+
+      /** @private */
+      __viewBox: String,
     };
@@ -186,3 +189,6 @@ }
       const iconset = Iconset.getIconset(iconsetName);
-      const { svg, size } = iconset.applyIcon(icon);
+      const { svg, size, viewBox } = iconset.applyIcon(icon);
+      if (viewBox) {
+        this.__viewBox = viewBox;
+      }
       if (size !== this.size) {
@@ -221,4 +227,4 @@ this.size = size;
   /** @private */
-  __computeViewBox(size) {
-    return `0 0 ${size} ${size}`;
+  __computeViewBox(size, viewBox) {
+    return viewBox || `0 0 ${size} ${size}`;
   }
@@ -225,0 +231,0 @@ }

src/vaadin-iconset.d.ts

@@ -38,3 +38,3 @@ /**
    */
-  applyIcon(name: string): { svg: IconSvgLiteral; size: number };
+  applyIcon(name: string): { svg: IconSvgLiteral; size: number; viewBox: string | null };
 }
@@ -41,0 +41,0 @@

src/vaadin-iconset.js

@@ -85,3 +85,8 @@ /**
     this._icons = this._icons || this.__createIconMap();
-    return { svg: cloneSvgNode(this._icons[this.__getIconId(name)]), size: this.size };
+    const icon = this._icons[this.__getIconId(name)];
+    return {
+      svg: cloneSvgNode(icon),
+      size: this.size,
+      viewBox: icon ? icon.getAttribute('viewBox') : null,
+    };
   }
@@ -88,0 +93,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

19194

increased by1.45%

Lines of code

556

increased by1.83%

Dependency changes

• Updated@vaadin/component-base@^23.1.1

• Updated@vaadin/vaadin-lumo-styles@^23.1.1

• Updated@vaadin/vaadin-themable-mixin@^23.1.1