@vaadin/vaadin-control-state-mixin - npm Package Compare versions

Comparing version 2.1.3 to 2.2.0

package.json

@@ -13,3 +13,3 @@ {
   "name": "@vaadin/vaadin-control-state-mixin",
-  "version": "2.1.3",
+  "version": "2.2.0",
   "main": "vaadin-control-state-mixin.js",
@@ -21,2 +21,6 @@ "author": "Vaadin Ltd",
   },
+  "files": [
+    "vaadin-*.d.ts",
+    "vaadin-*.js"
+  ],
   "resolutions": {
@@ -31,2 +35,5 @@ "inherits": "2.0.3",
   },
+  "scripts": {
+    "generate-typings": "gen-typescript-declarations --outDir . --verify"
+  },
   "devDependencies": {
@@ -33,0 +40,0 @@ "@polymer/iron-test-helpers": "^3.0.0",

README.md

@@ -33,3 +33,3 @@ [![npm version](https://badgen.net/npm/v/@vaadin/vaadin-control-state-mixin)](https://www.npmjs.com/package/@vaadin/vaadin-control-state-mixin)
 
-We are using [ESLint](http://eslint.org/) for linting JavaScript code. You can check if your code is following our standards by running `gulp lint`, which will automatically lint all `.js` files as well as JavaScript snippets inside `.html` files.
+We are using [ESLint](http://eslint.org/) for linting JavaScript code. You can check if your code is following our standards by running `npm run lint`, which will automatically lint all `.js` files as well as JavaScript snippets inside `.html` files.
 
@@ -36,0 +36,0 @@

vaadin-control-state-mixin.js

@@ -10,2 +10,3 @@ /**
  * @polymerMixin
+ * @private
  */
@@ -55,2 +56,3 @@ const TabIndexMixin = superClass => class VaadinTabIndexMixin extends superClass {
        * Stores the previous value of tabindex attribute of the disabled element
+       * @private
        */
@@ -70,2 +72,5 @@ _previousTabIndex: {
 
+      /**
+       * @private
+       */
       _isShiftTabbing: {
@@ -77,2 +82,5 @@ type: Boolean
 
+  /**
+   * @protected
+   */
   ready() {
@@ -142,3 +150,3 @@ this.addEventListener('focusin', e => {
 
-    if (this.autofocus && !this.focused && !this.disabled) {
+    if (this.autofocus && !this.disabled) {
       window.requestAnimationFrame(() => {
@@ -181,2 +189,6 @@ this._focus();
 
+  /**
+   * @param {boolean} focused
+   * @protected
+   */
   _setFocused(focused) {
@@ -198,2 +210,6 @@ if (focused) {
 
+  /**
+   * @param {KeyboardEvent} e
+   * @private
+   */
   _bodyKeydownListener(e) {
@@ -203,2 +219,5 @@ this._tabPressed = e.keyCode === 9;
 
+  /**
+   * @private
+   */
   _bodyKeyupListener() {
@@ -211,2 +230,3 @@ this._tabPressed = false;
    * It returns the actual focusable element in the component.
+   * @return {HTMLElement}
    */
@@ -218,3 +238,6 @@ get focusElement() {
 
-  _focus(e) {
+  /**
+   * @private
+   */
+  _focus() {
     if (this._isShiftTabbing) {
@@ -251,2 +274,6 @@ return;
 
+  /**
+   * @param {boolean} disabled
+   * @private
+   */
   _disabledChanged(disabled) {
@@ -267,2 +294,6 @@ this.focusElement.disabled = disabled;
 
+  /**
+   * @param {number | null | undefined} tabindex
+   * @private
+   */
   _tabindexChanged(tabindex) {
@@ -269,0 +300,0 @@ if (tabindex !== undefined) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

320

increased by26.98%

Worsened metrics

Total package byte prevSize

23795

decreased by-35.93%

Number of package files

5

decreased by-28.57%

No dependency changes