@vaadin/vaadin-dialog - npm Package Compare versions

Comparing version 2.3.0 to 2.3.1

package.json

@@ -13,3 +13,3 @@ {
   "name": "@vaadin/vaadin-dialog",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "main": "vaadin-dialog.js",
@@ -41,3 +41,6 @@ "author": "Vaadin Ltd",
   },
-  "devDependencies": {
+  "scripts": {
+  "generate-typings": "gen-typescript-declarations --outDir . --verify"
+},
+"devDependencies": {
     "@polymer/iron-component-page": "^4.0.0",
@@ -44,0 +47,0 @@ "@polymer/iron-test-helpers": "^3.0.0",

src/vaadin-dialog-draggable-mixin.js

@@ -36,2 +36,7 @@ const TOUCH_DEVICE = (() => {
     _startDrag(e) {
+      // Don't initiate when there's more than 1 touch (pinch zoom)
+      if (e.type === 'touchstart' && e.touches.length > 1) {
+        return;
+      }
+
       if (this.draggable && (e.button === 0 || e.touches)) {
@@ -44,4 +49,3 @@ const resizerContainer = this.$.overlay.$.resizerContainer;
         if ((isResizerContainer && !isResizerContainerScrollbar) || isContentPart || isDraggable) {
-          // Is needed to prevent text selection in Safari
-          !this._touchDevice && !isDraggable && e.preventDefault();
+          !isDraggable && e.preventDefault();
           this._originalBounds = this._getOverlayBounds();
@@ -63,4 +67,3 @@ const event = this.__getMouseOrFirstTouchEvent(e);
       const event = this.__getMouseOrFirstTouchEvent(e);
-      if (this._eventInWindow(event) &&
-        (e.type !== 'touchmove' || e.type === 'touchmove' && e.touches.length < 2)) {
+      if (this._eventInWindow(event)) {
         const top = this._originalBounds.top + (event.pageY - this._originalMouseCoords.top);
@@ -67,0 +70,0 @@ const left = this._originalBounds.left + (event.pageX - this._originalMouseCoords.left);

src/vaadin-dialog-resizable-mixin.js

@@ -9,7 +9,5 @@ const $_documentContainer = document.createElement('template');
         overflow: visible;
-      }
-
-      /* Hack for iOS to make the overlay take full size */
-      [part='overlay'][style] {
+        max-height: 100%;
         display: flex;
+        flex-direction: column;
       }
@@ -23,5 +21,9 @@
       .resizer-container {
+        overflow: auto;
+        flex-grow: 1;
+      }
+
+      [part='overlay'][style] .resizer-container {
         height: 100%;
         width: 100%;
-        overflow: auto;
       }
@@ -95,2 +97,8 @@
       }
+
+      /* IE11 -only CSS */
+      _:-ms-fullscreen,
+      [part='overlay'] {
+        max-height: none;
+      }
     </style>
@@ -134,2 +142,7 @@ </template>
     _startResize(e, direction) {
+      // Don't initiate when there's more than 1 touch (pinch zoom)
+      if (e.type === 'touchstart' && e.touches.length > 1) {
+        return;
+      }
+
       if (e.button === 0 || e.touches) {
@@ -152,4 +165,3 @@ e.preventDefault();
       const event = this.__getMouseOrFirstTouchEvent(e);
-      if (this._eventInWindow(event) &&
-        (e.type !== 'touchmove' || e.type === 'touchmove' && e.touches.length < 2)) {
+      if (this._eventInWindow(event)) {
         const minimumSize = 40;
@@ -156,0 +168,0 @@ resizer.split('').forEach((direction) => {

src/vaadin-dialog.js

@@ -45,3 +45,3 @@ /**
  *
- * @memberof Vaadin
+ * @extends PolymerElement
  * @private
@@ -134,5 +134,5 @@ */
  *
- * @memberof Vaadin
- * @mixes Vaadin.ElementMixin
- * @mixes Vaadin.ThemePropertyMixin
+ * @extends PolymerElement
+ * @mixes ElementMixin
+ * @mixes ThemePropertyMixin
  * @demo demo/index.html
@@ -164,3 +164,3 @@ */
   static get version() {
-    return '2.3.0';
+    return '2.3.1';
   }
@@ -274,13 +274,4 @@
     });
-
-    // We need to prevent dragging behind the non-draggable content of the dialog (i.e slotted text / button)
-    this.$.overlay.$.content.addEventListener('touchmove', this._preventMove, {passive: false});
   }
 
-  _preventMove(e) {
-    if (e.touches.length < 2) {
-      e.preventDefault();
-    }
-  }
-
   _setTemplateFromNodes(nodes) {
@@ -287,0 +278,0 @@ this._contentTemplate = nodes.filter(node => node.localName && node.localName === 'template')[0] || this._contentTemplate;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Lines of code

691

increased by0.73%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

40625

decreased by-0.01%

No dependency changes