@vaadin/vaadin-text-field - npm Package Compare versions

Comparing version 2.4.4 to 2.4.5

package.json

@@ -13,3 +13,3 @@ {
   "name": "@vaadin/vaadin-text-field",
-  "version": "2.4.4",
+  "version": "2.4.5",
   "main": "vaadin-text-field.js",
@@ -46,5 +46,5 @@ "author": "Vaadin Ltd",
     "wct-browser-legacy": "^1.0.1",
-    "@vaadin/vaadin-demo-helpers": "^2.2.0",
+    "@vaadin/vaadin-demo-helpers": "^3.0.0",
     "@vaadin/vaadin-button": "^2.1.0"
   }
 }

src/vaadin-email-field.js

@@ -34,3 +34,3 @@ /**
   static get version() {
-    return '2.4.4';
+    return '2.4.5';
   }
@@ -37,0 +37,0 @@

src/vaadin-number-field.js

@@ -80,3 +80,3 @@ /**
   static get version() {
-    return '2.4.4';
+    return '2.4.5';
   }
@@ -100,3 +100,3 @@
         type: Number,
-        reflectToAttribue: true
+        reflectToAttribute: true
       },
@@ -109,3 +109,3 @@
         type: Number,
-        reflectToAttribue: true,
+        reflectToAttribute: true,
         observer: '_maxChanged'
@@ -119,3 +119,3 @@ },
         type: Number,
-        reflectToAttribue: true,
+        reflectToAttribute: true,
         value: 1
@@ -122,0 +122,0 @@ }

src/vaadin-password-field.js

@@ -80,3 +80,3 @@ /**
   static get version() {
-    return '2.4.4';
+    return '2.4.5';
   }
@@ -83,0 +83,0 @@

src/vaadin-text-area.js

@@ -133,3 +133,3 @@ /**
   static get version() {
-    return '2.4.4';
+    return '2.4.5';
   }
@@ -191,11 +191,3 @@
 
-    if (this.__previousInputHeight && this.__previousInputHeight !== inputHeight) {
-      this.dispatchEvent(
-        new CustomEvent('iron-resize', {
-          bubbles: true
-        })
-      );
-    }
-
-    this.__previousInputHeight = inputHeight;
+    this._dispatchIronResizeEventIfNeeded('InputHeight', inputHeight);
   }
@@ -202,0 +194,0 @@

src/vaadin-text-field-mixin.js

@@ -317,3 +317,5 @@ /**
       '_getActiveErrorId(invalid, errorMessage, _errorId)',
-      '_getActiveLabelId(label, _labelId)'];
+      '_getActiveLabelId(label, _labelId)',
+      '__observeOffsetHeight(errorMessage, invalid, label)'
+    ];
   }
@@ -560,2 +562,9 @@
     this._labelId = `${this.constructor.is}-label-${uniqueId}`;
+
+    // Lumo theme defines a max-height transition for the "error-message"
+    // part on invalid state change.
+    this.shadowRoot.querySelector('[part="error-message"]')
+      .addEventListener('transitionend', () => {
+        this.__observeOffsetHeight();
+      });
   }
@@ -612,3 +621,5 @@
     if (e.keyCode === 27 && this.clearButtonVisible) {
+      const dispatchChange = !!this.value;
       this.clear();
+      dispatchChange && this.inputElement.dispatchEvent(new Event('change', {bubbles: !this._slottedInput}));
     }
@@ -660,2 +671,18 @@ }
 
+  _dispatchIronResizeEventIfNeeded(sizePropertyName, value) {
+    const previousSizePropertyName = '__previous' + sizePropertyName;
+    if (this[previousSizePropertyName] !== undefined
+        && this[previousSizePropertyName] !== value) {
+      this.dispatchEvent(
+        new CustomEvent('iron-resize', {bubbles: true})
+      );
+    }
+
+    this[previousSizePropertyName] = value;
+  }
+
+  __observeOffsetHeight() {
+    this._dispatchIronResizeEventIfNeeded('Height', this.offsetHeight);
+  }
+
   /**
@@ -698,2 +725,8 @@ * @protected
    */
+
+  /**
+   * Fired when the size of the element changes.
+   *
+   * @event iron-resize
+   */
 };

src/vaadin-text-field.js

@@ -106,3 +106,3 @@ /**
   static get version() {
-    return '2.4.4';
+    return '2.4.5';
   }
@@ -109,0 +109,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

95561

increased by0.95%

Lines of code

2170

increased by0.98%

No dependency changes