@verdaccio/local-storage - npm Package Compare versions

Comparing version 11.0.0-6-next.10 to 11.0.0-6-next.11

build/dir-utils.js

@@ -9,7 +9,7 @@ "use strict";
 
-var _path = require("path");
+var _debug = _interopRequireDefault(require("debug"));
 
 var _globby = _interopRequireDefault(require("globby"));
 
-var _debug = _interopRequireDefault(require("debug"));
+var _path = require("path");
 
@@ -16,0 +16,0 @@ var _core = require("@verdaccio/core");

build/fs.js

@@ -8,6 +8,6 @@ "use strict";
 
+var _fs = _interopRequireDefault(require("fs"));
+
 var _util = require("util");
 
-var _fs = _interopRequireDefault(require("fs"));
-
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
@@ -14,0 +14,0 @@

build/local-database.d.ts

@@ -0,3 +1,3 @@
+import { pluginUtils, searchUtils } from '@verdaccio/core';
 import { Config, IPackageStorage, LocalStorage, Logger } from '@verdaccio/types';
-import { searchUtils, pluginUtils } from '@verdaccio/core';
 import TokenActions from './token';
@@ -4,0 +4,0 @@ export declare const ERROR_DB_LOCKED = "Database is locked, please check error message printed during startup to prevent data loss";

build/local-database.js

 "use strict";
 
-require("core-js/modules/esnext.weak-map.delete-all.js");
-
 Object.defineProperty(exports, "__esModule", {
@@ -10,34 +8,8 @@ value: true
 
-require("core-js/modules/esnext.map.delete-all.js");
+var _debug = _interopRequireDefault(require("debug"));
 
-require("core-js/modules/esnext.map.every.js");
+var _lodash = _interopRequireDefault(require("lodash"));
 
-require("core-js/modules/esnext.map.filter.js");
-
-require("core-js/modules/esnext.map.find.js");
-
-require("core-js/modules/esnext.map.find-key.js");
-
-require("core-js/modules/esnext.map.includes.js");
-
-require("core-js/modules/esnext.map.key-of.js");
-
-require("core-js/modules/esnext.map.map-keys.js");
-
-require("core-js/modules/esnext.map.map-values.js");
-
-require("core-js/modules/esnext.map.merge.js");
-
-require("core-js/modules/esnext.map.reduce.js");
-
-require("core-js/modules/esnext.map.some.js");
-
-require("core-js/modules/esnext.map.update.js");
-
 var _path = _interopRequireDefault(require("path"));
 
-var _debug = _interopRequireDefault(require("debug"));
-
-var _lodash = _interopRequireDefault(require("lodash"));
-
 var _core = require("@verdaccio/core");
@@ -47,2 +19,6 @@
 
+var _dirUtils = require("./dir-utils");
+
+var _fs = require("./fs");
+
 var _localFs = _interopRequireWildcard(require("./local-fs"));
@@ -54,10 +30,4 @@
 
-var _fs = require("./fs");
-
-var _dirUtils = require("./dir-utils");
-
 var _utils2 = require("./utils");
 
-var _process$env$VERDACCI;
-
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function (nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
@@ -69,5 +39,4 @@
 
-function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
-
-const DB_NAME = (_process$env$VERDACCI = process.env.VERDACCIO_STORAGE_NAME) !== null && _process$env$VERDACCI !== void 0 ? _process$env$VERDACCI : _core.fileUtils.Files.DatabaseName;
+// import LRU from 'lru-cache';
+const DB_NAME = process.env.VERDACCIO_STORAGE_NAME ?? _core.fileUtils.Files.DatabaseName;
 const debug = (0, _debug.default)('verdaccio:plugin:local-storage:experimental');
@@ -80,15 +49,2 @@ const ERROR_DB_LOCKED = 'Database is locked, please check error message printed during startup to prevent data loss';
     super(config);
-
-    _defineProperty(this, "path", void 0);
-
-    _defineProperty(this, "logger", void 0);
-
-    _defineProperty(this, "config", void 0);
-
-    _defineProperty(this, "storages", void 0);
-
-    _defineProperty(this, "data", void 0);
-
-    _defineProperty(this, "locked", void 0);
-
     this.config = config;
@@ -95,0 +51,0 @@ this.logger = logger;

build/local-fs.d.ts

@@ -0,4 +1,4 @@
+import { VerdaccioError } from '@verdaccio/core';
 import { ReadTarball } from '@verdaccio/streams';
-import { Callback, Logger, Package, ILocalPackageManager, IUploadTarball } from '@verdaccio/types';
-import { VerdaccioError } from '@verdaccio/core';
+import { Callback, ILocalPackageManager, IUploadTarball, Logger, Package } from '@verdaccio/types';
 export declare const fileExist = "EEXISTS";
@@ -36,2 +36,3 @@ export declare const noSuchFile = "ENOENT";
     savePackage(name: string, value: Package, cb: Callback): void;
+    readPackageNext(name: string): Promise<Package>;
     readPackage(name: string, cb: Callback): void;
@@ -38,0 +39,0 @@ writeTarball(name: string): IUploadTarball;

build/local-fs.js

@@ -8,16 +8,16 @@ "use strict";
 
+var _debug = _interopRequireDefault(require("debug"));
+
 var _fs = _interopRequireDefault(require("fs"));
 
+var _lodash = _interopRequireDefault(require("lodash"));
+
 var _path = _interopRequireDefault(require("path"));
 
-var _debug = _interopRequireDefault(require("debug"));
+var _core = require("@verdaccio/core");
 
-var _lodash = _interopRequireDefault(require("lodash"));
+var _fileLocking = require("@verdaccio/file-locking");
 
 var _streams = require("@verdaccio/streams");
 
-var _fileLocking = require("@verdaccio/file-locking");
-
-var _core = require("@verdaccio/core");
-
 var _fs2 = require("./fs");
@@ -27,4 +27,3 @@
 
-function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
-
+/* eslint-disable no-undef */
 const fileExist = 'EEXISTS';
@@ -83,6 +82,2 @@ exports.fileExist = fileExist;
   constructor(path, logger) {
-    _defineProperty(this, "path", void 0);
-
-    _defineProperty(this, "logger", void 0);
-
     this.path = path;
@@ -181,2 +176,20 @@ this.logger = logger;
 
+  async readPackageNext(name) {
+    debug('read a package %o', name);
+
+    try {
+      const res = await this._readStorageFile(this._getStorage(packageJSONFileName));
+      const data = JSON.parse(res.toString('utf8'));
+      debug('read storage file %o has succeed', name);
+      return data;
+    } catch (err) {
+      debug('parse error');
+      this.logger.error({
+        err,
+        name
+      }, 'error @{err.message}  on parse @{name}');
+      throw err;
+    }
+  }
+
   readPackage(name, cb) {
@@ -199,5 +212,3 @@ debug('read a package %o', name);
     }).catch(err => {
-      this.logger.error({
-        err
-      }, 'error on read storage file @{err.message}');
+      debug('error on read storage file %o', err.message);
       return cb(err);
@@ -204,0 +215,0 @@ });

build/token.d.ts

 import low from 'lowdb';
-import { ITokenActions, Config, Token, TokenFilter } from '@verdaccio/types';
+import { Config, ITokenActions, Token, TokenFilter } from '@verdaccio/types';
 export default class TokenActions implements ITokenActions {
@@ -4,0 +4,0 @@ config: Config;

build/token.js

@@ -8,2 +8,4 @@ "use strict";
 
+var _debug = _interopRequireDefault(require("debug"));
+
 var _lodash = _interopRequireDefault(require("lodash"));
@@ -17,4 +19,2 @@
 
-var _debug = _interopRequireDefault(require("debug"));
-
 var _utils = require("./utils");
@@ -24,4 +24,2 @@
 
-function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
-
 const debug = (0, _debug.default)('verdaccio:plugin:local-storage:token');
@@ -32,6 +30,2 @@ const TOKEN_DB_NAME = '.token-db.json';
   constructor(config) {
-    _defineProperty(this, "config", void 0);
-
-    _defineProperty(this, "tokenDb", void 0);
-
     this.config = config;
@@ -38,0 +32,0 @@ this.tokenDb = null;

build/utils.js

@@ -13,6 +13,6 @@ "use strict";
 
+var _lodash = _interopRequireDefault(require("lodash"));
+
 var _path = _interopRequireDefault(require("path"));
 
-var _lodash = _interopRequireDefault(require("lodash"));
-
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
@@ -19,0 +19,0 @@

CHANGELOG.md

 # Change Log
 
+## 11.0.0-6-next.11
+
+### Major Changes
+
+- a828271d: refactor: download manifest endpoint and integrate fastify
+
+  Much simpler API for fetching a package
+
+  ```
+   const manifest = await storage.getPackageNext({
+        name,
+        uplinksLook: true,
+        req,
+        version: queryVersion,
+        requestOptions,
+   });
+  ```
+
+  > not perfect, the `req` still is being passed to the proxy (this has to be refactored at proxy package) and then removed from here, in proxy we pass the request instance to the `request` library.
+
+  ### Details
+
+  - `async/await` sugar for getPackage()
+  - Improve and reuse code between current implementation and new fastify endpoint (add scaffolding for request manifest)
+  - Improve performance
+  - Add new tests
+
+  ### Breaking changes
+
+  All storage plugins will stop to work since the storage uses `getPackageNext` method which is Promise based, I won't replace this now because will force me to update all plugins, I'll follow up in another PR. Currently will throw http 500
+
+### Patch Changes
+
+- Updated dependencies [24b9be02]
+  - @verdaccio/core@6.0.0-6-next.4
+  - @verdaccio/file-locking@11.0.0-6-next.4
+  - @verdaccio/streams@11.0.0-6-next.5
+
 ## 11.0.0-6-next.10
@@ -4,0 +42,0 @@

package.json

 {
 	"name": "@verdaccio/local-storage",
-	"version": "11.0.0-6-next.10",
+	"version": "11.0.0-6-next.11",
 	"description": "Local storage implementation",
@@ -40,3 +40,3 @@ "keywords": [
 	"dependencies": {
-		"@verdaccio/core": "6.0.0-6-next.3",
+		"@verdaccio/core": "6.0.0-6-next.4",
 		"@verdaccio/file-locking": "11.0.0-6-next.4",
@@ -46,5 +46,6 @@ "@verdaccio/streams": "11.0.0-6-next.5",
 		"core-js": "3.17.2",
-		"debug": "4.3.2",
+		"debug": "4.3.3",
 		"globby": "11.0.4",
 		"lockfile": "1.0.4",
+		"sanitize-filename": "1.6.3",
 		"lodash": "4.17.21",
@@ -56,7 +57,7 @@ "lowdb": "1.0.0",
 		"@types/minimatch": "3.0.5",
-		"@verdaccio/types": "11.0.0-6-next.9",
-		"@verdaccio/config": "6.0.0-6-next.10",
-		"@verdaccio/utils": "6.0.0-6-next.8",
+		"@verdaccio/types": "11.0.0-6-next.10",
+		"@verdaccio/config": "6.0.0-6-next.12",
+		"@verdaccio/utils": "6.0.0-6-next.10",
 		"minimatch": "3.0.4",
-		"tmp-promise": "3.0.2"
+		"tmp-promise": "3.0.3"
 	},
@@ -63,0 +64,0 @@ "funding": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

129258

increased by0.61%

Worsened metrics

Dependency count

12

increased by9.09%

Lines of code

1086

decreased by-1%

Dependency changes

• + Addedsanitize-filename@1.6.3

• + Added@verdaccio/core@6.0.0-6-next.4(transitive)

• + Addeddebug@4.3.3(transitive)

• + Addedhttp-errors@1.8.1(transitive)

• + Addedsanitize-filename@1.6.3(transitive)

• + Addedtoidentifier@1.0.1(transitive)

• + Addedtruncate-utf8-bytes@1.0.2(transitive)

• + Addedutf8-byte-length@1.0.5(transitive)

• - Removed@verdaccio/core@6.0.0-6-next.3(transitive)

• - Removeddebug@4.3.2(transitive)

• - Removedhttp-errors@1.8.0(transitive)

• - Removedtoidentifier@1.0.0(transitive)

• Updated@verdaccio/core@6.0.0-6-next.4

• Updateddebug@4.3.3