@vssue/api-github-v3 - npm Package Compare versions

Comparing version 1.4.0 to 1.4.3

lib/index.d.ts

@@ -155,6 +155,7 @@ import { VssueAPI } from 'vssue';
      */
-    deleteCommentReaction({ accessToken, reactionId, }: {
+    deleteCommentReaction({ accessToken, commentId, reactionId, }: {
         accessToken: VssueAPI.AccessToken;
+        commentId: string | number;
         reactionId: string | number;
     }): Promise<boolean>;
 }

lib/index.js

@@ -37,2 +37,14 @@ import axios from 'axios';
             return response;
+        }, error => {
+            // 403 rate limit exceeded in OPTIONS request will cause a Network Error
+            // here we always treat Network Error as 403 rate limit exceeded
+            // @see https://github.com/axios/axios/issues/838
+            /* istanbul ignore next */
+            if (typeof error.response === 'undefined' &&
+                error.message === 'Network Error') {
+                error.response = {
+                    status: 403,
+                };
+            }
+            return Promise.reject(error);
         });
@@ -349,2 +361,3 @@ }
                 accessToken,
+                commentId,
                 reactionId: response.data.id,
@@ -361,4 +374,4 @@ });
      */
-    async deleteCommentReaction({ accessToken, reactionId, }) {
-        const response = await this.$http.delete(`reactions/${reactionId}`, {
+    async deleteCommentReaction({ accessToken, commentId, reactionId, }) {
+        const response = await this.$http.delete(`repos/${this.owner}/${this.repo}/issues/comments/${commentId}/reactions/${reactionId}`, {
             headers: {
@@ -365,0 +378,0 @@ Authorization: `token ${accessToken}`,

package.json

 {
   "name": "@vssue/api-github-v3",
-  "version": "1.4.0",
+  "version": "1.4.3",
   "description": "Vssue api for github v3",
@@ -38,3 +38,3 @@ "keywords": [
   },
-  "gitHead": "c31210f04dcb4f114488e45d5835c89196492026"
+  "gitHead": "33acae3beb997b69afb778a01f6e2f05345db330"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

35370

increased by2.99%

Lines of code

640

increased by2.24%

No dependency changes