@webcomponents/webcomponentsjs - npm Package Compare versions

Comparing version 2.2.4 to 2.2.5

package.json

 {
   "name": "@webcomponents/webcomponentsjs",
-  "version": "2.2.4",
+  "version": "2.2.5",
   "description": "Web Components Polyfills",
@@ -35,6 +35,6 @@ "main": "webcomponents-bundle.js",
     "@webcomponents/custom-elements": "^1.2.1",
-    "@webcomponents/shadycss": "^1.8.0",
+    "@webcomponents/shadycss": "^1.9.0",
     "@webcomponents/shadydom": "^1.4.2",
     "@webcomponents/template": "^1.4.0",
-    "@webcomponents/url": "^0.7.2",
+    "@webcomponents/url": "^0.7.3",
     "@webcomponents/webcomponents-platform": "^1.0.0",
@@ -44,3 +44,3 @@ "babel-core": "^6.26.3",
     "del": "^3.0.0",
-    "eslint": "^5.9.0",
+    "eslint": "^5.12.1",
     "eslint-plugin-html": "^4.0.6",
@@ -61,3 +61,3 @@ "get-own-property-symbols": "^0.9.2",
     "wct-browser-legacy": "^1.0.2",
-    "web-component-tester": "^6.9.0"
+    "web-component-tester": "^6.9.2"
   },
@@ -64,0 +64,0 @@ "publishConfig": {

webcomponents-loader.js

@@ -21,4 +21,3 @@ /**
    *   - wait for `DOMContentLoaded`
-   *   - run callbacks passed to `waitFor`
-   *   - fire WCR event
+   *   - fire WCR event, as there could not be any callbacks passed to `waitFor`
    *
@@ -33,3 +32,5 @@ * - Synchronous script, polyfills needed
    * - Asynchronous script, no polyfills needed
-   *   - fire WCR event, as there could not be any callbacks passed to `waitFor`
+   *   - wait for `DOMContentLoaded`
+   *   - run callbacks passed to `waitFor`
+   *   - fire WCR event
    *
@@ -81,11 +82,9 @@ * - Asynchronous script, polyfills needed
     allowUpgrades = false;
-    var done = function() {
+    var fnsMap = whenLoadedFns.map(function(fn) {
+      return fn instanceof Function ? fn() : fn;
+    });
+    whenLoadedFns = [];
+    return Promise.all(fnsMap).then(function() {
       allowUpgrades = true;
-      whenLoadedFns.length = 0;
       flushFn && flushFn();
-    };
-    return Promise.all(whenLoadedFns.map(function(fn) {
-      return fn instanceof Function ? fn() : fn;
-    })).then(function() {
-      done();
     }).catch(function(err) {
@@ -176,5 +175,6 @@ console.error(err);
   } else {
-    polyfillsLoaded = true;
+    // if readyState is 'complete', script is loaded imperatively on a spec-compliant browser, so just fire WCR
     if (document.readyState === 'complete') {
-      fireEvent()
+      polyfillsLoaded = true;
+      fireEvent();
     } else {
@@ -181,0 +181,0 @@ // this script may come between DCL and load, so listen for both, and cancel load listener if DCL fires

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2748521

increased by0.28%

Lines of code

2211

increased by0.27%

No dependency changes