@webex/internal-plugin-metrics - npm Package Compare versions

Comparing version 3.3.1-next.5 to 3.3.1-next.6

dist/call-diagnostic/call-diagnostic-metrics.util.js

@@ -336,3 +336,4 @@ "use strict";
     iceConnected = _ref2.iceConnected,
-    turnServerUsed = _ref2.turnServerUsed;
+    turnServerUsed = _ref2.turnServerUsed,
+    unreachable = _ref2.unreachable;
   var errorCode = _config.ICE_FAILURE_CLIENT_CODE; // default;
@@ -348,3 +349,7 @@
     if (turnServerUsed) {
-      errorCode = _config.ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE;
+      if (unreachable) {
+        errorCode = _config.ICE_AND_REACHABILITY_FAILED_CLIENT_CODE;
+      } else {
+        errorCode = _config.ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE;
+      }
     } else {
@@ -351,0 +356,0 @@ errorCode = _config.ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE;

dist/call-diagnostic/config.js

@@ -8,3 +8,3 @@ "use strict";
 });
-exports.WEBEX_SUB_SERVICE_TYPES = exports.WBX_APP_API_URL = exports.UNKNOWN_ERROR = exports.SERVICE_ERROR_CODES_TO_CLIENT_ERROR_CODES_MAP = exports.SDP_OFFER_CREATION_ERROR_MAP = exports.NEW_LOCUS_ERROR_CLIENT_CODE = exports.NETWORK_ERROR = exports.MISSING_ROAP_ANSWER_CLIENT_CODE = exports.MEETING_INFO_LOOKUP_ERROR_CLIENT_CODE = exports.ICE_FAILURE_CLIENT_CODE = exports.ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE = exports.ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE = exports.ERROR_DESCRIPTIONS = exports.DTLS_HANDSHAKE_FAILED_CLIENT_CODE = exports.CLIENT_ERROR_CODE_TO_ERROR_PAYLOAD = exports.CALL_DIAGNOSTIC_LOG_IDENTIFIER = exports.CALL_DIAGNOSTIC_EVENT_FAILED_TO_SEND = exports.BROWSER_MEDIA_ERROR_NAME_TO_CLIENT_ERROR_CODES_MAP = exports.AUTHENTICATION_FAILED_CODE = void 0;
+exports.WEBEX_SUB_SERVICE_TYPES = exports.WBX_APP_API_URL = exports.UNKNOWN_ERROR = exports.SERVICE_ERROR_CODES_TO_CLIENT_ERROR_CODES_MAP = exports.SDP_OFFER_CREATION_ERROR_MAP = exports.NEW_LOCUS_ERROR_CLIENT_CODE = exports.NETWORK_ERROR = exports.MISSING_ROAP_ANSWER_CLIENT_CODE = exports.MEETING_INFO_LOOKUP_ERROR_CLIENT_CODE = exports.ICE_FAILURE_CLIENT_CODE = exports.ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE = exports.ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE = exports.ICE_AND_REACHABILITY_FAILED_CLIENT_CODE = exports.ERROR_DESCRIPTIONS = exports.DTLS_HANDSHAKE_FAILED_CLIENT_CODE = exports.CLIENT_ERROR_CODE_TO_ERROR_PAYLOAD = exports.CALL_DIAGNOSTIC_LOG_IDENTIFIER = exports.CALL_DIAGNOSTIC_EVENT_FAILED_TO_SEND = exports.BROWSER_MEDIA_ERROR_NAME_TO_CLIENT_ERROR_CODES_MAP = exports.AUTHENTICATION_FAILED_CODE = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime-corejs2/helpers/defineProperty"));
@@ -27,2 +27,3 @@ var _CLIENT_ERROR_CODE_TO;
 var ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE = exports.ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE = 2009;
+var ICE_AND_REACHABILITY_FAILED_CLIENT_CODE = exports.ICE_AND_REACHABILITY_FAILED_CLIENT_CODE = 2011;
 var WBX_APP_API_URL = exports.WBX_APP_API_URL = 'wbxappapi'; // MeetingInfo WebexAppApi response object normally contains a body.url that includes the string 'wbxappapi'
@@ -125,2 +126,3 @@
   ICE_FAILED_WITH_TURN_TLS: 'ICEFailedWithTURN_TLS',
+  ICE_AND_REACHABILITY_FAILED: 'ICEAndReachabilityFailed',
   SDP_OFFER_CREATION_ERROR: 'SdpOfferCreationError',
@@ -379,2 +381,6 @@ SDP_OFFER_CREATION_ERROR_MISSING_CODEC: 'SdpOfferCreationErrorMissingCodec'
   errorDescription: ERROR_DESCRIPTIONS.ICE_FAILED_WITH_TURN_TLS,
+  category: 'media',
+  fatal: true
+}), ICE_AND_REACHABILITY_FAILED_CLIENT_CODE, {
+  errorDescription: ERROR_DESCRIPTIONS.ICE_AND_REACHABILITY_FAILED,
   category: 'network',
@@ -412,7 +418,7 @@ fatal: true
   fatal: true
-}), 3007, {
+}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 3007, {
   errorDescription: ERROR_DESCRIPTIONS.STREAM_ERROR_NO_MEDIA,
   category: 'expected',
   fatal: true
-}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 3013, {
+}), 3013, {
   errorDescription: ERROR_DESCRIPTIONS.ROOM_TOO_LARGE_FREE_ACCOUNT,
@@ -455,7 +461,7 @@ category: 'expected',
   fatal: true
-}), 4009, {
+}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 4009, {
   errorDescription: ERROR_DESCRIPTIONS.NETWORK_UNAVAILABLE,
   category: 'network',
   fatal: true
-}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 4010, {
+}), 4010, {
   errorDescription: ERROR_DESCRIPTIONS.MEETING_UNAVAILABLE,
@@ -499,7 +505,7 @@ category: 'expected',
   name: 'locus.response'
-}), 4019, {
+}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 4019, {
   errorDescription: ERROR_DESCRIPTIONS.ONE_ON_ONE_TO_SELF_NOT_ALLOWED,
   category: 'expected',
   fatal: true
-}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 4020, {
+}), 4020, {
   errorDescription: ERROR_DESCRIPTIONS.REMOVED_PARTICIPANT,
@@ -540,7 +546,7 @@ category: 'expected',
   fatal: true
-}), 4029, {
+}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 4029, {
   errorDescription: ERROR_DESCRIPTIONS.START_RECORDING_FAILED,
   category: 'expected',
   fatal: true
-}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 4030, {
+}), 4030, {
   errorDescription: ERROR_DESCRIPTIONS.RECORDING_IN_PROGRESS_FAILED,
@@ -581,7 +587,7 @@ category: 'expected',
   fatal: true
-}), 4103, {
+}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 4103, {
   errorDescription: ERROR_DESCRIPTIONS.SIGN_UP_INVALID_EMAIL,
   category: 'expected',
   fatal: true
-}), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)(_CLIENT_ERROR_CODE_TO, 2729, {
+}), 2729, {
   errorDescription: ERROR_DESCRIPTIONS.NO_MEDIA_FOUND,
@@ -588,0 +594,0 @@ category: 'expected',

dist/metrics.js

@@ -151,5 +151,5 @@ "use strict";
   },
-  version: "3.3.1-next.5"
+  version: "3.3.1-next.6"
 });
 var _default = exports.default = Metrics;
 //# sourceMappingURL=metrics.js.map

dist/types/call-diagnostic/call-diagnostic-metrics.util.d.ts

@@ -99,6 +99,7 @@ import { Event } from '../metrics.types';
  */
-export declare const generateClientErrorCodeForIceFailure: ({ signalingState, iceConnected, turnServerUsed, }: {
+export declare const generateClientErrorCodeForIceFailure: ({ signalingState, iceConnected, turnServerUsed, unreachable, }: {
     signalingState: RTCPeerConnection['signalingState'];
     iceConnected: boolean;
     turnServerUsed: boolean;
+    unreachable: boolean;
 }) => number;

dist/types/call-diagnostic/config.d.ts

@@ -13,2 +13,3 @@ import { ClientEventError, ClientSubServiceType } from '../metrics.types';
 export declare const ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE = 2009;
+export declare const ICE_AND_REACHABILITY_FAILED_CLIENT_CODE = 2011;
 export declare const WBX_APP_API_URL = "wbxappapi";
@@ -96,2 +97,3 @@ export declare const WEBEX_SUB_SERVICE_TYPES: Record<string, ClientSubServiceType>;
     ICE_FAILED_WITH_TURN_TLS: string;
+    ICE_AND_REACHABILITY_FAILED: string;
     SDP_OFFER_CREATION_ERROR: string;
@@ -98,0 +100,0 @@ SDP_OFFER_CREATION_ERROR_MISSING_CODEC: string;

package.json

@@ -29,6 +29,6 @@ {
     "@webex/legacy-tools": "0.0.0",
-    "@webex/test-helper-chai": "3.3.1-next.5",
-    "@webex/test-helper-mocha": "3.3.1-next.5",
-    "@webex/test-helper-mock-webex": "3.3.1-next.5",
-    "@webex/test-helper-test-users": "3.3.1-next.5",
+    "@webex/test-helper-chai": "3.3.1-next.6",
+    "@webex/test-helper-mocha": "3.3.1-next.6",
+    "@webex/test-helper-mock-webex": "3.3.1-next.6",
+    "@webex/test-helper-test-users": "3.3.1-next.6",
     "eslint": "^8.24.0",
@@ -39,9 +39,9 @@ "prettier": "^2.7.1",
   "dependencies": {
-    "@webex/common": "3.3.1-next.5",
-    "@webex/common-timers": "3.3.1-next.5",
+    "@webex/common": "3.3.1-next.6",
+    "@webex/common-timers": "3.3.1-next.6",
     "@webex/event-dictionary-ts": "^1.0.1406",
-    "@webex/internal-plugin-metrics": "3.3.1-next.5",
-    "@webex/test-helper-chai": "3.3.1-next.5",
-    "@webex/test-helper-mock-webex": "3.3.1-next.5",
-    "@webex/webex-core": "3.3.1-next.5",
+    "@webex/internal-plugin-metrics": "3.3.1-next.6",
+    "@webex/test-helper-chai": "3.3.1-next.6",
+    "@webex/test-helper-mock-webex": "3.3.1-next.6",
+    "@webex/webex-core": "3.3.1-next.6",
     "ip-anonymize": "^0.1.0",
@@ -59,3 +59,3 @@ "lodash": "^4.17.21",
   },
-  "version": "3.3.1-next.5"
+  "version": "3.3.1-next.6"
 }

src/call-diagnostic/call-diagnostic-metrics.util.ts

@@ -24,2 +24,3 @@ /* eslint-disable valid-jsdoc */
   ERROR_DESCRIPTIONS,
+  ICE_AND_REACHABILITY_FAILED_CLIENT_CODE,
 } from './config';
@@ -375,2 +376,3 @@
   turnServerUsed,
+  unreachable,
 }: {
@@ -380,2 +382,3 @@ signalingState: RTCPeerConnection['signalingState'];
   turnServerUsed: boolean;
+  unreachable: boolean;
 }) => {
@@ -394,3 +397,7 @@ let errorCode = ICE_FAILURE_CLIENT_CODE; // default;
     if (turnServerUsed) {
-      errorCode = ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE;
+      if (unreachable) {
+        errorCode = ICE_AND_REACHABILITY_FAILED_CLIENT_CODE;
+      } else {
+        errorCode = ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE;
+      }
     } else {
@@ -397,0 +404,0 @@ errorCode = ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE;

src/call-diagnostic/config.ts

@@ -19,2 +19,3 @@ /* eslint-disable import/prefer-default-export */
 export const ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE = 2009;
+export const ICE_AND_REACHABILITY_FAILED_CLIENT_CODE = 2011;
 export const WBX_APP_API_URL = 'wbxappapi'; // MeetingInfo WebexAppApi response object normally contains a body.url that includes the string 'wbxappapi'
@@ -129,2 +130,3 @@
   ICE_FAILED_WITH_TURN_TLS: 'ICEFailedWithTURN_TLS',
+  ICE_AND_REACHABILITY_FAILED: 'ICEAndReachabilityFailed',
   SDP_OFFER_CREATION_ERROR: 'SdpOfferCreationError',
@@ -397,2 +399,7 @@ SDP_OFFER_CREATION_ERROR_MISSING_CODEC: 'SdpOfferCreationErrorMissingCodec',
     errorDescription: ERROR_DESCRIPTIONS.ICE_FAILED_WITH_TURN_TLS,
+    category: 'media',
+    fatal: true,
+  },
+  [ICE_AND_REACHABILITY_FAILED_CLIENT_CODE]: {
+    errorDescription: ERROR_DESCRIPTIONS.ICE_AND_REACHABILITY_FAILED,
     category: 'network',
@@ -399,0 +406,0 @@ fatal: true,

test/unit/spec/call-diagnostic/call-diagnostic-metrics.util.ts

@@ -10,2 +10,3 @@ import {assert} from '@webex/test-helper-chai';
   ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE,
+  ICE_AND_REACHABILITY_FAILED_CLIENT_CODE,
   ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE,
@@ -620,2 +621,3 @@ MISSING_ROAP_ANSWER_CLIENT_CODE,
         errorCode: MISSING_ROAP_ANSWER_CLIENT_CODE,
+        unreachable: false,
       },
@@ -627,2 +629,3 @@ {
         errorCode: DTLS_HANDSHAKE_FAILED_CLIENT_CODE,
+        unreachable: false,
       },
@@ -634,2 +637,3 @@ {
         errorCode: ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE,
+        unreachable: false,
       },
@@ -639,6 +643,14 @@ {
         iceConnected: false,
+        turnServerUsed: true,
+        errorCode: ICE_AND_REACHABILITY_FAILED_CLIENT_CODE,
+        unreachable: true,
+      },
+      {
+        signalingState: 'stable',
+        iceConnected: false,
         turnServerUsed: false,
         errorCode: ICE_FAILED_WITHOUT_TURN_TLS_CLIENT_CODE,
+        unreachable: false,
       },
-    ].forEach(({signalingState, iceConnected, turnServerUsed, errorCode}: any) => {
+    ].forEach(({signalingState, iceConnected, turnServerUsed, errorCode, unreachable}: any) => {
       it('returns expected result', () => {
@@ -650,2 +662,3 @@ assert.deepEqual(
             turnServerUsed,
+            unreachable,
           }),
@@ -652,0 +665,0 @@ errorCode

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

683247

increased by0.37%

Lines of code

12694

increased by0.33%

Dependency changes

• + Added@webex/common@3.3.1-next.6(transitive)

• + Added@webex/common-timers@3.3.1-next.6(transitive)

• + Added@webex/http-core@3.3.1-next.6(transitive)

• + Added@webex/internal-plugin-device@3.3.1-next.6(transitive)

• + Added@webex/plugin-logger@3.3.1-next.6(transitive)

• + Added@webex/storage-adapter-spec@3.3.1-next.6(transitive)

• + Added@webex/test-helper-chai@3.3.1-next.6(transitive)

• + Added@webex/test-helper-file@3.3.1-next.6(transitive)

• + Added@webex/test-helper-make-local-url@3.3.1-next.6(transitive)

• + Added@webex/test-helper-mocha@3.3.1-next.6(transitive)

• + Added@webex/test-helper-mock-webex@3.3.1-next.6(transitive)

• + Added@webex/test-helper-retry@3.3.1-next.6(transitive)

• + Added@webex/test-helper-test-users@3.3.1-next.6(transitive)

• + Added@webex/test-users@3.3.1-next.6(transitive)

• + Added@webex/webex-core@3.3.1-next.6(transitive)

• - Removed@webex/common@3.3.1-next.5(transitive)

• - Removed@webex/common-timers@3.3.1-next.5(transitive)

• - Removed@webex/http-core@3.3.1-next.5(transitive)

• - Removed@webex/internal-plugin-device@3.3.1-next.5(transitive)

• - Removed@webex/plugin-logger@3.3.1-next.5(transitive)

• - Removed@webex/storage-adapter-spec@3.3.1-next.5(transitive)

• - Removed@webex/test-helper-chai@3.3.1-next.5(transitive)

• - Removed@webex/test-helper-file@3.3.1-next.5(transitive)

• - Removed@webex/test-helper-make-local-url@3.3.1-next.5(transitive)

• - Removed@webex/test-helper-mocha@3.3.1-next.5(transitive)

• - Removed@webex/test-helper-mock-webex@3.3.1-next.5(transitive)

• - Removed@webex/test-helper-retry@3.3.1-next.5(transitive)

• - Removed@webex/test-helper-test-users@3.3.1-next.5(transitive)

• - Removed@webex/test-users@3.3.1-next.5(transitive)

• - Removed@webex/webex-core@3.3.1-next.5(transitive)

• Updated@webex/common@3.3.1-next.6

• Updated@webex/common-timers@3.3.1-next.6

• Updated@webex/internal-plugin-metrics@3.3.1-next.6

• Updated@webex/test-helper-chai@3.3.1-next.6

• Updated@webex/test-helper-mock-webex@3.3.1-next.6

• Updated@webex/webex-core@3.3.1-next.6