@webex/webex-core - npm Package Compare versions

Comparing version 3.0.0-beta.393 to 3.0.0-beta.394

dist/lib/batcher.js

@@ -285,3 +285,3 @@ "use strict";
   },
-  version: "3.0.0-beta.393"
+  version: "3.0.0-beta.394"
 });
@@ -288,0 +288,0 @@ var _default2 = Batcher;

dist/lib/credentials/credentials.js

@@ -561,3 +561,3 @@ "use strict";
   },
-  version: "3.0.0-beta.393"
+  version: "3.0.0-beta.394"
 }, ((0, _applyDecoratedDescriptor2.default)(_obj, "getUserToken", [_dec, _dec2], (0, _getOwnPropertyDescriptor.default)(_obj, "getUserToken"), _obj), (0, _applyDecoratedDescriptor2.default)(_obj, "initialize", [_dec3], (0, _getOwnPropertyDescriptor.default)(_obj, "initialize"), _obj), (0, _applyDecoratedDescriptor2.default)(_obj, "invalidate", [_common.oneFlight, _dec4], (0, _getOwnPropertyDescriptor.default)(_obj, "invalidate"), _obj), (0, _applyDecoratedDescriptor2.default)(_obj, "refresh", [_common.oneFlight, _dec5, _dec6], (0, _getOwnPropertyDescriptor.default)(_obj, "refresh"), _obj)), _obj)));
@@ -564,0 +564,0 @@ var _default = Credentials;

dist/lib/credentials/token.js

@@ -533,3 +533,3 @@ "use strict";
   },
-  version: "3.0.0-beta.393"
+  version: "3.0.0-beta.394"
 }, ((0, _applyDecoratedDescriptor2.default)(_obj, "downscope", [_dec], (0, _getOwnPropertyDescriptor.default)(_obj, "downscope"), _obj), (0, _applyDecoratedDescriptor2.default)(_obj, "refresh", [_common.oneFlight], (0, _getOwnPropertyDescriptor.default)(_obj, "refresh"), _obj), (0, _applyDecoratedDescriptor2.default)(_obj, "revoke", [_common.oneFlight], (0, _getOwnPropertyDescriptor.default)(_obj, "revoke"), _obj)), _obj)));
@@ -536,0 +536,0 @@ var _default = Token;

dist/lib/services/services.js

@@ -847,3 +847,5 @@ "use strict";
     }
-    return this.request(requestObject).then(function (_ref10) {
+    return this.webex.internal.newMetrics.callDiagnosticLatencies.measureLatency(function () {
+      return _this7.request(requestObject);
+    }, 'internal.get.u2c.time').then(function (_ref10) {
       var body = _ref10.body;
@@ -984,3 +986,3 @@ return _this7._formatReceivedHostmap(body);
   },
-  version: "3.0.0-beta.393"
+  version: "3.0.0-beta.394"
 });
@@ -987,0 +989,0 @@ /* eslint-enable no-underscore-dangle */

dist/plugins/logger.js

@@ -60,3 +60,3 @@ "use strict";
   trace: wrapConsoleMethod('trace'),
-  version: "3.0.0-beta.393"
+  version: "3.0.0-beta.394"
 });
@@ -63,0 +63,0 @@ (0, _webexCore.registerPlugin)('logger', Logger);

dist/webex-core.js

@@ -102,3 +102,3 @@ "use strict";
 var WebexCore = _ampersandState.default.extend((_obj = {
-  version: "3.0.0-beta.393",
+  version: "3.0.0-beta.394",
   children: {
@@ -645,3 +645,3 @@ internal: _webexInternalCore.default
 }, ((0, _applyDecoratedDescriptor2.default)(_obj, "_uploadPhaseUpload", [_common.retry], (0, _getOwnPropertyDescriptor.default)(_obj, "_uploadPhaseUpload"), _obj)), _obj));
-WebexCore.version = "3.0.0-beta.393";
+WebexCore.version = "3.0.0-beta.394";
 (0, _webexInternalCorePluginMixin.default)(_webexInternalCore.default, _config.default, interceptors);
@@ -648,0 +648,0 @@ (0, _webexCorePluginMixin.default)(WebexCore, _config.default, interceptors);

package.json

 {
   "name": "@webex/webex-core",
-  "version": "3.0.0-beta.393",
+  "version": "3.0.0-beta.394",
   "description": "Plugin handling for Cisco Webex",
@@ -34,8 +34,8 @@ "license": "MIT",
     "@sinonjs/fake-timers": "^6.0.1",
-    "@webex/test-helper-chai": "3.0.0-beta.393",
-    "@webex/test-helper-make-local-url": "3.0.0-beta.393",
-    "@webex/test-helper-mocha": "3.0.0-beta.393",
-    "@webex/test-helper-mock-webex": "3.0.0-beta.393",
-    "@webex/test-helper-refresh-callback": "3.0.0-beta.393",
-    "@webex/test-helper-test-users": "3.0.0-beta.393",
+    "@webex/test-helper-chai": "3.0.0-beta.394",
+    "@webex/test-helper-make-local-url": "3.0.0-beta.394",
+    "@webex/test-helper-mocha": "3.0.0-beta.394",
+    "@webex/test-helper-mock-webex": "3.0.0-beta.394",
+    "@webex/test-helper-refresh-callback": "3.0.0-beta.394",
+    "@webex/test-helper-test-users": "3.0.0-beta.394",
     "chai": "^4.3.4",
@@ -46,9 +46,9 @@ "chai-as-promised": "^7.1.1",
   "dependencies": {
-    "@webex/common": "3.0.0-beta.393",
-    "@webex/common-timers": "3.0.0-beta.393",
-    "@webex/http-core": "3.0.0-beta.393",
-    "@webex/internal-plugin-device": "3.0.0-beta.393",
-    "@webex/plugin-logger": "3.0.0-beta.393",
-    "@webex/storage-adapter-spec": "3.0.0-beta.393",
-    "@webex/webex-core": "3.0.0-beta.393",
+    "@webex/common": "3.0.0-beta.394",
+    "@webex/common-timers": "3.0.0-beta.394",
+    "@webex/http-core": "3.0.0-beta.394",
+    "@webex/internal-plugin-device": "3.0.0-beta.394",
+    "@webex/plugin-logger": "3.0.0-beta.394",
+    "@webex/storage-adapter-spec": "3.0.0-beta.394",
+    "@webex/webex-core": "3.0.0-beta.394",
     "ampersand-collection": "^2.0.2",
@@ -55,0 +55,0 @@ "ampersand-events": "^2.0.2",

src/lib/services/services.js

@@ -866,3 +866,5 @@ import Url from 'url';
 
-    return this.request(requestObject).then(({body}) => this._formatReceivedHostmap(body));
+    return this.webex.internal.newMetrics.callDiagnosticLatencies
+      .measureLatency(() => this.request(requestObject), 'internal.get.u2c.time')
+      .then(({body}) => this._formatReceivedHostmap(body));
   },
@@ -869,0 +871,0 @@

test/unit/spec/services/services.js

@@ -9,2 +9,3 @@ /*!
 import {Services, ServiceRegistry, ServiceState} from '@webex/webex-core';
+import {NewMetrics} from '@webex/internal-plugin-metrics';
 
@@ -22,2 +23,3 @@ /* eslint-disable no-underscore-dangle */
           services: Services,
+          newMetrics: NewMetrics,
         },
@@ -135,2 +137,56 @@ });
 
+    describe('#_fetchNewServiceHostmap()', () => {
+
+      beforeEach(() => {
+        sinon.spy(webex.internal.newMetrics.callDiagnosticLatencies, 'measureLatency');
+      });
+
+      afterEach(() => {
+        sinon.restore();
+      });
+
+      it('checks service request resolves', async () => {
+        const mapResponse = 'map response';
+
+        sinon.stub(services, '_formatReceivedHostmap').resolves(mapResponse);
+        sinon.stub(services, 'request').resolves({});
+        
+        const mapResult = await services._fetchNewServiceHostmap({from: 'limited'});
+
+        assert.deepEqual(mapResult, mapResponse);
+
+        assert.calledOnceWithExactly(services.request, {
+          method: 'GET',
+          service: 'u2c',
+          resource: '/limited/catalog',
+          qs: {format: 'hostmap'}
+        }
+        );
+        assert.calledOnceWithExactly(webex.internal.newMetrics.callDiagnosticLatencies.measureLatency, sinon.match.func, 'internal.get.u2c.time');
+      });
+
+      it('checks service request rejects', async () => {
+        const error = new Error('some error');
+
+        sinon.spy(services, '_formatReceivedHostmap');
+        sinon.stub(services, 'request').rejects(error);
+        
+        const promise = services._fetchNewServiceHostmap({from: 'limited'});
+        const rejectedValue = await assert.isRejected(promise);
+
+        assert.deepEqual(rejectedValue, error);
+
+        assert.notCalled(services._formatReceivedHostmap);
+
+        assert.calledOnceWithExactly(services.request, {
+          method: 'GET',
+          service: 'u2c',
+          resource: '/limited/catalog',
+          qs: {format: 'hostmap'}
+        }
+        );
+        assert.calledOnceWithExactly(webex.internal.newMetrics.callDiagnosticLatencies.measureLatency, sinon.match.func, 'internal.get.u2c.time');
+      });
+    });
+
     describe('#_formatReceivedHostmap()', () => {
@@ -137,0 +193,0 @@ let serviceHostmap;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1278742

increased by0.19%

Lines of code

23600

increased by0.2%

Dependency changes

• + Added@webex/common@3.0.0-beta.394(transitive)

• + Added@webex/common-timers@3.0.0-beta.394(transitive)

• + Added@webex/http-core@3.0.0-beta.394(transitive)

• + Added@webex/internal-plugin-device@3.0.0-beta.394(transitive)

• + Added@webex/internal-plugin-metrics@3.0.0-beta.394(transitive)

• + Added@webex/plugin-logger@3.0.0-beta.394(transitive)

• + Added@webex/storage-adapter-spec@3.0.0-beta.394(transitive)

• + Added@webex/test-helper-chai@3.0.0-beta.394(transitive)

• + Added@webex/test-helper-file@3.0.0-beta.394(transitive)

• + Added@webex/test-helper-make-local-url@3.0.0-beta.394(transitive)

• + Added@webex/test-helper-mocha@3.0.0-beta.394(transitive)

• + Added@webex/test-helper-mock-webex@3.0.0-beta.394(transitive)

• + Added@webex/test-helper-retry@3.0.0-beta.394(transitive)

• + Added@webex/test-helper-test-users@3.0.0-beta.394(transitive)

• + Added@webex/test-users@3.0.0-beta.394(transitive)

• - Removed@webex/common@3.0.0-beta.393(transitive)

• - Removed@webex/common-timers@3.0.0-beta.393(transitive)

• - Removed@webex/http-core@3.0.0-beta.393(transitive)

• - Removed@webex/internal-plugin-device@3.0.0-beta.393(transitive)

• - Removed@webex/internal-plugin-metrics@3.0.0-beta.393(transitive)

• - Removed@webex/plugin-logger@3.0.0-beta.393(transitive)

• - Removed@webex/storage-adapter-spec@3.0.0-beta.393(transitive)

• - Removed@webex/test-helper-chai@3.0.0-beta.393(transitive)

• - Removed@webex/test-helper-file@3.0.0-beta.393(transitive)

• - Removed@webex/test-helper-make-local-url@3.0.0-beta.393(transitive)

• - Removed@webex/test-helper-mocha@3.0.0-beta.393(transitive)

• - Removed@webex/test-helper-mock-webex@3.0.0-beta.393(transitive)

• - Removed@webex/test-helper-retry@3.0.0-beta.393(transitive)

• - Removed@webex/test-helper-test-users@3.0.0-beta.393(transitive)

• - Removed@webex/test-users@3.0.0-beta.393(transitive)

• Updated@webex/common@3.0.0-beta.394

• Updated@webex/common-timers@3.0.0-beta.394

• Updated@webex/http-core@3.0.0-beta.394

• Updated@webex/internal-plugin-device@3.0.0-beta.394

• Updated@webex/plugin-logger@3.0.0-beta.394

• Updated@webex/storage-adapter-spec@3.0.0-beta.394

• Updated@webex/webex-core@3.0.0-beta.394