@wixc3/common - npm Package Compare versions

Comparing version 12.0.1 to 12.0.3

dist/cjs/iterables.js

@@ -292,17 +292,3 @@ "use strict";
 function join(iterable, separator) {
-    if (!iterable) {
-        return '';
-    }
-    let result = first(iterable) || '';
-    let prev = null;
-    for (const v of skip(iterable, 1)) {
-        if (prev) {
-            result = result + separator + prev;
-        }
-        prev = v;
-    }
-    if (prev) {
-        result = result + separator + prev;
-    }
-    return result;
+    return reduce(iterable, (acc, item) => (acc === null ? item : acc + separator + item), null) || '';
 }
@@ -309,0 +295,0 @@ exports.join = join;

dist/esm/iterables.js

@@ -267,17 +267,3 @@ import { isDefined } from './types';
 export function join(iterable, separator) {
-    if (!iterable) {
-        return '';
-    }
-    let result = first(iterable) || '';
-    let prev = null;
-    for (const v of skip(iterable, 1)) {
-        if (prev) {
-            result = result + separator + prev;
-        }
-        prev = v;
-    }
-    if (prev) {
-        result = result + separator + prev;
-    }
-    return result;
+    return reduce(iterable, (acc, item) => (acc === null ? item : acc + separator + item), null) || '';
 }
@@ -284,0 +270,0 @@ /**

package.json

 {
   "name": "@wixc3/common",
-  "version": "12.0.1",
+  "version": "12.0.3",
   "description": "Common utils, usable in all environments",
@@ -5,0 +5,0 @@ "main": "dist/cjs/index.js",

src/iterables.ts

@@ -293,17 +293,3 @@ import { isDefined, Nullable } from './types';
 export function join<T extends string>(iterable: Nullable<Iterable<T>>, separator: string): string {
-    if (!iterable) {
-        return '';
-    }
-    let result = first(iterable) || '';
-    let prev: string | null = null;
-    for (const v of skip(iterable, 1)) {
-        if (prev) {
-            result = result + separator + prev;
-        }
-        prev = v;
-    }
-    if (prev) {
-        result = result + separator + prev;
-    }
-    return result;
+    return reduce(iterable, (acc, item) => (acc === null ? item : acc + separator + item), null as string | null) || '';
 }
@@ -310,0 +296,0 @@

src/test/iterables.unit.ts

@@ -132,2 +132,3 @@ import { expect } from 'chai';
         expect(join(['0'], ',')).to.eql('0');
+        expect(join(unique(['0', '0', '1']), ',')).to.eql('0,1');
     });
@@ -134,0 +135,0 @@ it('skip', () => {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

350933

decreased by-0.3%

Lines of code

5987

decreased by-0.68%

No dependency changes