@zohodesk/popups - npm Package Compare versions

Comparing version 1.0.7 to 1.0.8

es/ViewPort.js

@@ -123,3 +123,3 @@ import _Object$keys from 'babel-runtime/core-js/object/keys';
 		//leftCenter
-		var leftOverFlow = rect.width >= relativeBoxGap.right;
+		var leftOverFlow = rect.width >= relativeBoxGap.left;
 
@@ -130,7 +130,7 @@ var leftTopOverFlow = rect.height / 2 >= relativeBoxGap.center.top;
 		//leftTop
-		var leftTopOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
+		var leftTopOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
 		views.leftTop = !(leftOverFlow || leftTopOnlyOverFlow);
 
 		//leftBottom
-		var leftBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
+		var leftBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
 		views.leftBottom = !(leftOverFlow || leftBottomOnlyOverFlow);
@@ -141,3 +141,3 @@
 		//rightCenter
-		var rightOverFlow = rect.width >= relativeBoxGap.left;
+		var rightOverFlow = rect.width >= relativeBoxGap.right;
 
@@ -148,7 +148,7 @@ var rightTopOverFlow = rect.height / 2 >= relativeBoxGap.center.top;
 		//rightTop
-		var rightTopOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
+		var rightTopOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
 		views.rightTop = !(rightOverFlow || rightTopOnlyOverFlow);
 
 		//rightBottom
-		var rightBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
+		var rightBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
 		views.rightBottom = !(rightOverFlow || rightBottomOnlyOverFlow);
@@ -155,0 +155,0 @@

lib/ViewPort.js

@@ -127,3 +127,3 @@ 'use strict';
 		//leftCenter
-		var leftOverFlow = rect.width >= relativeBoxGap.right;
+		var leftOverFlow = rect.width >= relativeBoxGap.left;
 
@@ -134,7 +134,7 @@ var leftTopOverFlow = rect.height / 2 >= relativeBoxGap.center.top;
 		//leftTop
-		var leftTopOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
+		var leftTopOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
 		views.leftTop = !(leftOverFlow || leftTopOnlyOverFlow);
 
 		//leftBottom
-		var leftBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
+		var leftBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
 		views.leftBottom = !(leftOverFlow || leftBottomOnlyOverFlow);
@@ -145,3 +145,3 @@
 		//rightCenter
-		var rightOverFlow = rect.width >= relativeBoxGap.left;
+		var rightOverFlow = rect.width >= relativeBoxGap.right;
 
@@ -152,7 +152,7 @@ var rightTopOverFlow = rect.height / 2 >= relativeBoxGap.center.top;
 		//rightTop
-		var rightTopOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
+		var rightTopOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
 		views.rightTop = !(rightOverFlow || rightTopOnlyOverFlow);
 
 		//rightBottom
-		var rightBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
+		var rightBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
 		views.rightBottom = !(rightOverFlow || rightBottomOnlyOverFlow);
@@ -159,0 +159,0 @@

package.json

 {
 	"name": "@zohodesk/popups",
-	"version": "1.0.7",
+	"version": "1.0.8",
 	"description": "popups popupover modal dialog alert notifications popup handling for whole app",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

README.md

@@ -0,1 +1,3 @@
+# 1.0.8
+- popup viewPort possibilities position method changed(left & right position properly to handled).
 
@@ -15,3 +17,3 @@ # Components
 class TestPopup extends React.Component {
-	
+
 	constructor(props)
@@ -23,7 +25,7 @@ {
 	}
-	
+
 	setTargetRef(el){
 		this.targetRef=el;
 	}
-	
+
 	setContentRef(el){
@@ -37,3 +39,3 @@ this.contentRef=el;
 	}
-	
+
 	onClickYes(e){
@@ -43,3 +45,3 @@ this.updateToServer(); // Something your works...
 	}
-	
+
 	onClickNo(e){
@@ -49,17 +51,17 @@ // Something your works...
 	}
-	
+
 	render(){
-		
+
 		let { popupStyle, removeClose } = this.props;
-		
+
 		return (<div className={testStyle.container}>
-		
+
 	        <div ref={this.setTargetRef} className={testStyle.moreBox}>
 			  	 <Button onClick={this.onClickTogglePopup} text={"more"} />
 	        </div>
-			
+
 	        <div ref={this.setContentRef} className={`${testStyle.content} ${popupStyle.content}`} onClick={removeClose}>
-        		
+
 	        	<span className={popupStyle.arrow}></span>
-		      	
+
         		<div className={testStyle.closeTicketContent}>
@@ -69,7 +71,7 @@ <Button text={"yes"} onClick={this.onClickYes} type="primary"/>
 		        </div>
-		      		
+
 			</div>
-			
+
 		</div>)
-		
+
 	}
@@ -76,0 +78,0 @@ }

src/ViewPort.js

@@ -124,3 +124,3 @@ let viewPort = {
 		//leftCenter
-		let leftOverFlow = rect.width >= relativeBoxGap.right;
+		let leftOverFlow = rect.width >= relativeBoxGap.left;
 
@@ -131,7 +131,7 @@ let leftTopOverFlow = rect.height / 2 >= relativeBoxGap.center.top;
 		//leftTop
-		let leftTopOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
+		let leftTopOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
 		views.leftTop = !(leftOverFlow || leftTopOnlyOverFlow);
 
 		//leftBottom
-		let leftBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
+		let leftBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
 		views.leftBottom = !(leftOverFlow || leftBottomOnlyOverFlow);
@@ -142,3 +142,3 @@
 		//rightCenter
-		let rightOverFlow = rect.width >= relativeBoxGap.left;
+		let rightOverFlow = rect.width >= relativeBoxGap.right;
 
@@ -149,7 +149,7 @@ let rightTopOverFlow = rect.height / 2 >= relativeBoxGap.center.top;
 		//rightTop
-		let rightTopOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
+		let rightTopOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
 		views.rightTop = !(rightOverFlow || rightTopOnlyOverFlow);
 
 		//rightBottom
-		let rightBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.bottom;
+		let rightBottomOnlyOverFlow = rect.height >= relativeBoxGap.center.top;
 		views.rightBottom = !(rightOverFlow || rightBottomOnlyOverFlow);
@@ -156,0 +156,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Number of lines in readme file

92

increased by2.22%

Worsened metrics

Total package byte prevSize

224327

decreased by-39.38%

Number of package files

20

decreased by-4.76%

Lines of code

2684

decreased by-17.87%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes