abstract-http-server - npm Package Compare versions

Comparing version 2.0.2 to 2.0.4

dist/cjs/index.d.ts

@@ -6,2 +6,6 @@ /// <reference types="node" />
 import BaseError from 'baseerr';
+interface ServerLoggerType {
+    error: (...args: Array<any>) => void;
+    info: (...args: Array<any>) => void;
+}
 export declare class HttpServerStartError extends BaseError<{
@@ -13,8 +17,5 @@ opts?: ListenOptions;
 }
-export declare type OptsType = ServerOptions & {
+export declare type OptsType<Logger> = ServerOptions & {
     port?: number | undefined;
-    logger?: {
-        info: (...args: Array<any>) => void;
-        error: (...args: Array<any>) => void;
-    };
+    logger: Logger;
 };
@@ -25,8 +26,8 @@ export declare type StartOptsType = ListenOptions & {
 export declare type StopOptsType = StartableStopOptsType;
-export default abstract class AbstractHttpServer extends AbstractStartable {
+export default abstract class AbstractHttpServer<Logger extends ServerLoggerType> extends AbstractStartable {
     protected sockets: Set<Socket>;
-    protected logger: NonNullable<OptsType['logger']>;
+    protected logger: Logger;
     protected port: number | undefined;
     protected server: Server;
-    constructor(opts?: OptsType);
+    constructor(opts: OptsType<Logger>);
     protected handleConnection: (socket: Socket) => void;
@@ -37,1 +38,2 @@ protected handleRequest(req: IncomingMessage, res: ServerResponse): void | Promise<void>;
 }
+export {};

dist/cjs/index.js

@@ -17,3 +17,3 @@ "use strict";
 class AbstractHttpServer extends abstract_startable_1.default {
-    constructor(opts = {}) {
+    constructor(opts) {
         super();
@@ -25,3 +25,3 @@ this.handleConnection = (socket) => {
         this.sockets = new Set();
-        this.logger = opts.logger ?? console;
+        this.logger = opts.logger;
         this.server = http_1.default.createServer(opts);
@@ -28,0 +28,0 @@ process.nextTick(() => {

dist/esm/index.d.ts

@@ -6,2 +6,6 @@ /// <reference types="node" />
 import BaseError from 'baseerr';
+interface ServerLoggerType {
+    error: (...args: Array<any>) => void;
+    info: (...args: Array<any>) => void;
+}
 export declare class HttpServerStartError extends BaseError<{
@@ -13,8 +17,5 @@ opts?: ListenOptions;
 }
-export declare type OptsType = ServerOptions & {
+export declare type OptsType<Logger> = ServerOptions & {
     port?: number | undefined;
-    logger?: {
-        info: (...args: Array<any>) => void;
-        error: (...args: Array<any>) => void;
-    };
+    logger: Logger;
 };
@@ -25,8 +26,8 @@ export declare type StartOptsType = ListenOptions & {
 export declare type StopOptsType = StartableStopOptsType;
-export default abstract class AbstractHttpServer extends AbstractStartable {
+export default abstract class AbstractHttpServer<Logger extends ServerLoggerType> extends AbstractStartable {
     protected sockets: Set<Socket>;
-    protected logger: NonNullable<OptsType['logger']>;
+    protected logger: Logger;
     protected port: number | undefined;
     protected server: Server;
-    constructor(opts?: OptsType);
+    constructor(opts: OptsType<Logger>);
     protected handleConnection: (socket: Socket) => void;
@@ -37,1 +38,2 @@ protected handleRequest(req: IncomingMessage, res: ServerResponse): void | Promise<void>;
 }
+export {};

dist/esm/index.js

@@ -9,3 +9,3 @@ import AbstractStartable from 'abstract-startable';
 export default class AbstractHttpServer extends AbstractStartable {
-    constructor(opts = {}) {
+    constructor(opts) {
         super();
@@ -17,3 +17,3 @@ this.handleConnection = (socket) => {
         this.sockets = new Set();
-        this.logger = opts.logger ?? console;
+        this.logger = opts.logger;
         this.server = http.createServer(opts);
@@ -20,0 +20,0 @@ process.nextTick(() => {

package.json

 {
   "name": "abstract-http-server",
-  "version": "2.0.2",
+  "version": "2.0.4",
   "description": "Description",
@@ -5,0 +5,0 @@ "main": "dist/cjs/index.js",

src/index.ts

@@ -14,11 +14,13 @@ import AbstractStartable, {
 
+interface ServerLoggerType {
+  error: (...args: Array<any>) => void
+  info: (...args: Array<any>) => void
+}
+
 export class HttpServerStartError extends BaseError<{ opts?: ListenOptions }> {}
 export class HttpServerStopError extends BaseError<{}> {}
 
-export type OptsType = ServerOptions & {
+export type OptsType<Logger> = ServerOptions & {
   port?: number | undefined
-  logger?: {
-    info: (...args: Array<any>) => void
-    error: (...args: Array<any>) => void
-  }
+  logger: Logger
 }
@@ -31,12 +33,14 @@
 
-export default abstract class AbstractHttpServer extends AbstractStartable {
+export default abstract class AbstractHttpServer<
+  Logger extends ServerLoggerType
+> extends AbstractStartable {
   protected sockets: Set<Socket>
-  protected logger: NonNullable<OptsType['logger']>
+  protected logger: Logger
   protected port: number | undefined
   protected server: Server
 
-  constructor(opts: OptsType = {}) {
+  constructor(opts: OptsType<Logger>) {
     super()
     this.sockets = new Set()
-    this.logger = opts.logger ?? console
+    this.logger = opts.logger
     this.server = http.createServer(opts)
@@ -43,0 +47,0 @@ process.nextTick(() => {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

34028

increased by0.26%

Lines of code

541

increased by1.31%

No dependency changes