airbrake - npm Package Compare versions

Comparing version 1.2.0 to 1.2.1

CHANGELOG.md

@@ -6,6 +6,12 @@ Node Airbrake Changelog
 
+### [v1.2.1][v1.2.1] (February 15, 2017)
+
+* Fixed bug when client crashes when tries to notify due to missing `projectId`
+  or `projectKey`. These values are mandatory to create a new client now
+  ([#125](https://github.com/airbrake/node-airbrake/pull/125))
+
 ### [v1.2.0][v1.2.0] (Semptember 8, 2016)
 
 * **IMPORTANT:** Removed the `developmentEnvironments` config option
-  ([#119](https://github.com/airbrake/node-airbrake/pull/112))
+  ([#119](https://github.com/airbrake/node-airbrake/pull/119))
 * Express & hapi integrations send `component` and `action` info now
@@ -85,1 +91,2 @@ ([#120](https://github.com/airbrake/node-airbrake/pull/120))
 [v1.2.0]: https://github.com/airbrake/node-airbrake/releases/tag/v1.2.0
+[v1.2.1]: https://github.com/airbrake/node-airbrake/releases/tag/v1.2.1

lib/airbrake.js

@@ -62,2 +62,7 @@ var HTTP_STATUS_CODES = require('http').STATUS_CODES;
   instance.projectId = projectId || instance.projectId;
+
+  if (!instance.key || !instance.projectId) {
+    throw new Error('Key or project ID missing during Airbrake.createClient()');
+  }
+
   return instance;
@@ -64,0 +69,0 @@ };

package.json

@@ -21,3 +21,3 @@ {
   "description": "A Node.js notifier for Airbrake, the leading exception reporting service.",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "homepage": "https://github.com/airbrake/node-airbrake",
@@ -24,0 +24,0 @@ "repository": {

README.md

@@ -370,3 +370,3 @@ Node Airbrake
 [screenshot]: https://github.com/airbrake/node-airbrake/raw/master/screenshot.png
-[deployment tracking]: http://help.airbrake.io/kb/api-2/deploy-tracking
+[deployment tracking]: https://airbrake.io/docs/airbrake-faq/deploy-tracking/
 [dashboard]: http://s3.amazonaws.com/airbrake-github-assets/node-airbrake/airbrake-dashboard.png

test/fast/test-environment.js

@@ -8,3 +8,3 @@ var common = require('../common');
 (function testProductionEnviroment() {
-  var airbrake = Airbrake.createClient(null, common.key, 'production');
+  var airbrake = Airbrake.createClient(common.projectId, common.key, 'production');
   sinon.stub(airbrake, '_sendRequest');
@@ -11,0 +11,0 @@

test/fast/test-express-handler.js

 var express = require('express');
 var app = express();
 var common = require('../common');
-var airbrake = require(common.dir.root).createClient(null, common.key);
+var airbrake = require(common.dir.root).createClient(common.projectId, common.key);
 var assert = require('assert');
@@ -6,0 +6,0 @@ var sinon = require('sinon');

test/fast/test-filter.js

@@ -8,3 +8,3 @@ var common = require('../common');
 (function testAddFilterFiresOnce() {
-  var airbrake = Airbrake.createClient(null, common.key, 'dev');
+  var airbrake = Airbrake.createClient(common.projectId, common.key, 'dev');
   sinon.stub(airbrake, '_sendRequest');
@@ -23,3 +23,3 @@
 (function testAddFilterModifiesNotice() {
-  var airbrake = Airbrake.createClient(null, common.key, 'dev');
+  var airbrake = Airbrake.createClient(common.projectId, common.key, 'dev');
   sinon.stub(airbrake, '_sendRequest');
@@ -43,3 +43,3 @@
 (function testAddFilterIgnoresNotices() {
-  var airbrake = Airbrake.createClient(null, common.key, 'dev');
+  var airbrake = Airbrake.createClient(common.projectId, common.key, 'dev');
   sinon.stub(airbrake, '_sendRequest');
@@ -53,3 +53,3 @@
 (function testAddFilterStartsExecutionFromOldestFilter() {
-  var airbrake = Airbrake.createClient(null, common.key, 'dev');
+  var airbrake = Airbrake.createClient(common.projectId, common.key, 'dev');
   sinon.stub(airbrake, '_sendRequest');
@@ -76,3 +76,3 @@
 (function testAddFilterStartsExecutionFromOldestFilterButStopsIfShouldIgnore() {
-  var airbrake = Airbrake.createClient(null, common.key, 'dev');
+  var airbrake = Airbrake.createClient(common.projectId, common.key, 'dev');
   sinon.stub(airbrake, '_sendRequest');
@@ -79,0 +79,0 @@

test/fast/test-handle-exceptions.js

 var common = require('../common');
-var airbrake = require(common.dir.root).createClient();
+var airbrake = require(common.dir.root).createClient(common.projectId, common.key);
 var assert = require('assert');
@@ -4,0 +4,0 @@ var sinon = require('sinon');

test/fast/test-hapi-handler.js

@@ -7,3 +7,3 @@ var semver = require('semver');
   var common = require('../common');
-  var airbrake = require(common.dir.root).createClient(null, common.key);
+  var airbrake = require(common.dir.root).createClient(common.projectId, common.key);
   var assert = require('assert');
@@ -10,0 +10,0 @@ var sinon = require('sinon');

test/fast/test-host.js

 var common = require('../common');
-var airbrake = require(common.dir.root).createClient();
+var airbrake = require(common.dir.root).createClient(common.projectId, common.key);
 var assert = require('assert');
@@ -4,0 +4,0 @@ var os = require('os');

test/fast/test-ignored-exceptions.js

@@ -20,3 +20,3 @@ var common = require('../common');
 (function testAddingExceptionToIgnoredExceptions() {
-  var airbrake = Airbrake.createClient(null, common.key, 'production');
+  var airbrake = Airbrake.createClient(common.projectId, common.key, 'production');
   airbrake.ignoredExceptions.push(MyError);
@@ -23,0 +23,0 @@

test/fast/test-request-vars.js

 var common = require('../common');
-var airbrake = require(common.dir.root).createClient();
+var airbrake = require(common.dir.root).createClient(common.projectId, common.key);
 var assert = require('assert');
@@ -4,0 +4,0 @@

test/slow/test-custom-request-options.js

@@ -16,3 +16,3 @@ var mockery = require('mockery');
 var Airbrake = require(common.dir.root);
-var airbrake = Airbrake.createClient(null, common.key, 'production');
+var airbrake = Airbrake.createClient(common.projectId, common.key, 'production');
 airbrake.requestOptions = {
@@ -19,0 +19,0 @@ myCustomOption: 'myCustomValue',

test/slow/test-error-event.js

 var common = require('../common');
-var airbrake = require(common.dir.root).createClient(null, common.key, 'production');
+var airbrake = require(common.dir.root).createClient(common.projectId, common.key, 'production');
 var assert = require('assert');
@@ -4,0 +4,0 @@ var http = require('http');

test/slow/test-handle-exceptions.js

 var common = require('../common');
-var airbrake = require(common.dir.root).createClient(null, common.key);
+var airbrake = require(common.dir.root).createClient(common.projectId, common.key);
 var sinon = require('sinon');
@@ -4,0 +4,0 @@

test/slow/test-throw-undefined.js

 // Tests for throwing undefined, ignore rule.
 /* eslint no-throw-literal: 0 */
 var common = require('../common');
-var airbrake = require(common.dir.root).createClient(null, common.key);
+var airbrake = require(common.dir.root).createClient(common.projectId, common.key);
 var sinon = require('sinon');
@@ -6,0 +6,0 @@

test/slow/test-track-deployment.js

 var common = require('../common');
 var Airbrake = require(common.dir.root);
-var airbrake = Airbrake.createClient(null, common.key);
+var airbrake = Airbrake.createClient(common.projectId, common.key);
 var sinon = require('sinon');
@@ -5,0 +5,0 @@ var assert = require('assert');

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

50008

increased by2.5%

Number of package files

28

increased by3.7%

Lines of code

935

increased by2.3%

Worsened metrics

Number of low supply chain risk alerts

24

increased by4.35%

No dependency changes