amplitude - npm Package Compare versions

Comparing version 1.0.6 to 1.0.7

gulpfile.js

@@ -1,8 +0,3 @@
-var gulp = require('gulp');
-var babel = require('gulp-babel');
-
-gulp.task('default', function () {
-  return gulp.src('./src/amplitude.js')
-    .pipe(babel())
-    .pipe(gulp.dest('lib'));
-});
+require('babel/register');
+require('glob').sync('./tasks/gulp-*').forEach(require);
+require('gulp').task('default', ['build:watch']);

lib/amplitude.js

@@ -50,5 +50,5 @@ 'use strict';
       console.error('There was a problem tracking "' + data.event_type + '" for "' + name + '"; ' + err);
-      cb(err);
+      cb(err, res.body);
     } else if (cb) {
-      cb(res.body);
+      cb(null, res.body);
     }
@@ -55,0 +55,0 @@ });

package.json

 {
   "name": "amplitude",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "A node wrapper for Amplitude analytics http api",
   "author": "Blade Barringer <[e-mail]>",
+  "contributors": [
+    {
+      "name": "Erki Esken",
+      "email": "[e-mail]",
+      "url": "http://deekit.net/"
+    }
+  ],
   "scripts": {
-    "compile": "node_modules/.bin/gulp",
+    "compile": "node_modules/.bin/gulp build",
     "prepublish": "npm run compile",
@@ -29,2 +36,3 @@ "test": "mocha"
     "chai": "^3.0.0",
+    "glob": "^5.0.14",
     "gulp": "^3.9.0",
@@ -31,0 +39,0 @@ "gulp-babel": "^5.1.0",

README.md

@@ -28,7 +28,7 @@ # amplitude
   event_type: "some value", // required
-  event_properties: { 
-    //... 
+  event_properties: {
+    //...
   },
-  user_properties: { 
-    //... 
+  user_properties: {
+    //...
   }
@@ -42,3 +42,3 @@ }
 ```javascript
-amplitude.track(data, function(error) {
+amplitude.track(data, function(error, resBody) {
   // If post was succesful, error will be null
@@ -48,1 +48,6 @@ //... do something
 ```
+
+<!---
+Do not change anything below this comment. It is generated automatically.
+------>
+

test/track.test.js

@@ -21,4 +21,8 @@ let nock = require('nock');
     beforeEach(() => {
-      nock(api_url).post(stringified_url)
-       .reply(200);
+      nock(api_url)
+        .defaultReplyHeaders({ 'Content-Type': 'application/json' })
+        .post(stringified_url)
+        .reply(function () {
+          return [200, JSON.stringify({ some: 'data' })];
+        });
     });
@@ -29,7 +33,17 @@
 
-      amplitude.track(data, () => {
+      amplitude.track(data, (err) => {
         expect(console.error).to.not.be.called;
+        expect(err).to.be.a('null');
         done();
       });
     });
+
+    it('passes response data', (done) => {
+      let data = { event_type: 'event' };
+
+      amplitude.track(data, (err, data) => {
+        expect(data).to.include.keys('some');
+        done();
+      });
+    });
   });
@@ -41,14 +55,26 @@
     beforeEach(() => {
-      nock(api_url).post(stringified_url)
-       .replyWithError('not succesful');
+      nock(api_url)
+        .defaultReplyHeaders({ 'Content-Type': 'application/json' })
+        .post(stringified_url)
+        .reply(function () {
+          return [500, { message: 'not successful' }];
+        })
     });
 
     it('logs error', (done) => {
-      amplitude.track(data, () => {
+      amplitude.track(data, (err, data) => {
         expect(console.error).to.be.calledOnce;
-        expect(console.error).to.be.calledWith('There was a problem tracking "event" for "unique_user_id"; Error: not succesful');
+        expect(console.error).to.be.calledWith('There was a problem tracking "event" for "unique_user_id"; Error: Internal Server Error');
         done();
       });
     });
+
+    it('passes error response data', (done) => {
+      amplitude.track(data, (err, data) => {
+        expect(data).to.include.keys('message');
+        expect(data.message).to.equal('not successful');
+        done();
+      });
+    });
   });
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Filesystem access

Supply chain risk

Accesses the file system, and could potentially read sensitive data.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

9198

increased by29.86%

Number of package files

12

increased by20%

Lines of code

190

increased by40.74%

Number of lines in readme file

51

increased by10.87%

Worsened metrics

Dev dependency count

9

increased by12.5%

Number of low supply chain risk alerts

1

increased byInfinity%

No dependency changes