amqp-cacoon - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

build/helpers/message_batching_manager.d.ts

@@ -55,3 +55,3 @@ import { Channel, ConsumeMessage, ConsumeBatchMessages } from '../index';
      * Do this by...
-     * 1. Loop over all messages in list and ack them
+     * 1. Ack the last message using allUpTo argumetn to specify that all messages up to the last should be nacked
      *
@@ -61,3 +61,3 @@ * @param channel: Channel - Channel
      */
-    ackMessageList(channel: Channel, messageList: Array<ConsumeMessage>, allUpTo?: boolean): void;
+    ackMessageList(channel: Channel, messageList: Array<ConsumeMessage>): void;
     /**
@@ -67,3 +67,3 @@ * nackMessageList
      * Do this by...
-     * 1. Loop over all messages in list and nack them
+     * 1. Nack the last message using the allUpTo argument to specify that all messages up to the last should be nacked
      *
@@ -73,3 +73,3 @@ * @param channel: Channel - Channel
      */
-    nackMessageList(channel: Channel, messageList: Array<ConsumeMessage>, allUpTo?: boolean, requeue?: boolean): void;
+    nackMessageList(channel: Channel, messageList: Array<ConsumeMessage>, requeue?: boolean): void;
     /**
@@ -76,0 +76,0 @@ * sendBufferedMessages

build/helpers/message_batching_manager.js

@@ -97,3 +97,3 @@ "use strict";
      * Do this by...
-     * 1. Loop over all messages in list and ack them
+     * 1. Ack the last message using allUpTo argumetn to specify that all messages up to the last should be nacked
      *
@@ -103,11 +103,8 @@ * @param channel: Channel - Channel
      */
-    MessageBatchingManager.prototype.ackMessageList = function (channel, messageList, allUpTo) {
+    MessageBatchingManager.prototype.ackMessageList = function (channel, messageList) {
         if (this.logger) {
             this.logger.trace("MessageBatchingManager.ackMessageList: Start");
         }
-        // 1. Loop over all messages in list and ack them
-        for (var _i = 0, messageList_1 = messageList; _i < messageList_1.length; _i++) {
-            var msg = messageList_1[_i];
-            channel.ack(msg, allUpTo);
-        }
+        // 1. Ack the last message using allUpTo argumetn to specify that all messages up to the last should be nacked
+        channel.ack(messageList[messageList.length - 1], true);
         if (this.logger) {
@@ -121,3 +118,3 @@ this.logger.trace("MessageBatchingManager.ackMessageList: End");
      * Do this by...
-     * 1. Loop over all messages in list and nack them
+     * 1. Nack the last message using the allUpTo argument to specify that all messages up to the last should be nacked
      *
@@ -127,11 +124,8 @@ * @param channel: Channel - Channel
      */
-    MessageBatchingManager.prototype.nackMessageList = function (channel, messageList, allUpTo, requeue) {
+    MessageBatchingManager.prototype.nackMessageList = function (channel, messageList, requeue) {
         if (this.logger) {
             this.logger.trace("MessageBatchingManager.nackMessageList: Start");
         }
-        // 1. Loop over all messages in list and nack them
-        for (var _i = 0, messageList_2 = messageList; _i < messageList_2.length; _i++) {
-            var msg = messageList_2[_i];
-            channel.nack(msg, allUpTo, requeue);
-        }
+        // 1. Nack the last message using the allUpTo argument to specify that all messages up to the last should be nacked
+        channel.nack(messageList[messageList.length - 1], true, requeue);
         if (this.logger) {
@@ -173,8 +167,6 @@ this.logger.trace("MessageBatchingManager.nackMessageList: End");
                             messages: unackedMessageList,
-                            ackAll: function (allUpTo) {
-                                return _this.ackMessageList(channel, unackedMessageList, allUpTo);
+                            ackAll: function () { return _this.ackMessageList(channel, unackedMessageList); },
+                            nackAll: function (requeue) {
+                                return _this.nackMessageList(channel, unackedMessageList, requeue);
                             },
-                            nackAll: function (allUpTo, requeue) {
-                                return _this.nackMessageList(channel, unackedMessageList, allUpTo, requeue);
-                            },
                         };
@@ -181,0 +173,0 @@ return [4 /*yield*/, handler(channel, messages)];

package.json

 {
   "name": "amqp-cacoon",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "AmqpCacoon is an abstraction around amqplib that provides a simple interface with flow control included out of the box",
@@ -5,0 +5,0 @@ "main": "build/index.js",

No alert changes

Worsened metrics

Total package byte prevSize

55844

decreased by-0.29%

Lines of code

918

decreased by-0.86%

No dependency changes