amqp-connection-manager - npm Package Compare versions

Comparing version 3.2.1 to 3.2.2

.nyc_output/processinfo/index.json

@@ -1,1 +0,1 @@
-{"processes":{"2176b07c-e7ef-44b0-a792-6720ea27aacb":{"parent":null,"children":[]},"d46e8f66-96d8-4c84-b8f5-b901f66bb9bc":{"parent":null,"children":[]}},"files":{"/home/runner/work/node-amqp-connection-manager/node-amqp-connection-manager/src/ChannelWrapper.js":["2176b07c-e7ef-44b0-a792-6720ea27aacb","d46e8f66-96d8-4c84-b8f5-b901f66bb9bc"],"/home/runner/work/node-amqp-connection-manager/node-amqp-connection-manager/src/helpers.js":["2176b07c-e7ef-44b0-a792-6720ea27aacb","d46e8f66-96d8-4c84-b8f5-b901f66bb9bc"],"/home/runner/work/node-amqp-connection-manager/node-amqp-connection-manager/src/AmqpConnectionManager.js":["2176b07c-e7ef-44b0-a792-6720ea27aacb","d46e8f66-96d8-4c84-b8f5-b901f66bb9bc"],"/home/runner/work/node-amqp-connection-manager/node-amqp-connection-manager/src/index.js":["2176b07c-e7ef-44b0-a792-6720ea27aacb","d46e8f66-96d8-4c84-b8f5-b901f66bb9bc"]},"externalIds":{}}
+{"processes":{"046ee5ef-e015-4357-a20c-3b3965863bdd":{"parent":null,"children":[]},"ef3a0a7f-3efd-4474-a800-38a9b92be3bb":{"parent":null,"children":[]}},"files":{"/home/runner/work/node-amqp-connection-manager/node-amqp-connection-manager/src/ChannelWrapper.js":["046ee5ef-e015-4357-a20c-3b3965863bdd","ef3a0a7f-3efd-4474-a800-38a9b92be3bb"],"/home/runner/work/node-amqp-connection-manager/node-amqp-connection-manager/src/helpers.js":["046ee5ef-e015-4357-a20c-3b3965863bdd","ef3a0a7f-3efd-4474-a800-38a9b92be3bb"],"/home/runner/work/node-amqp-connection-manager/node-amqp-connection-manager/src/AmqpConnectionManager.js":["046ee5ef-e015-4357-a20c-3b3965863bdd","ef3a0a7f-3efd-4474-a800-38a9b92be3bb"],"/home/runner/work/node-amqp-connection-manager/node-amqp-connection-manager/src/index.js":["046ee5ef-e015-4357-a20c-3b3965863bdd","ef3a0a7f-3efd-4474-a800-38a9b92be3bb"]},"externalIds":{}}

CHANGELOG.md

@@ -0,1 +1,8 @@
+## [3.2.2](https://github.com/jwalton/node-amqp-connection-manager/compare/v3.2.1...v3.2.2) (2021-02-09)
+
+
+### Bug Fixes
+
+* When messages are acked/nacked, make sure we remove the correct message from the sent messages queue. ([c662026](https://github.com/jwalton/node-amqp-connection-manager/commit/c662026bc287e684a0f43ce2de7a44b80a88e8ff)), closes [#142](https://github.com/jwalton/node-amqp-connection-manager/issues/142)
+
 ## [3.2.1](https://github.com/jwalton/node-amqp-connection-manager/compare/v3.2.0...v3.2.1) (2020-09-12)
@@ -2,0 +9,0 @@

lib/ChannelWrapper.js

@@ -387,4 +387,3 @@ "use strict";
     }).then(result => {
-      this._unconfirmedMessages.shift();
-
+      removeUnconfirmedMessage(this._unconfirmedMessages, message);
       message.resolve(result);
@@ -395,8 +394,9 @@ }, err => {
         // reconnect.
-        this._messages.unshift(this._unconfirmedMessages.shift());
+        removeUnconfirmedMessage(this._unconfirmedMessages, message);
+
+        this._messages.unshift(message);
       } else {
         // Something went wrong trying to send this message - could be JSON.stringify failed, could be the
         // broker rejected the message.  Either way, reject it back
-        this._unconfirmedMessages.shift();
-
+        removeUnconfirmedMessage(this._unconfirmedMessages, message);
         message.reject(err);
@@ -451,2 +451,7 @@ }
     return this._channel && this._channel.bindQueue.apply(this._channel, arguments);
+  } // Send a `deleteQueue` to the underlying channel.
+
+
+  deleteQueue() {
+    return this._channel && this._channel.deleteQueue.apply(this._channel, arguments);
   } // Send a `assertExchange` to the underlying channel.
@@ -457,2 +462,7 @@
     return this._channel && this._channel.assertExchange.apply(this._channel, arguments);
+  } // Send a `get` to the underlying channel.
+
+
+  get() {
+    return this._channel && this._channel.get.apply(this._channel, arguments);
   }
@@ -463,2 +473,13 @@
 exports.default = ChannelWrapper;
+
+function removeUnconfirmedMessage(arr, message) {
+  const toRemove = arr.indexOf(message);
+
+  if (toRemove === -1) {
+    throw new Error(`Message is not in _unconfirmedMessages!`);
+  }
+
+  const removed = arr.splice(toRemove, 1);
+  return removed[0];
+}
 //# sourceMappingURL=ChannelWrapper.js.map

package.json

 {
   "name": "amqp-connection-manager",
-  "version": "3.2.1",
+  "version": "3.2.2",
   "description": "Auto-reconnect and round robin support for amqplib.",
@@ -32,3 +32,3 @@ "main": "lib/index.js",
     "greenkeeper-lockfile": "^1.14.0",
-    "husky": "^4.3.0",
+    "husky": "^5.0.9",
     "istanbul": "^0.4.0",
@@ -35,0 +35,0 @@ "mocha": "^8.1.3",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

199937

increased by3.78%

Number of package files

24

increased by4.35%

Lines of code

617

increased by2.49%

No dependency changes