angular-web-notification - npm Package Compare versions

Comparing version 1.0.8 to 1.0.9

angular-web-notification.js

@@ -126,3 +126,3 @@ /**
          * @param {object} options - Holds the notification data (web notification API spec for more info)
-         * @param {string} [options.icon=favicon.ico] - The notification icon (defaults to the website favicon.ico)
+         * @param {string} [options.icon=/favicon.ico] - The notification icon (defaults to the website favicon.ico)
          * @param {number} [options.autoClose] - Auto closes the notification after the provided amount of millies (0 or undefined for no auto close)
@@ -143,3 +143,3 @@ * @param {function} [options.onClick] - An optional onclick event handler
             if (!options.icon) {
-                options.icon = document.location.protocol + '//' + document.location.host + '/favicon.ico';
+                options.icon = '/favicon.ico';
             }
@@ -217,3 +217,3 @@
          * @param {object} [options] - Holds the notification data (web notification API spec for more info)
-         * @param {string} [options.icon=favicon.ico] - The notification icon (defaults to the website favicon.ico)
+         * @param {string} [options.icon=/favicon.ico] - The notification icon (defaults to the website favicon.ico)
          * @param {number} [options.autoClose] - Auto closes the notification after the provided amount of millies (0 or undefined for no auto close)
@@ -220,0 +220,0 @@ * @param {function} [options.onClick] - An optional onclick event handler

bower.json

 {
   "name": "angular-web-notification",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "description": "AngularJS service for displaying web notifications.",
@@ -5,0 +5,0 @@ "authors": [

docs/api.md

@@ -57,3 +57,3 @@ ## Objects
 | [options] | <code>object</code> |  | Holds the notification data (web notification API spec for more info) |
-| [options.icon] | <code>string</code> | <code>&quot;favicon.ico&quot;</code> | The notification icon (defaults to the website favicon.ico) |
+| [options.icon] | <code>string</code> | <code>&quot;/favicon.ico&quot;</code> | The notification icon (defaults to the website favicon.ico) |
 | [options.autoClose] | <code>number</code> |  | Auto closes the notification after the provided amount of millies (0 or undefined for no auto close) |
@@ -60,0 +60,0 @@ | [options.onClick] | <code>function</code> |  | An optional onclick event handler |

docs/CHANGELOG.md

 | Date        | Version | Description |
 | ----------- | ------- | ----------- |
-| 2016-09-11  | v1.0.8  | Maintenance |
+| 2016-09-11  | v1.0.9  | Maintenance |
 | 2016-09-10  | v1.0.6  | Default to website favicon.ico if icon not provided in options |
@@ -5,0 +5,0 @@ | 2016-09-07  | v1.0.4  | Callback is now optional |

package.json

 {
   "name": "angular-web-notification",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "description": "AngularJS service for displaying web notifications.",
@@ -5,0 +5,0 @@ "author": {

README.md

@@ -111,3 +111,3 @@ # angular-web-notification
 | ----------- | ------- | ----------- |
-| 2016-09-11  | v1.0.8  | Maintenance |
+| 2016-09-11  | v1.0.9  | Maintenance |
 | 2016-09-10  | v1.0.6  | Default to website favicon.ico if icon not provided in options |
@@ -114,0 +114,0 @@ | 2016-09-07  | v1.0.4  | Callback is now optional |

test/spec/angular-web-notification-spec.js

@@ -9,3 +9,3 @@ /*global describe: false, assert: false, inject: false, it: false, beforeEach: false */
         assert.deepEqual(options, {
-            icon: 'http://localhost:8080/favicon.ico' //based on karma configuration
+            icon: '/favicon.ico'
         });
@@ -156,3 +156,3 @@ };
                             body: 'no title',
-                            icon: 'http://localhost:8080/favicon.ico' //based on karma configuration
+                            icon: '/favicon.ico'
                         });
@@ -173,6 +173,5 @@ });
                         assert.equal(title, 'Example Notification');
-                        console.log(options)//TODO RMOVE
                         assert.deepEqual(options, {
                             body: 'Notification Text...',
-                            icon: 'http://localhost:8080/favicon.ico' //based on karma configuration
+                            icon: '/favicon.ico'
                         });
@@ -194,3 +193,3 @@ });
                         assert.deepEqual(options, {
-                            icon: 'http://localhost:8080/favicon.ico' //based on karma configuration
+                            icon: '/favicon.ico'
                         });
@@ -197,0 +196,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

69266

decreased by-0.46%

Lines of code

938

decreased by-0.11%

No dependency changes