angular-web-notification - npm Package Compare versions

Comparing version 1.2.8 to 1.2.9

.c9/metadata/workspace/bower.json

@@ -1,1 +0,1 @@
-{"filter":false,"title":"bower.json","tooltip":"/bower.json","undoManager":{"mark":3,"position":3,"stack":[[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["5"],"id":2},{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["6"]}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["6"],"id":3}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["7"],"id":4}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["7"],"id":5},{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["8"]}]]},"ace":{"folds":[],"scrolltop":0,"scrollleft":0,"selection":{"start":{"row":2,"column":19},"end":{"row":2,"column":19},"isBackwards":false},"options":{"guessTabSize":true,"useWrapMode":false,"wrapToView":true},"firstLineState":0},"timestamp":1489051652446,"hash":"6ac5d5ed427f1c19854fc97c727920f989f27ec2"}
+{"filter":false,"title":"bower.json","tooltip":"/bower.json","undoManager":{"mark":4,"position":4,"stack":[[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["5"],"id":2},{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["6"]}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["6"],"id":3}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["7"],"id":4}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["7"],"id":5},{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["8"]}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["8"],"id":7},{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["9"]}]]},"ace":{"folds":[],"scrolltop":0,"scrollleft":0,"selection":{"start":{"row":2,"column":19},"end":{"row":2,"column":19},"isBackwards":false},"options":{"guessTabSize":true,"useWrapMode":false,"wrapToView":true},"firstLineState":0},"timestamp":1489067292856,"hash":"15fc90fce590c06b4bf07627eed03b5fb1a02ef3"}

.c9/metadata/workspace/docs/CHANGELOG.md

@@ -1,1 +0,1 @@
-{"filter":false,"title":"CHANGELOG.md","tooltip":"/docs/CHANGELOG.md","undoManager":{"mark":11,"position":11,"stack":[[{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"remove","lines":["5"],"id":2},{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"insert","lines":["6"]}],[{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"remove","lines":["6"],"id":3}],[{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"insert","lines":["7"],"id":4}],[{"start":{"row":2,"column":10},"end":{"row":2,"column":12},"action":"remove","lines":["31"],"id":5},{"start":{"row":2,"column":10},"end":{"row":2,"column":11},"action":"insert","lines":["1"]}],[{"start":{"row":2,"column":11},"end":{"row":2,"column":12},"action":"insert","lines":["0"],"id":6}],[{"start":{"row":2,"column":7},"end":{"row":2,"column":9},"action":"remove","lines":["01"],"id":7},{"start":{"row":2,"column":7},"end":{"row":2,"column":8},"action":"insert","lines":["0"]}],[{"start":{"row":2,"column":8},"end":{"row":2,"column":9},"action":"insert","lines":["2"],"id":8}],[{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"remove","lines":["7"],"id":9},{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"insert","lines":["8"]}],[{"start":{"row":2,"column":10},"end":{"row":2,"column":12},"action":"remove","lines":["10"],"id":10},{"start":{"row":2,"column":10},"end":{"row":2,"column":11},"action":"insert","lines":["0"]}],[{"start":{"row":2,"column":11},"end":{"row":2,"column":12},"action":"insert","lines":["9"],"id":11}],[{"start":{"row":2,"column":8},"end":{"row":2,"column":9},"action":"remove","lines":["2"],"id":12}],[{"start":{"row":2,"column":8},"end":{"row":2,"column":9},"action":"insert","lines":["3"],"id":13}]]},"ace":{"folds":[],"scrolltop":0,"scrollleft":0,"selection":{"start":{"row":2,"column":9},"end":{"row":2,"column":9},"isBackwards":false},"options":{"guessTabSize":true,"useWrapMode":false,"wrapToView":true},"firstLineState":0},"timestamp":1489051657696,"hash":"024f0ce7c7b5024fd2bc5e1195c64cd1327545a7"}
+{"filter":false,"title":"CHANGELOG.md","tooltip":"/docs/CHANGELOG.md","undoManager":{"mark":12,"position":12,"stack":[[{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"remove","lines":["5"],"id":2},{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"insert","lines":["6"]}],[{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"remove","lines":["6"],"id":3}],[{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"insert","lines":["7"],"id":4}],[{"start":{"row":2,"column":10},"end":{"row":2,"column":12},"action":"remove","lines":["31"],"id":5},{"start":{"row":2,"column":10},"end":{"row":2,"column":11},"action":"insert","lines":["1"]}],[{"start":{"row":2,"column":11},"end":{"row":2,"column":12},"action":"insert","lines":["0"],"id":6}],[{"start":{"row":2,"column":7},"end":{"row":2,"column":9},"action":"remove","lines":["01"],"id":7},{"start":{"row":2,"column":7},"end":{"row":2,"column":8},"action":"insert","lines":["0"]}],[{"start":{"row":2,"column":8},"end":{"row":2,"column":9},"action":"insert","lines":["2"],"id":8}],[{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"remove","lines":["7"],"id":9},{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"insert","lines":["8"]}],[{"start":{"row":2,"column":10},"end":{"row":2,"column":12},"action":"remove","lines":["10"],"id":10},{"start":{"row":2,"column":10},"end":{"row":2,"column":11},"action":"insert","lines":["0"]}],[{"start":{"row":2,"column":11},"end":{"row":2,"column":12},"action":"insert","lines":["9"],"id":11}],[{"start":{"row":2,"column":8},"end":{"row":2,"column":9},"action":"remove","lines":["2"],"id":12}],[{"start":{"row":2,"column":8},"end":{"row":2,"column":9},"action":"insert","lines":["3"],"id":13}],[{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"remove","lines":["8"],"id":15},{"start":{"row":2,"column":21},"end":{"row":2,"column":22},"action":"insert","lines":["9"]}]]},"ace":{"folds":[],"scrolltop":0,"scrollleft":0,"selection":{"start":{"row":2,"column":22},"end":{"row":2,"column":22},"isBackwards":false},"options":{"guessTabSize":true,"useWrapMode":false,"wrapToView":true},"firstLineState":0},"timestamp":1489067295182,"hash":"9964599ee37cd65faf34150f82eafbb514b44676"}

.c9/metadata/workspace/package.json

@@ -1,1 +0,1 @@
-{"filter":false,"title":"package.json","tooltip":"/package.json","undoManager":{"mark":3,"position":3,"stack":[[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["5"],"id":2},{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["6"]}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["6"],"id":3}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["7"],"id":4}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["7"],"id":5},{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["8"]}]]},"ace":{"folds":[],"scrolltop":0,"scrollleft":0,"selection":{"start":{"row":2,"column":19},"end":{"row":2,"column":19},"isBackwards":false},"options":{"guessTabSize":true,"useWrapMode":false,"wrapToView":true},"firstLineState":0},"timestamp":1489051650231,"hash":"5a2091b888bf2b74600cd19ee50323e39a94967c"}
+{"filter":false,"title":"package.json","tooltip":"/package.json","undoManager":{"mark":5,"position":5,"stack":[[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["5"],"id":2},{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["6"]}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["6"],"id":3}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["7"],"id":4}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["7"],"id":5},{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["8"]}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"remove","lines":["8"],"id":7}],[{"start":{"row":2,"column":18},"end":{"row":2,"column":19},"action":"insert","lines":["9"],"id":8}]]},"ace":{"folds":[],"scrolltop":0,"scrollleft":0,"selection":{"start":{"row":2,"column":19},"end":{"row":2,"column":19},"isBackwards":false},"options":{"guessTabSize":true,"useWrapMode":false,"wrapToView":true},"firstLineState":0},"timestamp":1489067290957,"hash":"8cd9a9a584f034adcdfc225eef68bfc5f8b394e1"}

angular-web-notification.js

@@ -70,3 +70,2 @@ /**
 
-        /*istanbul ignore else*/
         if (showNotification) {
@@ -73,0 +72,0 @@ return webNotificationAPI;

bower.json

 {
   "name": "angular-web-notification",
-  "version": "1.2.8",
+  "version": "1.2.9",
   "description": "AngularJS service for displaying web notifications.",
@@ -5,0 +5,0 @@ "authors": [

docs/CHANGELOG.md

 | Date        | Version | Description |
 | ----------- | ------- | ----------- |
-| 2017-03-09  | v1.2.8  | Maintenance |
+| 2017-03-09  | v1.2.9  | Maintenance |
 | 2017-01-22  | v1.2.0  | Split the internal web notification API into a new project: simple-web-notification |
@@ -5,0 +5,0 @@ | 2017-01-13  | v1.0.26 | Maintenance |

package.json

 {
   "name": "angular-web-notification",
-  "version": "1.2.8",
+  "version": "1.2.9",
   "description": "AngularJS service for displaying web notifications.",
@@ -5,0 +5,0 @@ "author": {

README.md

@@ -111,3 +111,3 @@ # angular-web-notification
 | ----------- | ------- | ----------- |
-| 2017-03-09  | v1.2.8  | Maintenance |
+| 2017-03-09  | v1.2.9  | Maintenance |
 | 2017-01-22  | v1.2.0  | Split the internal web notification API into a new project: simple-web-notification |
@@ -114,0 +114,0 @@ | 2017-01-13  | v1.0.26 | Maintenance |

test/spec/angular-web-notification-spec.js

@@ -25,4 +25,17 @@ /*global describe: false, assert: false, inject: false, it: false, beforeEach: false */
 
-    beforeEach(inject(function (webNotification) {
-        webNotification.allowRequest = true;
+    it('library not defined test', inject(function ($injector) {
+        var showNotification = window.webNotification.showNotification;
+        delete window.webNotification.showNotification;
+
+        var errorDetected = false;
+        try {
+            $injector.get('webNotification').$get();
+        } catch (error) {
+            assert.isDefined(error);
+            errorDetected = true;
+        }
+
+        window.webNotification.showNotification = showNotification;
+
+        assert.isTrue(errorDetected);
     }));
@@ -40,3 +53,5 @@
                 inject(function (webNotification) {
+                    webNotification.allowRequest = true;
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setAllowed(function (title, options) {
@@ -61,3 +76,5 @@ assert.equal(title, 'Example Notification');
                 inject(function (webNotification) {
+                    webNotification.allowRequest = true;
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setAllowed(function (title, options) {
@@ -84,3 +101,5 @@ assert.equal(title, 'Example Notification');
                 inject(function (webNotification) {
+                    webNotification.allowRequest = true;
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setNotAllowed(function (title, options) {
@@ -112,3 +131,5 @@ assert.equal(title, 'first time');
                 inject(function (webNotification) {
+                    webNotification.allowRequest = true;
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setNotAllowed();
@@ -125,2 +146,3 @@
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setNotAllowed();
@@ -127,0 +149,0 @@ webNotification.allowRequest = false;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

72593

increased by3.96%

Number of package files

45

increased by7.14%

Lines of code

640

increased by2.07%

No dependency changes