apexcharts - npm Package Compare versions

Comparing version 1.3.16 to 1.3.17

package.json

 {
   "name": "apexcharts",
   "description": "A JavaScript Chart Library",
-  "version": "1.3.16",
+  "version": "1.3.17",
   "main": "dist/apexcharts.min.js",
@@ -6,0 +6,0 @@ "directories": {

src/apexcharts.js

@@ -85,2 +85,3 @@ import Annotations from './modules/Annotations'
         }).catch((e) => {
+          reject(e)
           // handle error in case no data or element not found
@@ -134,3 +135,3 @@ })
       const series = new Series(this.ctx)
-      series.handleNoData({appendToRoot: true})
+      series.handleNoData()
       return null
@@ -214,4 +215,7 @@ }
       // no data to display
-      if (me.el === null || graphData === null) {
+      if (me.el === null) {
         return reject(new Error('Not enough data to display or element not found'))
+      } else if (graphData === null) {
+        series.handleNoData()
+        return null
       }
@@ -372,3 +376,7 @@
 
-    return this.update()
+    return this.update().then(() => {
+      // update successful
+    }).catch((e) => {
+      throw new Error(e)
+    })
   }
@@ -406,3 +414,7 @@
 
-    return this.update()
+    return this.update().then(() => {
+      // update successful
+    }).catch((e) => {
+      throw new Error(e)
+    })
   }
@@ -438,3 +450,7 @@
 
-    return this.update()
+    return this.update().then(() => {
+      // update successful
+    }).catch((e) => {
+      throw new Error(e)
+    })
   }
@@ -456,4 +472,4 @@
         resolve(me)
-      }).catch(() => {
-        //
+      }).catch((e) => {
+        reject(e)
       })
@@ -637,3 +653,7 @@ })
       let graphData = this.create(this.w.config.series)
-      this.mount(graphData)
+      this.mount(graphData).then(() => {
+        // mount was successful
+      }).catch((e) => {
+        throw new Error(e)
+      })
     }, 150)
@@ -640,0 +660,0 @@ }

src/modules/axes/XAxis.js

@@ -121,2 +121,4 @@ import Graphics from '../Graphics'
 
+        if (!isFinite(label)) label = ''
+
         let offsetYCorrection = 28
@@ -123,0 +125,0 @@ if (w.globals.rotateXLabels) {

src/modules/Core.js

@@ -763,3 +763,3 @@ import Bar from '../charts/Bar'
 
-      if (w.config.xaxis.type === 'datetime' && w.config.xaxis.labels.formatter === undefined) {
+      if (w.config.xaxis.type === 'datetime' && w.config.xaxis.labels.formatter === undefined && isFinite(w.globals.minX) && isFinite(w.globals.maxX)) {
         let ts = new TimeScale(this.ctx)
@@ -766,0 +766,0 @@ ts.calculateTimeScaleTicks()

src/modules/Range.js

@@ -325,3 +325,3 @@ import Utils from '../utils/Utils'
     if (gl.dataXY || gl.noLabelsProvided) {
-      let ticks = 8
+      let ticks
 
@@ -328,0 +328,0 @@ if (cnf.xaxis.tickAmount === undefined) {

src/modules/Series.js

@@ -275,3 +275,3 @@ import Graphics from './Graphics'
 
-  handleNoData ({ appendToRoot = false, rootEl }) {
+  handleNoData () {
     const w = this.w
@@ -278,0 +278,0 @@ const me = this

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1289099

increased by0.06%

Lines of code

16612

increased by0.13%

No dependency changes