apollo-utilities - npm Package Compare versions

Comparing version 1.0.23 to 1.0.24

lib/bundle.umd.js

@@ -183,3 +183,5 @@ (function (global, factory) {
     function isIdValue(idObject) {
-        return idObject && idObject.type === 'id';
+        return idObject &&
+            idObject.type === 'id' &&
+            typeof idObject.generated === 'boolean';
     }
@@ -519,4 +521,2 @@ function toIdValue(idConfig, generated) {
             }
-            case "[object Date]":
-                return new Date(+val);
             case "[object Object]": {
@@ -527,22 +527,5 @@ if (seen.has(val))
                 seen.set(val, copy_2);
-                if (typeof Object.getOwnPropertyDescriptor === "function") {
-                    var handleKey = function (key) {
-                        var desc = Object.getOwnPropertyDescriptor(val, key);
-                        desc.value = cloneDeepHelper(val[key], seen);
-                        if (desc.get)
-                            delete desc.get;
-                        if (desc.set)
-                            delete desc.set;
-                        Object.defineProperty(copy_2, key, desc);
-                    };
-                    Object.getOwnPropertyNames(val).forEach(handleKey);
-                    if (typeof Object.getOwnPropertySymbols === "function") {
-                        Object.getOwnPropertySymbols(val).forEach(handleKey);
-                    }
-                }
-                else {
-                    Object.keys(val).forEach(function (key) {
-                        copy_2[key] = cloneDeepHelper(val[key], seen);
-                    });
-                }
+                Object.keys(val).forEach(function (key) {
+                    copy_2[key] = cloneDeepHelper(val[key], seen);
+                });
                 return copy_2;
@@ -549,0 +532,0 @@ }

lib/storeUtils.js

@@ -176,3 +176,5 @@ var __assign = (this && this.__assign) || function () {
 export function isIdValue(idObject) {
-    return idObject && idObject.type === 'id';
+    return idObject &&
+        idObject.type === 'id' &&
+        typeof idObject.generated === 'boolean';
 }
@@ -179,0 +181,0 @@ export function toIdValue(idConfig, generated) {

lib/util/cloneDeep.js

@@ -17,4 +17,2 @@ var toString = Object.prototype.toString;
         }
-        case "[object Date]":
-            return new Date(+val);
         case "[object Object]": {
@@ -25,22 +23,5 @@ if (seen.has(val))
             seen.set(val, copy_2);
-            if (typeof Object.getOwnPropertyDescriptor === "function") {
-                var handleKey = function (key) {
-                    var desc = Object.getOwnPropertyDescriptor(val, key);
-                    desc.value = cloneDeepHelper(val[key], seen);
-                    if (desc.get)
-                        delete desc.get;
-                    if (desc.set)
-                        delete desc.set;
-                    Object.defineProperty(copy_2, key, desc);
-                };
-                Object.getOwnPropertyNames(val).forEach(handleKey);
-                if (typeof Object.getOwnPropertySymbols === "function") {
-                    Object.getOwnPropertySymbols(val).forEach(handleKey);
-                }
-            }
-            else {
-                Object.keys(val).forEach(function (key) {
-                    copy_2[key] = cloneDeepHelper(val[key], seen);
-                });
-            }
+            Object.keys(val).forEach(function (key) {
+                copy_2[key] = cloneDeepHelper(val[key], seen);
+            });
             return copy_2;
@@ -47,0 +28,0 @@ }

package.json

 {
   "name": "apollo-utilities",
-  "version": "1.0.23",
+  "version": "1.0.24",
   "description": "Utilities for working with GraphQL ASTs",
@@ -56,3 +56,4 @@ "author": "James Baxley <[e-mail]>",
     "testURL": "http://localhost"
-  }
+  },
+  "gitHead": "45d1902c7c7948ef6a34184afbf2cf3120e44503"
 }

src/storeUtils.ts

@@ -274,3 +274,5 @@ import {
 export function isIdValue(idObject: StoreValue): idObject is IdValue {
-  return idObject && (idObject as IdValue | JsonValue).type === 'id';
+  return idObject &&
+    (idObject as IdValue | JsonValue).type === 'id' &&
+    typeof (idObject as IdValue).generated === 'boolean';
 }
@@ -277,0 +279,0 @@

src/util/cloneDeep.ts

@@ -22,5 +22,2 @@ const { toString } = Object.prototype;
 
-  case "[object Date]":
-    return new Date(+val) as T & Date;
-
   case "[object Object]": {
@@ -32,24 +29,5 @@ if (seen.has(val)) return seen.get(val);
     seen.set(val, copy);
-
-    if (typeof Object.getOwnPropertyDescriptor === "function") {
-      const handleKey = function (key: string | symbol) {
-        const desc = Object.getOwnPropertyDescriptor(val, key);
-        // If the property is backed by a getter function, this code turns it
-        // into a simple value property, though other descriptor properties like
-        // enumerable, writable, and configurable will be preserved.
-        desc.value = cloneDeepHelper((val as any)[key], seen);
-        if (desc.get) delete desc.get;
-        if (desc.set) delete desc.set;
-        Object.defineProperty(copy, key, desc);
-      };
-      Object.getOwnPropertyNames(val).forEach(handleKey);
-      if (typeof Object.getOwnPropertySymbols === "function") {
-        Object.getOwnPropertySymbols(val).forEach(handleKey);
-      }
-    } else {
-      Object.keys(val).forEach(key => {
-        copy[key] = cloneDeepHelper((val as any)[key], seen);
-      });
-    }
-
+    Object.keys(val).forEach(key => {
+      copy[key] = cloneDeepHelper((val as any)[key], seen);
+    });
     return copy;
@@ -56,0 +34,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Number of package files

90

increased by1.12%

Worsened metrics

Total package byte prevSize

276803

decreased by-1.25%

Lines of code

5018

decreased by-1.01%

No dependency changes