app-builder-lib - npm Package Compare versions

Comparing version 24.0.0-alpha.10 to 24.0.0-alpha.11

out/macPackager.js

@@ -150,3 +150,3 @@ "use strict";
             }
-            const targetOutDir = path.join(outDir, `${targetName}${(0, builder_util_1.getArchSuffix)(arch)}`);
+            const targetOutDir = path.join(outDir, `${targetName}${(0, builder_util_1.getArchSuffix)(arch, this.platformSpecificBuildOptions.defaultArch)}`);
             if (prepackaged == null) {
@@ -166,3 +166,3 @@ await this.doPack(outDir, targetOutDir, "mas", arch, masBuildOptions, [target]);
         if (!(0, macCodeSign_1.isSignAllowed)()) {
-            return;
+            return false;
         }
@@ -172,3 +172,3 @@ const isMas = masOptions != null;
         const qualifier = options.identity;
-        if (!isMas && qualifier === null) {
+        if (qualifier === null) {
             if (this.forceCodeSigning) {
@@ -178,3 +178,3 @@ throw new builder_util_1.InvalidConfigurationError("identity explicitly is set to null, but forceCodeSigning is set to true");
             builder_util_1.log.info({ reason: "identity explicitly is set to null" }, "skipped macOS code signing");
-            return;
+            return false;
         }
@@ -202,3 +202,3 @@ const keychainFile = (await this.codeSigningInfo.value).keychainFile;
                 await (0, macCodeSign_1.reportError)(isMas, certificateTypes, qualifier, keychainFile, this.forceCodeSigning);
-                return;
+                return false;
             }
@@ -290,2 +290,3 @@ }
         await this.notarizeIfProvided(appPath);
+        return true;
     }
@@ -292,0 +293,0 @@ async adjustSignOptions(signOptions, masOptions) {

out/options/PlatformSpecificBuildOptions.d.ts

@@ -120,2 +120,8 @@ import { CompressionLevel, Publish, TargetConfiguration, TargetSpecificOptions } from "../core";
     releaseDate?: string;
+    /**
+     * Vendor specific information.
+     */
+    vendor?: {
+        [key: string]: any;
+    } | null;
 }
@@ -122,0 +128,0 @@ /**

out/platformPackager.js

@@ -148,2 +148,4 @@ "use strict";
         }
+        // Due to node-gyp rewriting GYP_MSVS_VERSION when reused across the same session, we must reset the env var: https://github.com/electron-userland/electron-builder/issues/7256
+        delete process.env.GYP_MSVS_VERSION;
         const beforePack = resolveFunction(this.config.beforePack, "beforePack");
@@ -251,6 +253,11 @@ if (beforePack != null) {
         };
-        await this.signApp(packContext, isAsar);
+        const didSign = await this.signApp(packContext, isAsar);
         const afterSign = resolveFunction(this.config.afterSign, "afterSign");
         if (afterSign != null) {
-            await Promise.resolve(afterSign(packContext));
+            if (didSign) {
+                await Promise.resolve(afterSign(packContext));
+            }
+            else {
+                builder_util_1.log.warn(null, `skipping "afterSign" hook as no signing occurred, perhaps you intended "afterPack"?`);
+            }
         }
@@ -326,3 +333,3 @@ }
     signApp(packContext, isAsar) {
-        return Promise.resolve();
+        return Promise.resolve(false);
     }
@@ -329,0 +336,0 @@ getIconPath() {

out/targets/snap.js

@@ -61,2 +61,6 @@ "use strict";
             snap.base = options.base;
+            // from core22 onwards adapter is legacy
+            if (Number(snap.base.split("core")[1]) >= 22) {
+                delete appDescriptor.adapter;
+            }
         }
@@ -63,0 +67,0 @@ if (options.grade != null) {

out/version.d.ts

@@ -1,1 +0,1 @@
-export declare const PACKAGE_VERSION = "24.0.0-alpha.10";
+export declare const PACKAGE_VERSION = "24.0.0-alpha.11";

out/version.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PACKAGE_VERSION = void 0;
-exports.PACKAGE_VERSION = "24.0.0-alpha.10";
+exports.PACKAGE_VERSION = "24.0.0-alpha.11";
 //# sourceMappingURL=version.js.map

out/winPackager.d.ts

@@ -28,3 +28,3 @@ import { Arch } from "builder-util";
     protected createTransformerForExtraFiles(packContext: AfterPackContext): FileTransformer | null;
-    protected signApp(packContext: AfterPackContext, isAsar: boolean): Promise<any>;
+    protected signApp(packContext: AfterPackContext, isAsar: boolean): Promise<boolean>;
 }

out/winPackager.js

@@ -317,3 +317,3 @@ "use strict";
         if (this.platformSpecificBuildOptions.signAndEditExecutable === false) {
-            return;
+            return false;
         }
@@ -330,3 +330,3 @@ await bluebird_lst_1.default.map((0, promises_1.readdir)(packContext.appOutDir), (file) => {
         if (!isAsar) {
-            return;
+            return false;
         }
@@ -339,2 +339,3 @@ const signPromise = (filepath) => {
         await bluebird_lst_1.default.map(filesToSign.flat(1), file => this.sign(file), { concurrency: 4 });
+        return true;
     }
@@ -341,0 +342,0 @@ }

package.json

 {
   "name": "app-builder-lib",
   "description": "electron-builder lib",
-  "version": "24.0.0-alpha.10",
+  "version": "24.0.0-alpha.11",
   "main": "out/index.js",
@@ -59,8 +59,8 @@ "files": [
     "bluebird-lst": "^1.0.9",
-    "builder-util": "24.0.0-alpha.8",
-    "builder-util-runtime": "9.2.0-alpha.2",
+    "builder-util": "24.0.0-alpha.11",
+    "builder-util-runtime": "9.2.0-alpha.3",
     "chromium-pickle-js": "^0.2.0",
     "debug": "^4.3.4",
     "ejs": "^3.1.8",
-    "electron-publish": "24.0.0-alpha.8",
+    "electron-publish": "24.0.0-alpha.11",
     "form-data": "^4.0.0",
@@ -109,4 +109,4 @@ "fs-extra": "^10.1.0",
     "@types/tar": "^6.1.3",
-    "dmg-builder": "24.0.0-alpha.10",
-    "electron-builder-squirrel-windows": "24.0.0-alpha.10"
+    "dmg-builder": "24.0.0-alpha.11",
+    "electron-builder-squirrel-windows": "24.0.0-alpha.11"
   },
@@ -113,0 +113,0 @@ "//": "electron-builder-squirrel-windows and dmg-builder added as dev dep for tests (as otherwise `require` doesn't work using Yarn 2)",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2908000

increased by0.08%

Lines of code

22530

increased by0.13%

Worsened metrics

Number of low supply chain risk alerts

151

increased by0.67%

Dependency changes

• + Addedbuilder-util@24.0.0-alpha.11(transitive)

• + Addedbuilder-util-runtime@9.2.0-alpha.3(transitive)

• + Addedelectron-publish@24.0.0-alpha.11(transitive)

• - Removedbuilder-util@24.0.0-alpha.8(transitive)

• - Removedbuilder-util-runtime@9.2.0-alpha.2(transitive)

• - Removedelectron-publish@24.0.0-alpha.8(transitive)

• Updatedbuilder-util@24.0.0-alpha.11

• Updatedbuilder-util-runtime@9.2.0-alpha.3

• Updatedelectron-publish@24.0.0-alpha.11