app-builder-lib - npm Package Compare versions

Comparing version 24.0.0-alpha.12 to 24.0.0-alpha.13

out/codeSign/windowsCodeSign.d.ts

@@ -21,3 +21,3 @@ import { WindowsConfiguration } from "../options/winOptions";
 }
-export declare function sign(options: WindowsSignOptions, packager: WinPackager): Promise<void>;
+export declare function sign(options: WindowsSignOptions, packager: WinPackager): Promise<boolean>;
 export interface FileCodeSigningInfo {
@@ -24,0 +24,0 @@ readonly file: string;

out/codeSign/windowsCodeSign.js

@@ -46,2 +46,3 @@ "use strict";
     }
+    return true;
 }
@@ -48,0 +49,0 @@ exports.sign = sign;

out/macPackager.d.ts

@@ -20,3 +20,3 @@ import { Arch, AsyncTaskManager } from "builder-util";
     protected doPack(outDir: string, appOutDir: string, platformName: ElectronPlatformName, arch: Arch, platformSpecificBuildOptions: MacConfiguration, targets: Array<Target>): Promise<any>;
-    pack(outDir: string, arch: Arch, targets: Array<Target>, taskManager: AsyncTaskManager): Promise<any>;
+    pack(outDir: string, arch: Arch, targets: Array<Target>, taskManager: AsyncTaskManager): Promise<void>;
     private sign;
@@ -29,5 +29,5 @@ private adjustSignOptions;
     applyCommonInfo(appPlist: any, contentsPath: string): Promise<void>;
-    protected signApp(packContext: AfterPackContext, isAsar: boolean): Promise<any>;
+    protected signApp(packContext: AfterPackContext, isAsar: boolean): Promise<boolean>;
     private notarizeIfProvided;
     private generateOptions;
 }

out/macPackager.js

@@ -374,22 +374,19 @@ "use strict";
     async signApp(packContext, isAsar) {
+        const readDirectoryAndSign = async (sourceDirectory, directories, filter) => {
+            await bluebird_lst_1.default.map(directories, async (file) => {
+                if (filter(file)) {
+                    await this.sign(path.join(sourceDirectory, file), null, null, null);
+                }
+                return null;
+            });
+            return true;
+        };
         const appFileName = `${this.appInfo.productFilename}.app`;
-        await bluebird_lst_1.default.map((0, promises_1.readdir)(packContext.appOutDir), async (file) => {
-            if (file === appFileName) {
-                const appPath = path.join(packContext.appOutDir, file);
-                await this.sign(appPath, null, null, null);
-            }
-            return null;
-        });
+        await readDirectoryAndSign(packContext.appOutDir, await (0, promises_1.readdir)(packContext.appOutDir), file => file === appFileName);
         if (!isAsar) {
-            return;
+            return true;
         }
         const outResourcesDir = path.join(packContext.appOutDir, "resources", "app.asar.unpacked");
-        await bluebird_lst_1.default.map((0, promise_1.orIfFileNotExist)((0, promises_1.readdir)(outResourcesDir), []), (file) => {
-            if (file.endsWith(".app")) {
-                return this.sign(path.join(outResourcesDir, file), null, null, null);
-            }
-            else {
-                return null;
-            }
-        });
+        await readDirectoryAndSign(outResourcesDir, await (0, promise_1.orIfFileNotExist)((0, promises_1.readdir)(outResourcesDir), []), file => file.endsWith(".app"));
+        return true;
     }
@@ -396,0 +393,0 @@ async notarizeIfProvided(appPath) {

out/platformPackager.d.ts

@@ -38,3 +38,3 @@ import { Arch, AsyncTaskManager, DebugLogger } from "builder-util";
     private copyAppFiles;
-    protected signApp(packContext: AfterPackContext, isAsar: boolean): Promise<any>;
+    protected signApp(packContext: AfterPackContext, isAsar: boolean): Promise<boolean>;
     getIconPath(): Promise<string | null>;
@@ -41,0 +41,0 @@ private computeAsarOptions;

out/version.d.ts

@@ -1,1 +0,1 @@
-export declare const PACKAGE_VERSION = "24.0.0-alpha.12";
+export declare const PACKAGE_VERSION = "24.0.0-alpha.13";

out/version.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PACKAGE_VERSION = void 0;
-exports.PACKAGE_VERSION = "24.0.0-alpha.12";
+exports.PACKAGE_VERSION = "24.0.0-alpha.13";
 //# sourceMappingURL=version.js.map

out/winPackager.d.ts

@@ -23,3 +23,3 @@ import { Arch } from "builder-util";
     getIconPath(): Promise<string | null>;
-    sign(file: string, logMessagePrefix?: string): Promise<void>;
+    sign(file: string, logMessagePrefix?: string): Promise<boolean>;
     private doSign;
@@ -26,0 +26,0 @@ signAndEditResources(file: string, arch: Arch, outDir: string, internalName?: string | null, requestedExecutionLevel?: RequestedExecutionLevel | null): Promise<void>;

out/winPackager.js

@@ -183,3 +183,3 @@ "use strict";
             }
-            return;
+            return true;
         }
@@ -205,3 +205,3 @@ if (logMessagePrefix == null) {
         }
-        await this.doSign({
+        return this.doSign({
             ...signOptions,
@@ -218,3 +218,3 @@ cscInfo,
                 await (0, windowsCodeSign_1.sign)(options, this);
-                break;
+                return true;
             }
@@ -231,2 +231,3 @@ catch (e) {
         }
+        return false;
     }
@@ -336,9 +337,9 @@ async signAndEditResources(file, arch, outDir, internalName, requestedExecutionLevel) {
         if (!isAsar) {
-            return false;
+            return true;
         }
-        const signPromise = (filepath) => {
+        const filesPromise = (filepath) => {
             const outDir = path.join(packContext.appOutDir, ...filepath);
             return (0, fs_1.walk)(outDir, (file, stat) => stat.isDirectory() || this.shouldSignFile(file));
         };
-        const filesToSign = await Promise.all([signPromise(["resources", "app.asar.unpacked"]), signPromise(["swiftshader"])]);
+        const filesToSign = await Promise.all([filesPromise(["resources", "app.asar.unpacked"]), filesPromise(["swiftshader"])]);
         await bluebird_lst_1.default.map(filesToSign.flat(1), file => this.sign(file), { concurrency: 4 });
@@ -345,0 +346,0 @@ return true;

package.json

 {
   "name": "app-builder-lib",
   "description": "electron-builder lib",
-  "version": "24.0.0-alpha.12",
+  "version": "24.0.0-alpha.13",
   "main": "out/index.js",
@@ -59,3 +59,3 @@ "files": [
     "bluebird-lst": "^1.0.9",
-    "builder-util": "24.0.0-alpha.11",
+    "builder-util": "24.0.0-alpha.13",
     "builder-util-runtime": "9.2.0-alpha.3",
@@ -65,3 +65,3 @@ "chromium-pickle-js": "^0.2.0",
     "ejs": "^3.1.8",
-    "electron-publish": "24.0.0-alpha.11",
+    "electron-publish": "24.0.0-alpha.13",
     "form-data": "^4.0.0",
@@ -110,4 +110,4 @@ "fs-extra": "^10.1.0",
     "@types/tar": "^6.1.3",
-    "dmg-builder": "24.0.0-alpha.12",
-    "electron-builder-squirrel-windows": "24.0.0-alpha.12"
+    "dmg-builder": "24.0.0-alpha.13",
+    "electron-builder-squirrel-windows": "24.0.0-alpha.13"
   },
@@ -114,0 +114,0 @@ "//": "electron-builder-squirrel-windows and dmg-builder added as dev dep for tests (as otherwise `require` doesn't work using Yarn 2)",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2932471

increased by0.01%

Worsened metrics

Lines of code

22846

Dependency changes

• + Addedbuilder-util@24.0.0-alpha.13(transitive)

• + Addedelectron-publish@24.0.0-alpha.13(transitive)

• - Removedbuilder-util@24.0.0-alpha.11(transitive)

• - Removedelectron-publish@24.0.0-alpha.11(transitive)

• Updatedbuilder-util@24.0.0-alpha.13

• Updatedelectron-publish@24.0.0-alpha.13