async - npm Package Compare versions

Comparing version 0.1.7 to 0.1.8

async/lib/async.js

@@ -426,3 +426,3 @@ /*global setTimeout: false, console: false */
                         }
-                        callback.call(null, err, args || null);
+                        callback.call(null, err, args);
                     });
@@ -459,3 +459,3 @@ }
                         }
-                        callback.call(null, err, args || null);
+                        callback.call(null, err, args);
                     });
@@ -462,0 +462,0 @@ }

async/package.json

@@ -5,3 +5,3 @@ { "name": "async"
 , "author": "Caolan McMahon"
-, "version": "0.1.7"
+, "version": "0.1.8"
 , "repository" :
@@ -8,0 +8,0 @@ { "type" : "git"

async/test/test-async.js

@@ -1252,1 +1252,71 @@ var async = require('../lib/async');
 };
+
+// Issue 10 on github: https://github.com/caolan/async/issues#issue/10
+exports['falsy return values in series'] = function (test) {
+    function taskFalse(callback) {
+        process.nextTick(function() {
+            callback(null, false);
+        });
+    };
+    function taskUndefined(callback) {
+        process.nextTick(function() {
+            callback(null, undefined);
+        });
+    };
+    function taskEmpty(callback) {
+        process.nextTick(function() {
+            callback(null);
+        });
+    };
+    function taskNull(callback) {
+        process.nextTick(function() {
+            callback(null, null);
+        });
+    };
+    async.series(
+        [taskFalse, taskUndefined, taskEmpty, taskNull],
+        function(err, results) {
+            test.same(results, [false, undefined, undefined, null]);
+            test.strictEqual(results[0], false);
+            test.strictEqual(results[1], undefined);
+            test.strictEqual(results[2], undefined);
+            test.strictEqual(results[3], null);
+            test.done();
+        }
+    );
+};
+
+// Issue 10 on github: https://github.com/caolan/async/issues#issue/10
+exports['falsy return values in parallel'] = function (test) {
+    function taskFalse(callback) {
+        process.nextTick(function() {
+            callback(null, false);
+        });
+    };
+    function taskUndefined(callback) {
+        process.nextTick(function() {
+            callback(null, undefined);
+        });
+    };
+    function taskEmpty(callback) {
+        process.nextTick(function() {
+            callback(null);
+        });
+    };
+    function taskNull(callback) {
+        process.nextTick(function() {
+            callback(null, null);
+        });
+    };
+    async.parallel(
+        [taskFalse, taskUndefined, taskEmpty, taskNull],
+        function(err, results) {
+            test.same(results, [false, undefined, undefined, null]);
+            test.strictEqual(results[0], false);
+            test.strictEqual(results[1], undefined);
+            test.strictEqual(results[2], undefined);
+            test.strictEqual(results[3], null);
+            test.done();
+        }
+    );
+};

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

3544

increased by1.96%

Worsened metrics

Total package byte prevSize

257440

decreased by-3.8%

Number of package files

16

decreased by-5.88%

No dependency changes