azure-search - npm Package Compare versions

Comparing version 0.0.2 to 0.0.3

index.js

@@ -57,35 +57,39 @@ var http = require('https');
 			});
-			res.on('end', function() {
-				if (cb) {
+			 res.on('end', function() {
 
-					if (res.statusCode === 401) return cb({code: res.statusCode, name:"Error", message:"Unauthorised"});
-					if (res.statusCode === 404) return cb({code: res.statusCode, name:"Error", message:"Not Found"});
-					if (res.statusCode >= 500) return cb({code: res.statusCode, name:"Error", message:"Server Error"});
-					if (res.statusCode >= 400) return cb({code: res.statusCode, name:"Error", message:"Bad Request"});
-					if (result) {
-						try{
-							if (overrides && overrides.Accept == "text/plain"){
-								// do nothing
-							} else {
-								result = JSON.parse(result);	
-							}
-							
-						} catch (err) {
-							if (cb){
-								cb("failed to parse JSON:\n" + err + "\n " + result, null, res);
-								cb = undefined;
-								return;
-							}
-						}
-						
+				if (!cb) return;
+
+				// Bail out if no result
+				if(!result){
+					if(res.statusCode < 200 || res.statusCode > 206){
+						return cb({ code: res.statusCode}, null, res); // Fail
 					} else {
-						result = undefined;
+						return cb(null, null, res); // Success with no body
 					}
-					if (cb){
-						cb(null, result, res);
-						cb = undefined;
-						return;
+				}
+
+				// Parse result
+				try {
+					if (overrides && overrides.Accept == "text/plain"){
+						// do nothing
+					} else {
+						result = JSON.parse(result);	
 					}
+				} catch (err) {
+					return cb("failed to parse JSON:\n" + err + "\n " + result, null, res);
 				}
-			});
+
+				// Check for Azure error
+				var error = result.error;
+				if (error){
+					error.code = error.code || res.statusCode; // This is currently not populated by azure
+					cb(error, null, res);
+				}
+				else {
+					cb(null, result, res);
+				}
+				return;
+             
+            });
+
 			res.on('error', function(err){
@@ -92,0 +96,0 @@ if (cb){

package.json

 {
   "name": "azure-search",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "A client for the Azure Search service",
@@ -5,0 +5,0 @@ "main": "index.js",

test.js

@@ -5,3 +5,3 @@ // to test, first create a search service in azure, and set the url and key here.
 	url: "https://xxx.search.windows.net",
-	key:"YYY"
+	key:"yyy"
 });
@@ -8,0 +8,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Network access

Supply chain risk

This module accesses the network.

Found 2 instances in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 2 instances in 1 package

Minified code

Quality

This package contains minified code. This may be harmless in some cases where minified code is included in packaged libraries, however packages on npm should not minify code.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

120663

increased by690.77%

Number of package files

9

increased by12.5%

Lines of code

705

increased by111.71%

Worsened metrics

Number of low quality alerts

3

increased by50%

Number of low supply chain risk alerts

4

increased byInfinity%

Number of medium supply chain risk alerts

3

increased by50%

No dependency changes