better-queue - npm Package Compare versions

Comparing version 2.1.0 to 2.1.1

lib/worker.js

@@ -66,10 +66,14 @@
   }
-  self._process = self.fn.call(self, tasks, function (err, result) {
-    if (!self.active) return;
-    if (err) {
-      self.failedBatch(err.message || err);
-    } else {
-      self.finishBatch(result);
-    }
-  });
+  try {
+    self._process = self.fn.call(self, tasks, function (err, result) {
+      if (!self.active) return;
+      if (err) {
+        self.failedBatch(err.message || err);
+      } else {
+        self.finishBatch(result);
+      }
+    })
+  } catch (err) {
+    self.failedBatch(err.message || err);
+  }
   self._process = self._process || {};
@@ -76,0 +80,0 @@ }

package.json

 {
   "name": "better-queue",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "Better Queue for NodeJS",
@@ -5,0 +5,0 @@ "main": "lib/queue.js",

test/basic.js

@@ -19,2 +19,13 @@ var assert = require('assert');
 
+  it('should catch thrown errors', function (done) {
+    var q = new Queue(function (n, cb) {
+      throw new Error("failed");
+    })
+    q.on('task_failed', function (taskId, msg) {
+      assert.equal(msg, "failed");
+      done();
+    })
+    q.push(1)
+  });
+
   it('should fail', function (done) {
@@ -21,0 +32,0 @@ var q = new Queue(function (n, cb) {

No alert changes

Improved metrics

Total package byte prevSize

63055

increased by0.55%

Lines of code

1597

increased by0.88%

No dependency changes