bfj - npm Package Compare versions

Comparing version 5.3.0 to 5.3.1

HISTORY.md

 # History
 
+## 5.3.1
+
+### Bug fixes
+
+* unpipe: prohibit unpipe from setting the ndjson option (90b61c6)
+
 ## 5.3.0
@@ -4,0 +10,0 @@

package.json

 {
   "name": "bfj",
-  "version": "5.3.0",
+  "version": "5.3.1",
   "description": "Big-friendly JSON. Asynchronous streaming functions for large JSON data sets.",
@@ -5,0 +5,0 @@ "homepage": "https://github.com/philbooth/bfj",

README.md

@@ -756,3 +756,3 @@ # BFJ
 
-`bfj.read` will not parse NDJSON.
+`bfj.unpipe` and `bfj.read` will not parse NDJSON.
 
@@ -759,0 +759,0 @@ ## Why does it default to bluebird promises?

src/unpipe.js

@@ -32,3 +32,3 @@ 'use strict'
 
-  parse(jsonstream, options)
+  parse(jsonstream, Object.assign({}, options, { ndjson: false }))
     .then(data => callback(null, data))
@@ -35,0 +35,0 @@ .catch(error => callback(error))

test/unit/unpipe.js

@@ -63,3 +63,3 @@ 'use strict'
         results.parse[0] = Promise.resolve('foo')
-        options = {}
+        options = { foo: 'bar', ndjson: true }
         unpipe((err, res) => {
@@ -87,4 +87,4 @@ error = err
         assert.isFunction(log.args.parse[0][0]._write)
-        assert.strictEqual(log.args.parse[0][1], options)
-        assert.lengthOf(Object.keys(log.args.parse[0][1]), 0)
+        assert.notStrictEqual(log.args.parse[0][1], options)
+        assert.deepEqual(log.args.parse[0][1], { foo: 'bar', ndjson: false })
       })
@@ -91,0 +91,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

305040

increased by0.06%

No dependency changes