bigscreen-player - npm Package Compare versions

Comparing version 3.5.0 to 3.6.0

package.json

 {
   "name": "bigscreen-player",
-  "version": "3.5.0",
+  "version": "3.6.0",
   "description": "Simplified media playback for bigscreen devices.",
@@ -5,0 +5,0 @@ "main": "script/bigscreenplayer.js",

script-test/bigscreenplayertest.js

@@ -112,2 +112,3 @@ require(
 
+          var mockDebugTool = jasmine.createSpyObj('mockDebugTool', ['apicall', 'time', 'event', 'tearDown', 'setRootElement']);
           mockPlayerComponentInstance = jasmine.createSpyObj('playerComponentMock', [
@@ -126,3 +127,4 @@ 'play', 'pause', 'isEnded', 'isPaused', 'setCurrentTime', 'getCurrentTime', 'getDuration', 'getSeekableRange',
             'bigscreenplayer/playercomponent': mockPlayerComponent,
-            'bigscreenplayer/plugins': Plugins
+            'bigscreenplayer/plugins': Plugins,
+            'bigscreenplayer/debugger/debugtool': mockDebugTool
           });
@@ -129,0 +131,0 @@

script/bigscreenplayer.js

@@ -122,5 +122,12 @@ define('bigscreenplayer/bigscreenplayer',
 
+      function toggleDebug () {
+        if (playerComponent) {
+          DebugTool.toggleVisibility();
+        }
+      }
+
       return {
         init: function (playbackElement, bigscreenPlayerData, newWindowType, enableSubtitles, newDevice, callbacks) {
           Chronicle.init();
+          DebugTool.setRootElement(playbackElement);
           device = newDevice;
@@ -280,3 +287,4 @@ windowType = newWindowType;
         },
-        convertVideoTimeSecondsToEpochMs: convertVideoTimeSecondsToEpochMs
+        convertVideoTimeSecondsToEpochMs: convertVideoTimeSecondsToEpochMs,
+        toggleDebug: toggleDebug
       };
@@ -283,0 +291,0 @@ }

script/debugger/debugpresenter.js

@@ -104,11 +104,6 @@ define('bigscreenplayer/debugger/debugpresenter',
 
-   function tearDown () {
-     view = undefined;
-   }
-
    return {
      init: init,
-     update: update,
-     tearDown: tearDown
+     update: update
    };
  });

script/debugger/debugtool.js

@@ -10,2 +10,3 @@ define('bigscreenplayer/debugger/debugtool',
    function DebugTool () {
+     var rootElement;
      var presenter = DebugPresenter;
@@ -27,4 +28,6 @@ var view;
        view = DebugView;
+       view.setRootElement(rootElement);
        view.init();
        presenter.init(view);
+       presenter.update(Chronicle.retrieve());
        Chronicle.registerForUpdates(presenter.update);
@@ -35,3 +38,2 @@ visible = true;
      function hide () {
-       presenter.tearDown();
        view.tearDown();
@@ -56,4 +58,11 @@ Chronicle.unregisterForUpdates(presenter.update);
 
+     function setRootElement (element) {
+       rootElement = element;
+     }
+
      function tearDown () {
        staticFieldValues = {};
+       if (visible) {
+         hide();
+       }
      }
@@ -63,2 +72,3 @@
        toggleVisibility: toggleVisibility,
+       setRootElement: setRootElement,
        info: Chronicle.info,
@@ -65,0 +75,0 @@ error: Chronicle.error,

script/debugger/debugview.js

 define('bigscreenplayer/debugger/debugview',
  function () {
    'use strict';
-   var logBox, logContainer, staticContainer, staticBox;
-   var appElement = document.getElementById('app');
+   var appElement, logBox, logContainer, staticContainer, staticBox;
 
@@ -13,2 +12,6 @@ function init () {
 
+     if (appElement === undefined) {
+       appElement = document.body;
+     }
+
      logBox.id = 'logBox';
@@ -56,2 +59,8 @@ logBox.style.position = 'absolute';
 
+   function setRootElement (root) {
+     if (root) {
+       appElement = root;
+     }
+   }
+
    function render (logData) {
@@ -76,4 +85,7 @@ var dynamicLogs = logData.dynamic;
    function tearDown () {
-     appElement.removeChild(document.getElementById('logBox'));
-     appElement.removeChild(document.getElementById('staticBox'));
+     if (appElement) {
+       appElement.removeChild(document.getElementById('logBox'));
+       appElement.removeChild(document.getElementById('staticBox'));
+       appElement = undefined;
+     }
      staticContainer = undefined;
@@ -87,2 +99,3 @@ logContainer = undefined;
      init: init,
+     setRootElement: setRootElement,
      render: render,
@@ -89,0 +102,0 @@ tearDown: tearDown

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

7616897

decreased by-2.8%

Number of package files

100

decreased by-0.99%

Lines of code

69656

decreased by-8.04%

No dependency changes