bikram-sambat - npm Package Compare versions

Comparing version 1.5.0 to 1.5.1

package.json

 {
   "name": "bikram-sambat",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "JS utilities for converting between the Nepali Bikram Sambat (Vikram Samvat) and Gregorian (standard European) calendars.",
@@ -23,3 +23,3 @@ "main": "src/index.js",
   "author": "alxndrsn",
-  "license": "ISC",
+  "license": "Apache-2.0",
   "bugs": {
@@ -33,4 +33,4 @@ "url": "https://github.com/alxndrsn/bikram-sambat.js/issues"
     "jshint": "^2.9.5",
-    "lodash": "^4.17.4",
-    "mocha": "^3.2.0"
+    "lodash": "^4.17.11",
+    "mocha": "^5.2.0"
   },
@@ -37,0 +37,0 @@ "dependencies": {

src/index.js

@@ -25,4 +25,3 @@ var toDevanagari = require('eurodigit/src/to_non_euro').devanagari;
 function daysInMonth(year, month) {
-  // TODO why does this accept 0?
-  if(month < 0 || month > 12) throw new Error('Invalid month value ' + month);
+  if(month < 1 || month > 12) throw new Error('Invalid month value ' + month);
   var delta = ENCODED_MONTH_LENGTHS[year - 2000];
@@ -74,9 +73,6 @@ if(typeof delta === 'undefined') throw new Error('No data for year: ' + year + ' BS');
   var timestamp = BS_EPOCH_TS;
+
   while(year >= BS_YEAR_ZERO) {
-    while(month >= 1) {
-      while(--day >= 0) {
-        timestamp += MS_PER_DAY;
-      }
-      day = daysInMonth(year, --month);
-    }
+    do while(day--) timestamp += MS_PER_DAY;
+    while(--month && (day = daysInMonth(year, month)));
     day = daysInMonth(--year, month = 12);
@@ -83,0 +79,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

8945

decreased by-0.84%

Number of package files

6

decreased by-14.29%

Lines of code

195

decreased by-2.5%

No dependency changes