bitcoinjs-lib - npm Package Compare versions

Comparing version 5.1.9 to 5.1.10

CHANGELOG.md

@@ -0,1 +1,5 @@
+# 5.1.10
+__fixed__
+- Fixed psbt.signInputAsync (and consequentially all Async signing methods) not handling rejection of keypair.sign properly (#1582)
+
 # 5.1.9
@@ -2,0 +6,0 @@ __fixed__

package.json

 {
   "name": "bitcoinjs-lib",
-  "version": "5.1.9",
+  "version": "5.1.10",
   "description": "Client-side Bitcoin JavaScript library",
@@ -5,0 +5,0 @@ "main": "./src/index.js",

src/psbt.js

@@ -491,5 +491,5 @@ 'use strict';
   ) {
-    return new Promise((resolve, reject) => {
+    return Promise.resolve().then(() => {
       if (!keyPair || !keyPair.publicKey)
-        return reject(new Error('Need Signer to sign input'));
+        throw new Error('Need Signer to sign input');
       const { hash, sighashType } = getHashAndSighashType(
@@ -502,3 +502,3 @@ this.data.inputs,
       );
-      Promise.resolve(keyPair.sign(hash)).then(signature => {
+      return Promise.resolve(keyPair.sign(hash)).then(signature => {
         const partialSig = [
@@ -511,3 +511,2 @@ {
         this.data.updateInput(inputIndex, { partialSig });
-        resolve();
       });
@@ -514,0 +513,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

220405

increased by0.06%

Worsened metrics

Lines of code

5701

decreased by-0.02%

No dependency changes