btcp - npm Package Compare versions

Comparing version 0.1.3 to 0.1.4

lib/tcp-browser.js

@@ -132,3 +132,5 @@ /*!
   async listen(...args) {
-    return;
+    const address = this.address();
+    this.emit('listening', address);
+    return address;
   }
@@ -135,0 +137,0 @@

lib/tcp.js

@@ -30,2 +30,3 @@ /*!
     this.server = new net.Server(handler);
+    this._reject = null;
 
@@ -41,2 +42,10 @@ this.server.on('close', () => {
     this.server.on('error', (err) => {
+      const reject = this._reject;
+
+      if (reject) {
+        this._reject = null;
+        reject(err);
+        return;
+      }
+
       this.emit('error', err);
@@ -46,3 +55,3 @@ });
     this.server.on('listening', () => {
-      this.emit('listening');
+      this.emit('listening', this.address());
     });
@@ -57,3 +66,7 @@ }
     return new Promise((resolve, reject) => {
-      this.server.close((err) => {
+      this._reject = reject;
+
+      const cb = (err) => {
+        this._reject = null;
+
         if (err) {
@@ -63,4 +76,12 @@ reject(err);
         }
+
         resolve();
-      });
+      };
+
+      try {
+        this.server.close(cb);
+      } catch (e) {
+        this._reject = null;
+        reject(e);
+      }
     });
@@ -83,8 +104,15 @@ }
     return new Promise((resolve, reject) => {
-      this.server.once('error', reject);
+      this._reject = reject;
+
       args.push(() => {
-        this.server.removeListener('error', reject);
-        resolve();
+        this._reject = null;
+        resolve(this.address());
       });
-      this.server.listen(...args);
+
+      try {
+        this.server.listen(...args);
+      } catch (e) {
+        this._reject = null;
+        reject(e);
+      }
     });
@@ -91,0 +119,0 @@ }

package.json

 {
   "name": "btcp",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "description": "TCP wrapper for node.js",
@@ -22,3 +22,3 @@ "keywords": [
   "devDependencies": {
-    "bmocha": "^0.1.0"
+    "bmocha": "^1.0.0"
   },
@@ -25,0 +25,0 @@ "engines": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

11129

increased by3.09%

Lines of code

421

increased by5.51%

Worsened metrics

Number of package files

7

decreased by-12.5%

No dependency changes