can-globals - npm Package Compare versions

Comparing version 0.0.0-pre.0 to 0.0.0-pre.1

can-globals-proto.js

 'use strict';
 require('./custom-event-pollyfill');
 
+function errorMessage(key){
+	return key + ' is not defined!';
+}
+
 function Globals() {
@@ -55,4 +59,3 @@ this.eventHandlers = {};
 	}
-	// TODO discuss this, it seem like a bad idea to me
-	throw key + 'is not defined!';
+	throw errorMessage(key);
 };
@@ -62,3 +65,3 @@
 	if (key !== '' && !this.properties[key]) {
-		throw key + ' is not defined!';
+		throw errorMessage(key);
 	}
@@ -84,3 +87,3 @@ return function(value) {
 	if (key !== '' && !this.properties[key]) {
-		throw key + ' is not defined!';
+		throw errorMessage(key);
 	}
@@ -101,3 +104,3 @@ var handlers = this.eventHandlers[key];
 	if (key !== '' && !this.properties[key]) {
-		throw key + ' is not defined!';
+		throw errorMessage(key);
 	}
@@ -113,3 +116,3 @@ if (!this.eventHandlers[key]) {
 	if (!this.properties[key]) {
-		throw key + ' is not defined!';
+		throw errorMessage(key);
 	}
@@ -126,3 +129,3 @@ var property = this.properties[key];
 	if (!this.properties[key]) {
-		throw key + ' is not defined!';
+		throw errorMessage(key);
 	}
@@ -129,0 +132,0 @@ var property = this.properties[key];

js/global/global-test.js

@@ -0,1 +1,2 @@
+'use strict';
 var getGlobal = require('./global');
@@ -2,0 +3,0 @@ var isBrowserWindow = require('../is-browser-window/is-browser-window');

js/js.js

 'use strict';
 var importMap = {
-	assign: require('./assign/assign'),
 	global: require('./global/global'),
-	isArrayLike: require('./is-array-like/is-array-like'),
-	isBrowserWindow: require('./is-browser-window/is-browser-window'),
-	isContainer: require('./is-container/is-container'),
-	isEmptyObject: require('./is-empty-object/is-empty-object'),
-	isFunction: require('./is-function/is-function'),
-	isIterable: require('./is-iterable/is-iterable'),
-	isNode: require('./is-node/is-node'),
-	isPlainObject: require('./is-plain-object/is-plain-object'),
-	isPromise: require('./is-promise/is-promise'),
-	isPromiseLike: require('./is-promise-like/is-promise-like'),
-	isString: require('./is-string/is-string'),
-	isWebWorker: require('./is-web-worker/is-web-worker'),
-	parseURI: require('./parse-uri/parse-uri')
+	isBrowserWindow: require('./is-browser-window/is-browser-window')
 };
 
+function defineGlobal(g, name){
+	g.define(name, function() {
+		return importMap[name];
+	});
+}
+
 module.exports = function(g) {
 	for (var name in importMap) {
 		if (importMap.hasOwnProperty(name)) {
-			(function(g, name){
-				g.define(name, function() {
-					return importMap[name];
-				});
-			})(g, name);
+			defineGlobal(g, name);
 		}
 	}
 };

js/test.js

 'use strict';
-require('./assign/assign-test');
 require('./global/global-test');
-require('./is-array-like/is-array-like-test');
 require('./is-browser-window/is-browser-window-test');
-require('./is-container/is-container-test');
-require('./is-empty-object/is-empty-object-test');
-require('./is-function/is-function-test');
-// TODO add tests for is-iterable
-require('./is-node/is-node-test');
-require('./is-plain-object/is-plain-object-test');
-// TODO add tests for is-promise
-require('./is-promise-like/is-promise-like-test');
-require('./is-string/is-string-test');
-require('./is-web-worker/is-web-worker-test');
-require('./parse-uri/parse-uri-test');

package.json

 {
   "name": "can-globals",
-  "version": "0.0.0-pre.0",
+  "version": "0.0.0-pre.1",
   "description": "This module provides a dependency injection container. Modules may define a key and specify a default value (which can be static, cached lazy, or dynamic lazy), but other code can set and reset the value as needed. There is also an event system, for alerting on value changes, both specific to a key and for any key.",
@@ -17,2 +17,3 @@ "main": "can-globals.js",
     "release:major": "npm version major && npm publish",
+    "document": "bit-docs",
     "build": "node build.js"
@@ -47,2 +48,3 @@ },
   "devDependencies": {
+    "bit-docs": "0.0.7",
     "formatio": "^1.2.0",
@@ -63,3 +65,22 @@ "jshint": "^2.9.5",
     }
+  },
+  "bit-docs": {
+    "dependencies": {
+      "bit-docs-glob-finder": "^0.0.5",
+      "bit-docs-dev": "^0.0.3",
+      "bit-docs-js": "^0.0.3",
+      "bit-docs-generate-readme": "^0.0.8"
+    },
+    "glob": {
+      "pattern": "**/*.{js,md}",
+      "ignore": [
+        "node_modules/**/*",
+        "**/*{-,_,}{test,qunit}{s,}.js"
+      ]
+    },
+    "readme": {
+      "apis": "./doc/apis.json"
+    },
+    "parent": "can-globals"
   }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

20355

decreased by-54.79%

Dev dependency count

9

increased by12.5%

Number of package files

25

decreased by-56.14%

Lines of code

505

decreased by-59.34%

No dependency changes