canvas - npm Package Compare versions

Comparing version 2.4.1 to 2.5.0

browser.js

@@ -8,3 +8,3 @@ /* globals document, ImageData */
 exports.createCanvas = function (width, height) {
-  return Object.assign(document.createElement('canvas'), { width, height })
+  return Object.assign(document.createElement('canvas'), { width: width, height: height })
 }
@@ -22,5 +22,5 @@
 
-exports.loadImage = function (src) {
-  return new Promise((resolve, reject) => {
-    const image = document.createElement('img')
+exports.loadImage = function (src, options) {
+  return new Promise(function (resolve, reject) {
+    const image = Object.assign(document.createElement('img'), options)
 
@@ -32,4 +32,4 @@ function cleanup () {
 
-    image.onload = () => { cleanup(); resolve(image) }
-    image.onerror = () => { cleanup(); reject(new Error(`Failed to load the image "${src}"`)) }
+    image.onload = function () { cleanup(); resolve(image) }
+    image.onerror = function () { cleanup(); reject(new Error('Failed to load the image "' + src + '"')) }
 
@@ -36,0 +36,0 @@ image.src = src

CHANGELOG.md

@@ -14,2 +14,10 @@ # Changelog
 
+2.5.0
+==================
+### Added
+* Support redirects when fetching images (using [simple-get](https://github.com/feross/simple-get)) (#1398)
+* Support Node.js v12
+### Fixed
+* Fix object literal & arrow function syntax usage for IE.
+
 2.4.1
@@ -16,0 +24,0 @@ ==================

lib/image.js

@@ -15,6 +15,7 @@ 'use strict';
 const Image = module.exports = bindings.Image
-const http = require("http")
-const https = require("https")
 const util = require('util')
 
+// Lazily loaded simple-get
+let get;
+
 const {GetSource, SetSource} = bindings;
@@ -50,13 +51,13 @@
 
-        const type = /^\s*https:\/\//.test(val) ? https : http
-        type.get(val, res => {
-          if (res.statusCode !== 200) {
+        if (!get) get = require('simple-get');
+
+        get.concat(val, (err, res, data) => {
+          if (err) return onerror(err)
+
+          if (res.statusCode < 200 || res.statusCode >= 300) {
             return onerror(new Error(`Server responded with ${res.statusCode}`))
           }
-          const buffers = []
-          res.on('data', buffer => buffers.push(buffer))
-          res.on('end', () => {
-            setSource(this, Buffer.concat(buffers));
-          })
-        }).on('error', onerror)
+
+          setSource(this, data)
+        })
       } else { // local file path assumed
@@ -63,0 +64,0 @@ setSource(this, val);

lib/parse-font.js

@@ -17,6 +17,6 @@ 'use strict'
 // https://drafts.csswg.org/css-fonts-3/#font-prop
-const weightRe = new RegExp(`(${weights}) +`, 'i')
-const styleRe = new RegExp(`(${styles}) +`, 'i')
-const variantRe = new RegExp(`(${variants}) +`, 'i')
-const stretchRe = new RegExp(`(${stretches}) +`, 'i')
+const weightRe = new RegExp('(' + weights + ') +', 'i')
+const styleRe = new RegExp('(' + styles + ') +', 'i')
+const variantRe = new RegExp('(' + variants + ') +', 'i')
+const stretchRe = new RegExp('(' + stretches + ') +', 'i')
 const sizeFamilyRe = new RegExp(
@@ -23,0 +23,0 @@ '([\\d\\.]+)(' + units + ') *'

package.json

 {
   "name": "canvas",
   "description": "Canvas graphics API backed by Cairo",
-  "version": "2.4.1",
+  "version": "2.5.0",
   "author": "TJ Holowaychuk <[e-mail]>",
@@ -51,4 +51,5 @@ "main": "index.js",
   "dependencies": {
-    "nan": "^2.12.1",
-    "node-pre-gyp": "^0.11.0"
+    "nan": "^2.13.2",
+    "node-pre-gyp": "^0.11.0",
+    "simple-get": "^3.0.3"
   },
@@ -55,0 +56,0 @@ "devDependencies": {

types/index.d.ts

@@ -297,3 +297,3 @@ // TypeScript Version: 3.0
  */
-export function loadImage(src: string|Buffer): Promise<Image>
+export function loadImage(src: string|Buffer, options?: any): Promise<Image>
 
@@ -300,0 +300,0 @@ /**

util/has_lib.js

@@ -14,3 +14,4 @@ var query = process.argv[2]
   '/usr/lib/arm-linux-gnueabihf',
-  '/usr/lib/arm-linux-gnueabi'
+  '/usr/lib/arm-linux-gnueabi',
+  '/usr/lib/aarch64-linux-gnu'
 ]
@@ -17,0 +18,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Network access

Supply chain risk

This module accesses the network.

Found 2 instances in 1 package

Improved metrics

Total package byte prevSize

360622

increased by1.36%

Number of medium supply chain risk alerts

2

decreased by-50%

Worsened metrics

Dependency count

3

increased by50%

Lines of code

1348

decreased by-0.15%

Dependency changes

• + Addedsimple-get@^3.0.3

• + Addeddecompress-response@4.2.1(transitive)

• + Addedmimic-response@2.1.0(transitive)

• + Addedsimple-concat@1.0.1(transitive)

• + Addedsimple-get@3.1.1(transitive)

• Updatednan@^2.13.2