chrome-remote-interface - npm Package Compare versions

Comparing version 0.24.0 to 0.24.1

lib/chrome.js

@@ -14,4 +14,9 @@ 'use strict';
     constructor(response) {
-        super(response.message);
-        Object.assign(this, response);
+        let message = response.message;
+        if (response.data) {
+            message += ` (${response.data})`;
+        }
+        super(message);
+        // attach the original response as well
+        this.response = response;
     }
@@ -84,3 +89,5 @@ }
                 if (error) {
-                    reject(new ProtocolError(response));
+                    reject(error instanceof Error
+                           ? error // low-level WebSocket error
+                           : new ProtocolError(response));
                 } else {
@@ -119,4 +126,12 @@ fulfill(response);
     const message = {'id': id, 'method': method, 'params': params || {}};
-    chrome._ws.send(JSON.stringify(message));
-    chrome._callbacks[id] = callback;
+    chrome._ws.send(JSON.stringify(message), function (err) {
+        if (err) {
+            // handle low-level WebSocket errors
+            if (typeof callback === 'function') {
+                callback(err);
+            }
+        } else {
+            chrome._callbacks[id] = callback;
+        }
+    });
 }
@@ -123,0 +138,0 @@

package.json

@@ -12,3 +12,3 @@ {
     "homepage": "https://github.com/cyrus-and/chrome-remote-interface",
-    "version": "0.24.0",
+    "version": "0.24.1",
     "repository": {
@@ -15,0 +15,0 @@ "type": "git",

README.md

@@ -782,2 +782,5 @@ chrome-remote-interface    [![Build Status](https://travis-ci.org/cyrus-and/chrome-remote-interface.svg?branch=master)](https://travis-ci.org/cyrus-and/chrome-remote-interface)
 
+In case of low-level WebSocket errors, the `error` parameter contains the
+originating `Error` object and no `response` is returned.
+
 Note that the field `id` mentioned in the [Chrome Debugging Protocol]
@@ -784,0 +787,0 @@ specification is managed internally and it is not exposed to the user.

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

969560

increased by0.07%

Lines of code

15541

increased by0.1%

Number of lines in readme file

849

increased by0.35%

No dependency changes