chromedriver - npm Package Compare versions

Comparing version 2.29.0 to 2.29.1

install.js

@@ -6,4 +6,3 @@ 'use strict';
 var helper = require('./lib/chromedriver');
-var http = require('http');
-var https = require('https');
+var request = require('request');
 var kew = require('kew');
@@ -13,3 +12,2 @@ var mkdirp = require('mkdirp');
 var rimraf = require('rimraf').sync;
-var url = require('url');
 var util = require('util');
@@ -121,3 +119,3 @@
 function getRequestOptions(downloadPath) {
-  var options = url.parse(downloadUrl);
+  var options = {uri: downloadPath};
   var proxyUrl = options.protocol === 'https:'
@@ -127,15 +125,6 @@ ? process.env.npm_config_https_proxy
   if (proxyUrl) {
-    options = url.parse(proxyUrl);
-    options.path = downloadPath;
-    options.headers = { Host: url.parse(downloadPath).host };
-    // Turn basic authorization into proxy-authorization.
-    if (options.auth) {
-      options.headers['Proxy-Authorization'] = 'Basic ' + new Buffer(options.auth).toString('base64');
-      delete options.auth;
-    }
-  } else {
-    options = url.parse(downloadPath);
+    options.proxy = proxyUrl;
   }
 
-  options.rejectUnauthorized = !!process.env.npm_config_strict_ssl;
+  options.strictSSL = !!process.env.npm_config_strict_ssl;
 
@@ -146,3 +135,3 @@ // Use certificate authority settings from npm
     try {
-      ca = fs.readFileSync(process.env.npm_config_cafile, { encoding: 'utf8' })
+      ca = fs.readFileSync(process.env.npm_config_cafile, {encoding: 'utf8'})
         .split(/\n(?=-----BEGIN CERTIFICATE-----)/g);
@@ -175,19 +164,12 @@
   var deferred = kew.defer();
-  var client = get(requestOptions, function (response) {
-    var body = '';
-    if (response.statusCode === 200) {
-      response.addListener('data', function (data) {
-        body += data;
-      });
-      response.addListener('end', function () {
-        try {
-          chromedriver_version = JSON.parse(body);
-        } catch (err) {
-          deferred.reject('Unable to parse response as JSON', err);
-        }
-        deferred.resolve(true);
-      });
+  request.get(requestOptions, function (err, response, data) {
+    if (err) {
+      deferred.reject('Error with ' + requestOptions.protocol + ' request: ' + err);
     } else {
-      client.abort();
-      deferred.reject('Error with ' + requestOptions.protocol + ' request: ' + util.inspect(response.headers));
+      try {
+        chromedriver_version = JSON.parse(data);
+      } catch (jsonErr) {
+        deferred.reject('Unable to parse response as JSON', jsonErr);
+      }
+      deferred.resolve(true);
     }
@@ -205,48 +187,26 @@ });
 
-  var client = get(requestOptions, function (response) {
-    var status = response.statusCode;
-    console.log('Receiving...');
+  var client = request.get(requestOptions);
 
-    if (status === 200) {
-      response.addListener('data', function (data) {
-        fs.writeSync(outFile, data, 0, data.length, null);
-        count += data.length;
-        if ((count - notifiedCount) > 800000) {
-          console.log('Received ' + Math.floor(count / 1024) + 'K...');
-          notifiedCount = count;
-        }
-      });
+  client.on('error', function (err) {
+    deferred.reject('Error with http request: ' + err);
+  });
 
-      response.addListener('end', function () {
-        console.log('Received ' + Math.floor(count / 1024) + 'K total.');
-        fs.closeSync(outFile);
-        deferred.resolve(true);
-      });
-
-    } else {
-      client.abort();
-      deferred.reject('Error with http request: ' + util.inspect(response.headers));
+  client.on('data', function (data) {
+    fs.writeSync(outFile, data, 0, data.length, null);
+    count += data.length;
+    if ((count - notifiedCount) > 800000) {
+      console.log('Received ' + Math.floor(count / 1024) + 'K...');
+      notifiedCount = count;
     }
   });
 
+  client.on('end', function () {
+    console.log('Received ' + Math.floor(count / 1024) + 'K total.');
+    fs.closeSync(outFile);
+    deferred.resolve(true);
+  });
+
   return deferred.promise;
 }
 
-
-function get(requestOptions, callback, redirects) {
-  redirects = redirects || 0;
-  var protocol = requestOptions.protocol === 'https:' ? https : http;
-  var client = protocol.get(requestOptions, function (response) {
-    var status = response.statusCode;
-    if ((status === 302 || status === 301 || status === 307) && redirects < 5) {
-      console.log('Redirect to %s', response.headers.location);
-      redirects++;
-      return get(getRequestOptions(response.headers.location), callback, redirects);
-    }
-    callback(response);
-  });
-  return client;
-}
-
-
 function extractDownload(filePath, tmpPath) {
@@ -294,3 +254,2 @@ var deferred = kew.defer();
 
-
 function fixFilePermissions() {
@@ -297,0 +256,0 @@ // Check that the binary is user-executable and fix it if it isn't (problems with unzip library)

package.json

 {
   "name": "chromedriver",
-  "version": "2.29.0",
+  "version": "2.29.1",
   "keywords": [
@@ -36,4 +36,5 @@ "chromedriver",
     "mkdirp": "^0.5.1",
+    "request": "^2.81.0",
     "rimraf": "^2.5.4"
   }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Network access

Supply chain risk

This module accesses the network.

Found 2 instances in 1 package

Improved metrics

Number of medium supply chain risk alerts

2

decreased by-50%

Worsened metrics

Total package byte prevSize

21856

decreased by-5.98%

Dependency count

5

increased by25%

Lines of code

410

decreased by-8.28%

Dependency changes

• + Addedrequest@^2.81.0

• + Addedajv@6.12.6(transitive)

• + Addedasn1@0.2.6(transitive)

• + Addedassert-plus@1.0.0(transitive)

• + Addedasynckit@0.4.0(transitive)

• + Addedaws-sign2@0.7.0(transitive)

• + Addedaws4@1.13.2(transitive)

• + Addedbcrypt-pbkdf@1.0.2(transitive)

• + Addedcaseless@0.12.0(transitive)

• + Addedcombined-stream@1.0.8(transitive)

• + Addedcore-util-is@1.0.2(transitive)

• + Addeddashdash@1.14.1(transitive)

• + Addeddelayed-stream@1.0.0(transitive)

• + Addedecc-jsbn@0.1.2(transitive)

• + Addedextend@3.0.2(transitive)

• + Addedextsprintf@1.3.0(transitive)

• + Addedfast-deep-equal@3.1.3(transitive)

• + Addedfast-json-stable-stringify@2.1.0(transitive)

• + Addedforever-agent@0.6.1(transitive)

• + Addedform-data@2.3.3(transitive)

• + Addedgetpass@0.1.7(transitive)

• + Addedhar-schema@2.0.0(transitive)

• + Addedhar-validator@5.1.5(transitive)

• + Addedhttp-signature@1.2.0(transitive)

• + Addedis-typedarray@1.0.0(transitive)

• + Addedisstream@0.1.2(transitive)

• + Addedjsbn@0.1.1(transitive)

• + Addedjson-schema@0.4.0(transitive)

• + Addedjson-schema-traverse@0.4.1(transitive)

• + Addedjson-stringify-safe@5.0.1(transitive)

• + Addedjsprim@1.4.2(transitive)

• + Addedmime-db@1.52.0(transitive)

• + Addedmime-types@2.1.35(transitive)

• + Addedoauth-sign@0.9.0(transitive)

• + Addedperformance-now@2.1.0(transitive)

• + Addedpsl@1.9.0(transitive)

• + Addedpunycode@2.3.1(transitive)

• + Addedqs@6.5.3(transitive)

• + Addedrequest@2.88.2(transitive)

• + Addedsafe-buffer@5.2.1(transitive)

• + Addedsafer-buffer@2.1.2(transitive)

• + Addedsshpk@1.18.0(transitive)

• + Addedtough-cookie@2.5.0(transitive)

• + Addedtunnel-agent@0.6.0(transitive)

• + Addedtweetnacl@0.14.5(transitive)

• + Addeduri-js@4.4.1(transitive)

• + Addeduuid@3.4.0(transitive)

• + Addedverror@1.10.0(transitive)